http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18
Created attachment 123118 [details] [review] Bug 28750: (bug 17600 follow-up) Use full path for subroutines Throughout the file we call methods with the module Following suit rather than importing the methods To test: 1 - Attempt to load advanced cataloging editor 2 - it fails 3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define 4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 5 - Apply patch 6 - Cataloging editor loads! 7 - Link in #3 loads!
I think there are all the svc scripts that need to be double checked. I can do it on Monday if nobody beats me to it.
Created attachment 123121 [details] [review] Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds
Created attachment 123124 [details] [review] Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds
Created attachment 123144 [details] [review] Bug 28750: fix svc/bib_framework
Created attachment 123154 [details] [review] Bug 28750: (bug 17600 follow-up) Use full path for subroutines Throughout the file we call methods with the module Following suit rather than importing the methods To test: 1 - Attempt to load advanced cataloging editor 2 - it fails 3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define 4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 5 - Apply patch 6 - Cataloging editor loads! 7 - Link in #3 loads! Signed-off-by: David Nind <david@davidnind.com>
Created attachment 123155 [details] [review] Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds Signed-off-by: David Nind <david@davidnind.com>
Created attachment 123156 [details] [review] Bug 28750: fix svc/bib_framework Signed-off-by: David Nind <david@davidnind.com>
Testing notes (koha-testing-docker) - Before applying patches: . can edit and save a record using the default editor (for example, edit title for a book - where BKS framework used) . can't edit using advanced editor: sits on screen with icon going around "Loading..." . result from accessing URL in step 3 is error in step 4 of test plan - After applying patches: . advanced editor loads! . any edits using the normal or advanced editor complain about missing 003 field (didn't before the patch, even though was mandatory before and doesn't display by default) . page with framework data loads for URL in step 3 . can edit and save records using the advanced editor (and normal editor)
Pushed to master for 21.11, thanks to everybody involved!