Bug 21469 - Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow'
Summary: Account for 'MarcOrgCode' preference in 'Enhanced Analytics Workflow'
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL: https://wiki.koha-community.org/wiki/...
Keywords:
Depends on: 28830
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-02 09:22 UTC by Martin Renvoize (ashimema)
Modified: 2024-07-01 11:38 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 21469: Add 003 into 773$w when required (1.42 KB, patch)
2021-09-02 11:12 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 21469: Add 003 into 773$w when required (1.86 KB, patch)
2021-09-02 11:20 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 21469: Add 003 into 773$w when required (1.83 KB, patch)
2024-06-28 16:00 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2018-10-02 09:22:13 UTC
Whilst working through bug 11175 I was reminded of our inconsistent use of useControlNumber and it's lack of accounting for 003 fields.
Comment 1 Martin Renvoize (ashimema) 2021-08-06 06:44:27 UTC
With the introduction of the ability to search using 003 as part of the query for analytics, we should account for this in the cataloguing workflow.

We should check for the presence of 'MarcOrgCode' being defined (at library or system level) and if it is being used we should copy the value of the 003 of the parent record into the constructed 773.
Comment 2 Katrin Fischer 2021-08-07 14:01:33 UTC
This makes sense, but I think we need a depends on for the bug adding the 003 index?
Comment 3 Martin Renvoize (ashimema) 2021-09-02 11:12:00 UTC
Created attachment 124426 [details] [review]
Bug 21469: Add 003 into 773$w when required

This patch looks at the MarcOrgCode preference and if present it will
prepend the host 003 data in brackets to the 773$w link field in the
child record.
Comment 4 Martin Renvoize (ashimema) 2021-09-02 11:20:41 UTC
Created attachment 124427 [details] [review]
Bug 21469: Add 003 into 773$w when required

This patch looks at the MarcOrgCode preference and if present it will
prepend the host 003 data in brackets to the 773$w link field in the
child record.
Comment 5 Martin Renvoize (ashimema) 2021-09-02 11:23:16 UTC
I'd love your help with writing a test plan for this Katrin..

I think it should work as expected, but I'm not even actually sure if we need to bind it on the presence of MARCOrgCodes being defined.. we might actually be OK just always prepending 003 if/when it's present in the host record.
Comment 6 Martin Renvoize (ashimema) 2024-06-28 16:00:12 UTC
Created attachment 168272 [details] [review]
Bug 21469: Add 003 into 773$w when required

This patch looks at the MarcOrgCode preference and if present it will
prepend the host 003 data in brackets to the 773$w link field in the
child record.
Comment 7 Katrin Fischer 2024-06-28 17:07:42 UTC
Is this to add the MARCOrgCode to 773 when using the "Add analytics" button in the cataloguing editor? Sorry, slightly confused right now again by our analytics :)

Not related to this, but wondering from looking at the patch: Shouldn't the 11 here not be 111?
if ( $field = $host->field('100') || $host->field('110') || $host->field('11') ) {
Comment 8 Martin Renvoize (ashimema) 2024-07-01 08:08:11 UTC
Haha, that 11 instead of 111 may well have been you in bug 6831. I didn't change it here.
Comment 9 Martin Renvoize (ashimema) 2024-07-01 08:11:47 UTC
This is around the 'UseControlNumber' and 'Enhanced workflow' stuff.

It's all related to the work we were doing around the time in 2018 and 2021 to try and clarify and improve the 003 + 001 MARC linking stuff.
Comment 10 Katrin Fischer 2024-07-01 11:38:43 UTC
I just couldn't wrap my mind around it first time, I will try again a little later. Thanks for the patch!