If you allow copying or scanning parts of books, a very common question is: I would like to receive a copy/scan of the table of contents.
Created attachment 125190 [details] [review] Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 125191 [details] [review] Bug 29093: {DO NOT PUSH] DBIx schema changes Note: Pending table changes in PQA.
Created attachment 125192 [details] [review] Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 125288 [details] [review] Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 125289 [details] [review] Bug 29093: {DO NOT PUSH] DBIx schema changes Note: Pending table changes in PQA. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 125290 [details] [review] Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com>
(In reply to David Nind from comment #6) > Signed-off-by: David Nind <david@davidnind.com> Thx David
Created attachment 125448 [details] [review] Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 125449 [details] [review] Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
A few things to mention, not blockers: 1 - The DBIC patch includes changes from other bugs, I had to generate my own for testing 2 - Why TINYINT(4) - it seems to be treated as a TINYINT(1) / Boolean? 3 - While it makes display easier, is TOC friendly for translations? It would be nice to have a hover text with the full 'Table of Contents' at least
(In reply to Nick Clemens from comment #10) Thanks ! > A few things to mention, not blockers: > 1 - The DBIC patch includes changes from other bugs, I had to generate my > own for testing Yes, sorry for that. But the RM will disregard it anyway and do a fresh DBIx update. > 2 - Why TINYINT(4) - it seems to be treated as a TINYINT(1) / Boolean? Tinyint is just a byte. The four positions is display width and actually irrelevant for our templates. But theoretically, you are right :) > 3 - While it makes display easier, is TOC friendly for translations? It > would be nice to have a hover text with the full 'Table of Contents' at least Good point. Will have a look.
Created attachment 125450 [details] [review] Bug 29093: (QA follow-up) Adding two hover texts See QA request. Adding TOC hover text to: - OPAC user page, tab Article requests - Patron details page, Check out, tab Article requests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 125772 [details] [review] Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 125773 [details] [review] Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 125774 [details] [review] Bug 29093: (QA follow-up) Adding two hover texts See QA request. Adding TOC hover text to: - OPAC user page, tab Article requests - Patron details page, Check out, tab Article requests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 125775 [details] [review] [DO NOT PUSH] DBIx schema changes
Rebased on top of current master including the three pushed AR patch sets of this morning.
One moment please, still having a small issue here
Created attachment 125787 [details] [review] Bug 29093: Database revision for article_requests.toc_request Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 125788 [details] [review] Bug 29093: Interface changes Show the TOC checkbox on OPAC and staff. Test plan: Add new article request on OPAC or staff. Tick checkbox. Verify if TOC is Yes on opac-user or staff patron details. Check the list view on circ/article-requests.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 125789 [details] [review] Bug 29093: (QA follow-up) Adding two hover texts See QA request. Adding TOC hover text to: - OPAC user page, tab Article requests - Patron details page, Check out, tab Article requests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 125790 [details] [review] Bug 29093: (follow-up) Fix the all fields empty-warning We should allow checking the TOC box only. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 125791 [details] [review] Bug 29093: (QA follow-up) Rebasing issue Bug 27944 added another block for the new stage introduced. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 125792 [details] [review] DBIx schema changes
Pushed to master for 21.11, thanks to everybody involved!
This bug introduced a database comment inconsistency on toc_request. Will address that on bug 34843