Follow-up of report 29093. We should add a line showing if TOC was requested.
Created attachment 131654 [details] [review] Bug 30290: Adjust sample_notices.yml Test plan: Run a new install. Check the AR notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 131655 [details] [review] Bug 30290: Database revision for existing notices Note: It will be hard to update translated notices. If we cannot find the part 'Pages:' then the replace does not do anything. Test plan: Run db rev. Check an existing AR notice (English). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 131656 [details] [review] Bug 30290: (follow-up) Add warning for translated notices Note: Problem is that we cannot know if default was translated or en contains the original notice. Actually this holds for the other languages too. So this is an educated guess without using the lang field. Test plan: Run db rev. Trigger the warning by replacing Pages by PPages in an AR notice. Run db rev again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 133468 [details] [review] Bug 30290: Adjust sample_notices.yml Test plan: Run a new install. Check the AR notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 133469 [details] [review] Bug 30290: Database revision for existing notices Note: It will be hard to update translated notices. If we cannot find the part 'Pages:' then the replace does not do anything. Test plan: Run db rev. Check an existing AR notice (English). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 133470 [details] [review] Bug 30290: (follow-up) Add warning for translated notices Note: Problem is that we cannot know if default was translated or en contains the original notice. Actually this holds for the other languages too. So this is an educated guess without using the lang field. Test plan: Run db rev. Trigger the warning by replacing Pages by PPages in an AR notice. Run db rev again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I tested this and works as expected. My only doubt would be the wording. I'd prefer to see: Include TOC: yes/no but no strongly attached to it.
Created attachment 133730 [details] [review] Bug 30290: (QA follow-up) Sample notices: Change phrasing to Yes/No
Created attachment 133731 [details] [review] Bug 30290: Adjust sample_notices.yml Test plan: Run a new install. Check the AR notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 133732 [details] [review] Bug 30290: Database revision for existing notices Note: It will be hard to update translated notices. If we cannot find the part 'Pages:' then the replace does not do anything. Test plan: Run db rev. Check an existing AR notice (English). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 133733 [details] [review] Bug 30290: (follow-up) Add warning for translated notices Note: Problem is that we cannot know if default was translated or en contains the original notice. Actually this holds for the other languages too. So this is an educated guess without using the lang field. Test plan: Run db rev. Trigger the warning by replacing Pages by PPages in an AR notice. Run db rev again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 133734 [details] [review] Bug 30290: (QA follow-up) Sample notices/database update: Change phrasing to Yes/No Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Tomás Cohen Arazi from comment #7) > I tested this and works as expected. My only doubt would be the wording. I'd > prefer to see: > > Include TOC: yes/no > > but no strongly attached to it. I had the same feeling so I povided a follow-up with this change. As we had been burnt on bug 29805 with old MySQL versions, I also verified that RLIKE and REGEXP are both ok to use: https://dev.mysql.com/doc/refman/5.7/en/regexp.html
Pushed to master for 22.05, thanks to everybody involved [U+1F984]