With 29100 we can improve the notices to show how TT can be used to get all the information we need here and have nice formatting (replacing items.content especially).
DUE and PREDUE got handled in Bug 36106, but we still need to update the digest versions.
Created attachment 175337 [details] [review] Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct
The email type Item due reminder notice has a small mistake. On line 744 the checkouts array variable name needs to be in lowercase like [% FOREACH checkout IN checkouts %] or else the items' title author and barcode do not render. The other 3 notices displayed correctly
Created attachment 176390 [details] [review] Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT update to correct CHECKOUT capitalization To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct
(In reply to Brendan Lawlor from comment #3) > The email type Item due reminder notice has a small mistake. > > On line 744 the checkouts array variable name needs to be in lowercase like > [% FOREACH checkout IN checkouts %] > > or else the items' title author and barcode do not render. > > The other 3 notices displayed correctly Whoops! Thanks for catching.
Created attachment 176391 [details] [review] Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 176392 [details] [review] Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT update to correct CHECKOUT capitalization To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 176652 [details] [review] Bug 32211: Update DUEDGST and PREDUEDGST default notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Check Digests only for both Advance notice - Select 1 day in advance - Check SMS - Check Email - Check Digest only for both 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out 2+ items 7. Set a custom due date for tomorrow and check out 2+ more items 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>