Bug 29389 - Add holding branch to holds queue report
Summary: Add holding branch to holds queue report
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
Depends on: 29015
  Show dependency treegraph
Reported: 2021-11-02 11:57 UTC by Nick Clemens
Modified: 2021-11-03 11:52 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:

Bug 29389: Add holding branch to the holds queue report (2.60 KB, patch)
2021-11-02 12:01 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2021-11-02 11:57:07 UTC
When viewing 'All' branches for the holds queue, it would be nice to be able to see which branch the item is located in
Comment 1 Nick Clemens 2021-11-02 12:01:14 UTC
Created attachment 127212 [details] [review]
Bug 29389: Add holding branch to the holds queue report

This patch adds the holding branch to the hold queue report.
It is added as hidden by default, when running per branch it is not needed

To test:
1 - Place some holds in your system
2 - perl misc/cronjobs/holds/build_holdsqueue.pl
3 - View the holds queue
4 - Note there is no holding branch column
5 - Apply patch
6 - Reload
7 - Note the column is not there
8 - Click column setting gear
9 - Check the column and confirm it appears
10 - Confirmthe filter works
Comment 2 Katrin Fischer 2021-11-02 14:41:48 UTC
Thx :)
Comment 3 Owen Leonard 2021-11-03 11:52:30 UTC
I don't think the new column should be first. Title is almost always first in tables like this and I think we should keep it consistent.

The new column should be called "Current library" to be consistent with the detail page and holds awaiting pickup.