many lines : [WARN] Use of uninitialized value $value in substitution (s///) at /home/koha/src/C4/SIP/Sip.pm line 108 A simple add in sub maybe_add could correct that issue
Created attachment 127514 [details] [review] remove unnecessary warns in the logs Test plan : 1° do for example '9900802.00' as a self-check machine. 2° check the SIP logs (usually in /var/log/syslog) without the patch you must have many : [WARN] Use of uninitialized value $value in substitution (s///) at /home/koha/src/C4/SIP/Sip.pm line 108 3° apply the patch 4° re do '9900802.00' 5° check the logs => no more unnecessary warns thx
Created attachment 127540 [details] [review] Bug 29452: remove unnecessary warns in the logs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 127541 [details] [review] Bug 29452: remove unnecessary warns in the logs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Clear fix, works as expected.. Trivial patch. Going straight for QA.. Passed
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.12
Backported: Pushed to 20.05.x branch for 20.05.18
Not backporting to 19.11.x - LTS version will just backport security patches