Bug 29505 - Add syspref to allow to place multiple holds on same item
Summary: Add syspref to allow to place multiple holds on same item
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-17 16:15 UTC by Julian Maurice
Modified: 2022-03-09 22:34 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 29505: Add syspref to allow to place multiple holds on same item (7.56 KB, patch)
2021-11-17 16:19 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2021-11-17 16:15:46 UTC

    
Comment 1 Julian Maurice 2021-11-17 16:19:03 UTC
Created attachment 127734 [details] [review]
Bug 29505: Add syspref to allow to place multiple holds on same item

Test plan:
1. Run installer/data/mysql/updatedatabase.pl
2. Enable syspref AllowMultipleHoldsOnSameItem
3. Try to place multiple holds for the same patron on the same item.
   Unless another circulation rule forbid this (like the maximum number
   of holds per record), it should work
4. Run `prove t/db_dependent/Holds/AllowMultipleHoldsOnSameItem.t`
Comment 2 Katrin Fischer 2021-11-18 09:37:07 UTC
Hi Julian,

is this about item level or biblio level holds?

I wonder if it could be a possible duplicate to Bug 15565 - Place multiple item-level holds at once for the same record.

Also not sure if this should be a system preference when we already have this option via the circulation rules (holds per record).

Can you explain a bit more?
Comment 3 Julian Maurice 2021-11-18 10:09:35 UTC
Hi Katrin,

Bug 15565 was about being able to place multiple title-level holds on the same biblio record. Looking at the bug's history it seems that these patches changed quite a bit and are now about item-level holds.
But it still does not allow to place a hold on the same item twice, which is what this new bug is about.

Combined with the syspref AllowHoldDateInFuture, it allows to place several holds on the same item for different dates
Comment 4 Shi Yao Wang 2022-03-09 22:34:35 UTC
Patch doesn't apply. There was a merge conflict with C4/Reserves.pm