Created attachment 128547 [details] [review] Bug 29698: Make items available for PREDUEDGST With this patch you can access items using: Number of items [% items.count %] [% FOR i IN items %] [% SET checkout = i.checkout %] Item [% i.itemnumber %] is due on [% checkout.date_due | $KohaDates %] [% END %]
It should work for DUEDGST as well but I haven't tested.
Created attachment 131644 [details] [review] Bug 29698: Make items available for PREDUEDGST With this patch you can access items using: Number of items [% items.count %] [% FOR i IN items %] [% SET checkout = i.checkout %] Item [% i.itemnumber %] is due on [% checkout.date_due | $KohaDates %] [% END %] Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
To test: 1. Add the following to PREDUEDGST and DUEDST: Number of items [% items.count %] [% FOR i IN items %] [% SET checkout = i.checkout %] Item [% i.itemnumber %] is due on [% checkout.date_due | $KohaDates %] [% END %] 2. Find a patron and set there messaging prefs 'Item due' and 'Advanced notices' so they get an email and 'digest only'. On 'Advanced notices' set Days in advance to 1. 3. Check some things out to a patron and make them due tomorrow. 4. perl /kohadevbox/koha/misc/cronjobs/advance_notices.pl -v -c 5. Check the patrons notices and make sure the PREDUEDGST looks right. 6. Check some things out to a patron and make them due today. 7. Repeat 4. 8. Check the patrons notices and make sure the DUEDGST looks right.
Created attachment 133556 [details] [review] Bug 29698: Make items available for PREDUEDGST With this patch you can access items using: Number of items [% items.count %] [% FOR i IN items %] [% SET checkout = i.checkout %] Item [% i.itemnumber %] is due on [% checkout.date_due | $KohaDates %] [% END %] == test plan == 1. Add the following to PREDUEDGST and DUEDST: Number of items [% items.count %] [% FOR i IN items %] [% SET checkout = i.checkout %] Item [% i.itemnumber %] is due on [% checkout.date_due | $KohaDates %] [% END %] 2. Find a patron and set there messaging prefs 'Item due' and 'Advanced notices' so they get an email and 'digest only'. On 'Advanced notices' set Days in advance to 1. 3. Check some things out to a patron and make them due tomorrow. 4. perl /kohadevbox/koha/misc/cronjobs/advance_notices.pl -v -c 5. Check the patrons notices and make sure the PREDUEDGST looks right. 6. Check some things out to a patron and make them due today. 7. Repeat 4. 8. Check the patrons notices and make sure the DUEDGST looks right. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, qa script happy, code looks good, passing QA :)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
*** Bug 34410 has been marked as a duplicate of this bug. ***