Bug 29986 - Descriptions of system internal debit types and credit types should be editable
Summary: Descriptions of system internal debit types and credit types should be editable
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-31 21:38 UTC by Katrin Fischer
Modified: 2022-11-21 22:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-01-31 21:38:04 UTC
The descriptions of system internal debit types and credit types are not translatable from the GUI. We should make that work, as the descriptions are used for display for example on the cashup summary print outs (see bug 27779)

As this leaves no way for people to fix translations for their use but SQL, I'd consider this is in a grey area to be a little more bug than enhancement.
Comment 1 Martin Renvoize (ashimema) 2022-07-08 13:40:52 UTC
Pretty sure those were done this way at the time as a requirement.. if we allow them to be edited then the translations break from memory.
Comment 2 Katrin Fischer 2022-07-08 15:29:51 UTC
I think we use the codes for the translation in the templates, so this should be ok. There is an additional description that is English by default and can be translated via the installer files. But when we add new system internal debit types/credit types that are added via the database updates, the library has no means to translate them as well and they will be a mix of languages.

I think the description might be used in reports.
Comment 3 Sara Brown 2022-11-21 22:34:14 UTC
It would be helpful in general for libraries to be able to edit these descriptions, not just for translating. For instance, if a library applies a refund to a manually invoiced charged that is not a fine, the description for REFUND (A refund applied to a patrons fine) won't be accurate. It can then be confusing for staff on reports.

(If this should be its own bug, I can file separately!)
Comment 4 Katrin Fischer 2022-11-21 22:43:41 UTC
(In reply to Sara Brown from comment #3)
> It would be helpful in general for libraries to be able to edit these
> descriptions, not just for translating. For instance, if a library applies a
> refund to a manually invoiced charged that is not a fine, the description
> for REFUND (A refund applied to a patrons fine) won't be accurate. It can
> then be confusing for staff on reports.
> 
> (If this should be its own bug, I can file separately!)

I think i would not have the effect you expect: the description from the database are basically only used for reporting. What you see in the templates is built from the codes, so they can be translated.