*** Bug 22316 has been marked as a duplicate of this bug. ***
*** Bug 27912 has been marked as a duplicate of this bug. ***
Created attachment 130364 [details] [review] Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130365 [details] [review] Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130366 [details] [review] Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130367 [details] [review] Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130368 [details] [review] Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130369 [details] [review] Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130370 [details] [review] Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130371 [details] [review] Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Tests are missing for the new API routes. I can provide them (even if they will be dumb), but I'd like to make sure you won't make me rewrite the whole thing before...
Created attachment 130372 [details] [review] Bug 30055: Prevent blink when page is loading
Hum, found something here. I removed the "patron_preview" thing.
Created attachment 130385 [details] [review] Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130386 [details] [review] Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130387 [details] [review] Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130388 [details] [review] Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130389 [details] [review] Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130390 [details] [review] Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130391 [details] [review] Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130392 [details] [review] Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 130393 [details] [review] Bug 30055: Prevent blink when page is loading
Created attachment 130394 [details] [review] Bug 30055: Restore patron's preview links
Created attachment 130395 [details] [review] Bug 30055: Add missing include to format addresses
(In reply to Jonathan Druart from comment #11) > Tests are missing for the new API routes. I can provide them (even if they > will be dumb), but I'd like to make sure you won't make me rewrite the whole > thing before... I find this implementation lovely.
I'm on board too, great work Jonathan!
Created attachment 130457 [details] [review] Bug 30055: Put extended attributes search back Last patches remove the ability to search on extended attributes. C4::Utils::DataTables::Members::search is searching on all the attributes that are flagged as "searchable", we want to keep this behaviour. I have tried several things and this is the simplest I have found.
Great enhancement, more API \o/
Hmm, right now I'm getting 404's on the API requests in my testing.. continuing to investigate. Couple of comments to get us started though.. * It might be nice to enable `"header_filter": true,` on the kohaTable.. the URL's are pretty crazy to read without it. * Was it a deliberate choice to use 'add_filters'.. for the guarantor search at least, this is a change and I'm not sure it makes sense to have the both sets of filters visible at the same time in the popup window?
Also, could we get a little update for the jsdoc for kohaTable for the changes/enhancements you've made.. especially the signature update for default_filters?
Created attachment 130487 [details] [review] Bug 30055: Add missing spec file for baskets
Created attachment 130488 [details] [review] Bug 30055: Fix when there is no searchable attr type No idea why we need that.
Created attachment 130491 [details] [review] Bug 30055: Missing search on othernames
Created attachment 130507 [details] [review] Bug 30055: Restore DefaultPatronSearchFields and fix extended attrs search We lost the DefaultPatronSearchFields behaviour, we don't want to search on all data but only DefaultPatronSearchFields
(In reply to Martin Renvoize from comment #29) > Hmm, right now I'm getting 404's on the API requests in my testing.. > continuing to investigate. > > Couple of comments to get us started though.. > > * It might be nice to enable `"header_filter": true,` on the kohaTable.. the > URL's are pretty crazy to read without it. Not strongly attached to that. Could switch to header_filter if your prefer. > * Was it a deliberate choice to use 'add_filters'.. for the guarantor search > at least, this is a change and I'm not sure it makes sense to have the both > sets of filters visible at the same time in the popup window? Yes, that's definitely a deliberate choice. The idea is to keep the same filters as before on top of the table, but provide a way to refine the search with the column's filters. I would like to have the same behaviour/UI on all patrons search. You also noticed the "Browse by last name" that will be there as well. (In reply to Martin Renvoize from comment #30) > Also, could we get a little update for the jsdoc for kohaTable for the > changes/enhancements you've made.. especially the signature update for > default_filters? Yep, I was waiting for the other bug follow-ups and feedbacks to make sure it's the correct way to accomplish that.
Created attachment 130511 [details] [review] Bug 30055: Missing search on othernames
Created attachment 130629 [details] [review] Bug 30055: (follow-up) Increase popup window size With the required addition of fields to the displayed result table, we need to increase the size of the popover window to prevent horizontal scrolling.
Created attachment 130630 [details] [review] Bug 30055: (follow-up) Clarify 'AND' logic
When I test searches which are limited to staff users I get an error: "Embedding objects is not allowed on this endpoint."
(In reply to Owen Leonard from comment #39) > When I test searches which are limited to staff users I get an error: > "Embedding objects is not allowed on this endpoint." Yes, it's the last patch that is causing problems. I am obsoleting it.
Created attachment 130671 [details] [review] Bug 30055: (follow-up) Add missing embed in fund owners
Created attachment 130672 [details] [review] Bug 30055: (follow-up) Add missing embeds This patch add the missing extended_attributes embed for /funds/owners, /funds/users and /suggestions/managers
(In reply to Jonathan Druart from comment #40) > (In reply to Owen Leonard from comment #39) > > When I test searches which are limited to staff users I get an error: > > "Embedding objects is not allowed on this endpoint." > > Yes, it's the last patch that is causing problems. I am obsoleting it. To clarify, this patch was not causing Owen's issue. However I found yesterday: https://snipboard.io/3eYNEw.jpg I am searching for "sss" which I know return 1 result (from extended attribute) then I filter general on "ed" => still one result => all good then: https://snipboard.io/HYJyuU.jpg I am adding "ed" to filter on surname It should NOT change anything in the result set, as "Edna" contains "ed" but it does not returning anything If I am continuing to play, I am getting a 500 at some point (don't know exactly from which point it happened) the 500 is: GET /api/v1/patrons: unhandled exception (DBIx::Class::Exception)<<SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: Supplying an empty left hand side argument is not supported. in array-pairs at /usr/share/perl5/Data/Page.pm line 49>> Koha::REST::Plugin::Exceptions::__ANON__ /kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73)... So the query is badly construct.
(In reply to Jonathan Druart from comment #43) > (In reply to Jonathan Druart from comment #40) > > (In reply to Owen Leonard from comment #39) > > > When I test searches which are limited to staff users I get an error: > > > "Embedding objects is not allowed on this endpoint." > > > > Yes, it's the last patch that is causing problems. I am obsoleting it. > > To clarify, this patch was not causing Owen's issue. However I found > yesterday: > > https://snipboard.io/3eYNEw.jpg > I am searching for "sss" which I know return 1 result (from extended > attribute) > then I filter general on "ed" => still one result > => all good > > then: https://snipboard.io/HYJyuU.jpg > I am adding "ed" to filter on surname > It should NOT change anything in the result set, as "Edna" contains "ed" but > it does not returning anything > If I am continuing to play, I am getting a 500 at some point (don't know > exactly from which point it happened) > the 500 is: > GET /api/v1/patrons: unhandled exception > (DBIx::Class::Exception)<<SQL::Abstract::puke(): [SQL::Abstract::__ANON__] > Fatal: Supplying an empty left hand side argument is not supported. > in array-pairs at /usr/share/perl5/Data/Page.pm line 49>> > Koha::REST::Plugin::Exceptions::__ANON__ > /kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73)... > So the query is badly construct. I can't replicate these issues
(In reply to Martin Renvoize from comment #44) > I can't replicate these issues Well, it's very easy to recreate. Create a new fresh ktd or use a sandbox, then add a guarantor: https://snipboard.io/bAUyDn.jpg remove "ed" from "Name" => you get "edna" Adding "ed" in Name should NOT remove Edna from the result list!
(In reply to Jonathan Druart from comment #45) > (In reply to Martin Renvoize from comment #44) > > I can't replicate these issues > > Well, it's very easy to recreate. > Create a new fresh ktd or use a sandbox, then add a guarantor: > https://snipboard.io/bAUyDn.jpg > > remove "ed" from "Name" => you get "edna" > Adding "ed" in Name should NOT remove Edna from the result list! tl;dr; version of the discussion on the chat: the version *without* Martin's patch has this bug as well... Yesterday the test I made was with search a pattern matching an extended attribute in the "main search", but that is not working either.
When limiting search via the table filters, dropdowns should be filtered on equality, not contains. To recreate: search for '%' in the search to return all patrons use category dropdown to limit to 'Patron' - works use category dropdown to limit to 'Teacher' - fail - you see 'Patron' and 'Student' categories because they contain 'T' - the code for 'Teacher'
Created attachment 130701 [details] [review] Bug 30055: (follow-up) Add missing embeds
Created attachment 130702 [details] [review] Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match.
(In reply to Nick Clemens from comment #47) > When limiting search via the table filters, dropdowns should be filtered on > equality, not contains. > > To recreate: > search for '%' in the search to return all patrons > use category dropdown to limit to 'Patron' - works > use category dropdown to limit to 'Teacher' - fail - you see 'Patron' and > 'Student' categories because they contain 'T' - the code for 'Teacher' Thanks!
(In reply to Jonathan Druart from comment #49) > Created attachment 130702 [details] [review] [review] > Bug 30055: Force exact match for dropdown > > For libraries and categories we need to use an exact match. This patch is a bit awkward, feel free to suggest a better alternative if you found one!
Created attachment 130704 [details] [review] Bug 30055: Don't hardcode the default sort column At this point it does not change anything, all calls to members/search.pl has "name" in second column, but that will be helpful in follow-up bugs.
Created attachment 130716 [details] [review] Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match.
Created attachment 130717 [details] [review] Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match.
(In reply to Jonathan Druart from comment #51) > (In reply to Jonathan Druart from comment #49) > > Created attachment 130702 [details] [review] [review] [review] > > Bug 30055: Force exact match for dropdown > > > > For libraries and categories we need to use an exact match. > > This patch is a bit awkward, feel free to suggest a better alternative if > you found one! What you really want is bug 29302, don't you?
(In reply to Tomás Cohen Arazi from comment #55) > (In reply to Jonathan Druart from comment #51) > > (In reply to Jonathan Druart from comment #49) > > > Created attachment 130702 [details] [review] [review] [review] [review] > > > Bug 30055: Force exact match for dropdown > > > > > > For libraries and categories we need to use an exact match. > > > > This patch is a bit awkward, feel free to suggest a better alternative if > > you found one! > > What you really want is bug 29302, don't you? I don't think so. Here we are syncing the form with the DT filters when the form is submitted. We are not initializing the table.
Created attachment 131829 [details] [review] Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match.
Created attachment 132168 [details] [review] Bug 30055: clear the column filter if none selected ie. search for "", not "^$"
Ok, I tested again, in the suggestions page: - First time I entered a search for 'a' it didn't show my own user, couldn't reproduce but worth mentioning - When you choose your own user, it is described as 'null koha' instead of the original 'You' that is displayed when you enter the page. - Missing tests for the routes
(In reply to Tomás Cohen Arazi from comment #59) > Ok, I tested again, in the suggestions page: > - When you choose your own user, it is described as 'null koha' instead of > the original 'You' that is displayed when you enter the page. This is already the case in master, nevermind.
Created attachment 132419 [details] [review] Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132420 [details] [review] Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132421 [details] [review] Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132422 [details] [review] Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132423 [details] [review] Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132424 [details] [review] Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132425 [details] [review] Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132426 [details] [review] Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132427 [details] [review] Bug 30055: Prevent blink when page is loading Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132428 [details] [review] Bug 30055: Restore patron's preview links Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132429 [details] [review] Bug 30055: Add missing include to format addresses Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132430 [details] [review] Bug 30055: Put extended attributes search back Last patches remove the ability to search on extended attributes. C4::Utils::DataTables::Members::search is searching on all the attributes that are flagged as "searchable", we want to keep this behaviour. I have tried several things and this is the simplest I have found. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132431 [details] [review] Bug 30055: Add missing spec file for baskets Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132432 [details] [review] Bug 30055: Fix when there is no searchable attr type No idea why we need that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132433 [details] [review] Bug 30055: Restore DefaultPatronSearchFields and fix extended attrs search We lost the DefaultPatronSearchFields behaviour, we don't want to search on all data but only DefaultPatronSearchFields Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132434 [details] [review] Bug 30055: Missing search on othernames Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132435 [details] [review] Bug 30055: (follow-up) Increase popup window size With the required addition of fields to the displayed result table, we need to increase the size of the popover window to prevent horizontal scrolling. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132436 [details] [review] Bug 30055: (follow-up) Add missing embeds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132437 [details] [review] Bug 30055: Don't hardcode the default sort column At this point it does not change anything, all calls to members/search.pl has "name" in second column, but that will be helpful in follow-up bugs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132438 [details] [review] Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132439 [details] [review] Bug 30055: clear the column filter if none selected ie. search for "", not "^$" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132440 [details] [review] Bug 30055: (QA follow-up) Minor QA fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132441 [details] [review] Bug 30055: API unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
All good so far. I learned why column search is important for big sites (thanks Severine). There's a false positive in the QA tools
About guarantor page (I'm not used to this functionality so I hope I use it correctly and tested it as expected) : 1) I love the big popup ! 2) I was surprised by the content of the table, as I expected something unified with the table in '-members-home.pl page, but it's not 3) Address is much bigger than the other informations, font-size should probably be set at 100% instead of 110% 4) Resetting a dropdown menu fails on new search. To reproduce : select a library or category in the dropdown and search ; reset the menu to 'Any' and search : results stay the same. Use 'Clear' option and launch a new search using 'Any' : results stay the same as initial search. About Suggestion's manager + Patron's card + Serial routing list + Users to notify when order is received + Owner and users of a fund pages : 5) I regret the pop-up isn't a big one as for guarantor (see point 1) : you have to scroll to see results which is not really a user-friendly thing. I opened a new bug for that. 6) same as point 4) 7) I also have the same search 'issues' described on bug 30063 for special signs (point 3) and search not correctly applied (point 4) About Manager of an acquisition basket : 8) I can't get any results whatever the permissions I set for different users (order_manage, order_manage_all, superlibrarian) Note that I tested as a superlibrairian user but didn't try with simple user permissions.
Created attachment 132450 [details] [review] Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132451 [details] [review] Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132452 [details] [review] Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132453 [details] [review] Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132454 [details] [review] Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132455 [details] [review] Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132456 [details] [review] Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132457 [details] [review] Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132458 [details] [review] Bug 30055: Prevent blink when page is loading Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132459 [details] [review] Bug 30055: Restore patron's preview links Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132460 [details] [review] Bug 30055: Add missing include to format addresses Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132461 [details] [review] Bug 30055: Put extended attributes search back Last patches remove the ability to search on extended attributes. C4::Utils::DataTables::Members::search is searching on all the attributes that are flagged as "searchable", we want to keep this behaviour. I have tried several things and this is the simplest I have found. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132462 [details] [review] Bug 30055: Add missing spec file for baskets Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132463 [details] [review] Bug 30055: Fix when there is no searchable attr type No idea why we need that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132464 [details] [review] Bug 30055: Restore DefaultPatronSearchFields and fix extended attrs search We lost the DefaultPatronSearchFields behaviour, we don't want to search on all data but only DefaultPatronSearchFields Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132465 [details] [review] Bug 30055: Missing search on othernames Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132466 [details] [review] Bug 30055: (follow-up) Increase popup window size With the required addition of fields to the displayed result table, we need to increase the size of the popover window to prevent horizontal scrolling. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132467 [details] [review] Bug 30055: (follow-up) Add missing embeds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132468 [details] [review] Bug 30055: Don't hardcode the default sort column At this point it does not change anything, all calls to members/search.pl has "name" in second column, but that will be helpful in follow-up bugs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132469 [details] [review] Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132470 [details] [review] Bug 30055: clear the column filter if none selected ie. search for "", not "^$" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132471 [details] [review] Bug 30055: (QA follow-up) Minor QA fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132472 [details] [review] Bug 30055: API unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132473 [details] [review] Bug 30055: (follow-up) Adapt spec for bug 30194 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 132539 [details] [review] Bug 30055: Add missing x-koha-embed for /acquisitions/baskets/managers
(In reply to Séverine Queune from comment #85) > About guarantor page (I'm not used to this functionality so I hope I use it > correctly and tested it as expected) : > > 1) I love the big popup ! I opened bug 30404. > 2) I was surprised by the content of the table, as I expected something > unified with the table in '-members-home.pl page, but it's not They should contain the same columns as before. > 3) Address is much bigger than the other informations, font-size should > probably be set at 100% instead of 110% Opened bug 30405. > 4) Resetting a dropdown menu fails on new search. > To reproduce : select a library or category in the dropdown and search ; > reset the menu to 'Any' and search : results stay the same. > Use 'Clear' option and launch a new search using 'Any' : results stay the > same as initial search. Fixed on bug 30093. > About Suggestion's manager + Patron's card + Serial routing list + Users to > notify when order is received + Owner and users of a fund pages : > > 5) I regret the pop-up isn't a big one as for guarantor (see point 1) : you > have to scroll to see results which is not really a user-friendly thing. I > opened a new bug for that. Ha, but I've opened bug 30404 as well :) Which one is yours? > > 6) same as point 4) Should be fixed as well then. > 7) I also have the same search 'issues' described on bug 30063 for special > signs (point 3) and search not correctly applied (point 4) This has been reported by Tomas on bug 30393. > About Manager of an acquisition basket : > > 8) I can't get any results whatever the permissions I set for different > users (order_manage, order_manage_all, superlibrarian) > > Note that I tested as a superlibrairian user but didn't try with simple user > permissions. Good catch, is fixed now!
All the points supposed be fixed by the present bug seems ok for me. But shame on me, I forgot one point in my previous feedback :/ Search 'Starts with' is down. To reproduce : select 'Standard' and 'Starts with' and search for 'ko' or 'koh' : there is supposed be 3 or 4 results but none are displayed. It seems this option searches for 'Is exactly' and not 'Starts with' it works when you search for 'koha'.
Created attachment 132616 [details] [review] Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132617 [details] [review] Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132618 [details] [review] Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132619 [details] [review] Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132620 [details] [review] Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132621 [details] [review] Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132622 [details] [review] Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132623 [details] [review] Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132624 [details] [review] Bug 30055: Prevent blink when page is loading Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132625 [details] [review] Bug 30055: Restore patron's preview links Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132627 [details] [review] Bug 30055: Add missing include to format addresses Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132628 [details] [review] Bug 30055: Put extended attributes search back Last patches remove the ability to search on extended attributes. C4::Utils::DataTables::Members::search is searching on all the attributes that are flagged as "searchable", we want to keep this behaviour. I have tried several things and this is the simplest I have found. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132629 [details] [review] Bug 30055: Add missing spec file for baskets Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132630 [details] [review] Bug 30055: Fix when there is no searchable attr type No idea why we need that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132631 [details] [review] Bug 30055: Restore DefaultPatronSearchFields and fix extended attrs search We lost the DefaultPatronSearchFields behaviour, we don't want to search on all data but only DefaultPatronSearchFields Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132632 [details] [review] Bug 30055: Missing search on othernames Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132633 [details] [review] Bug 30055: (follow-up) Increase popup window size With the required addition of fields to the displayed result table, we need to increase the size of the popover window to prevent horizontal scrolling. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132634 [details] [review] Bug 30055: (follow-up) Add missing embeds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132635 [details] [review] Bug 30055: Don't hardcode the default sort column At this point it does not change anything, all calls to members/search.pl has "name" in second column, but that will be helpful in follow-up bugs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132636 [details] [review] Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132637 [details] [review] Bug 30055: clear the column filter if none selected ie. search for "", not "^$" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132638 [details] [review] Bug 30055: (QA follow-up) Minor QA fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132639 [details] [review] Bug 30055: API unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132640 [details] [review] Bug 30055: (follow-up) Adapt spec for bug 30194 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132641 [details] [review] Bug 30055: Add missing x-koha-embed for /acquisitions/baskets/managers Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
All the bugs linked to this specific ticket are fixed, thanks Jonathan !
Created attachment 132664 [details] [review] Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132665 [details] [review] Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132666 [details] [review] Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr>
Created attachment 132667 [details] [review] Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132668 [details] [review] Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132669 [details] [review] Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132670 [details] [review] Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132671 [details] [review] Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132672 [details] [review] Bug 30055: Prevent blink when page is loading Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132673 [details] [review] Bug 30055: Restore patron's preview links Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132674 [details] [review] Bug 30055: Add missing include to format addresses Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132675 [details] [review] Bug 30055: Put extended attributes search back Last patches remove the ability to search on extended attributes. C4::Utils::DataTables::Members::search is searching on all the attributes that are flagged as "searchable", we want to keep this behaviour. I have tried several things and this is the simplest I have found. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132676 [details] [review] Bug 30055: Add missing spec file for baskets Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132677 [details] [review] Bug 30055: Fix when there is no searchable attr type No idea why we need that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132678 [details] [review] Bug 30055: Restore DefaultPatronSearchFields and fix extended attrs search We lost the DefaultPatronSearchFields behaviour, we don't want to search on all data but only DefaultPatronSearchFields Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132679 [details] [review] Bug 30055: Missing search on othernames Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132680 [details] [review] Bug 30055: (follow-up) Increase popup window size With the required addition of fields to the displayed result table, we need to increase the size of the popover window to prevent horizontal scrolling. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132681 [details] [review] Bug 30055: (follow-up) Add missing embeds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132682 [details] [review] Bug 30055: Don't hardcode the default sort column At this point it does not change anything, all calls to members/search.pl has "name" in second column, but that will be helpful in follow-up bugs. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132683 [details] [review] Bug 30055: Force exact match for dropdown For libraries and categories we need to use an exact match. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132684 [details] [review] Bug 30055: clear the column filter if none selected ie. search for "", not "^$" Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132685 [details] [review] Bug 30055: (QA follow-up) Minor QA fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132686 [details] [review] Bug 30055: API unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132687 [details] [review] Bug 30055: (follow-up) Adapt spec for bug 30194 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132688 [details] [review] Bug 30055: Add missing x-koha-embed for /acquisitions/baskets/managers Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Such a great team effort here testing and qaing.. tests are all now passing, followups have al been forthcoming.. this is great work and brings us to a much better place. QA scripts also happy, PASSING QA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]