Bug 30131 - Centralize "MARC preview" buttons and links
Summary: Centralize "MARC preview" buttons and links
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 29965
Blocks:
  Show dependency treegraph
 
Reported: 2022-02-18 13:59 UTC by Jonathan Druart
Modified: 2023-06-30 18:54 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 30131: Centralize "marc preview" buttons and links (158.05 KB, patch)
2022-02-18 14:00 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-02-18 13:59:35 UTC
The code to display the "MARC preview" modal is copy/pasted all over our templates, we should centralize them to prevent to see more occurrences coming.
Comment 1 Jonathan Druart 2022-02-18 14:00:27 UTC
Created attachment 130843 [details] [review]
Bug 30131: Centralize "marc preview" buttons and links
Comment 2 Jonathan Druart 2022-02-18 14:01:55 UTC
We have:
* simple "MARC|Card" link
* MARC|Card in button groups
* svc/records/preview and catalogue/showmarc.pl

We must centralize everything.

The patch is suggesting to have the code in an include file, but it's not ready (it gets messy with the buttons).
Comment 3 Katrin Fischer 2023-06-17 15:36:51 UTC
This is stuck in NEW with a patch attached?
Comment 4 Heather 2023-06-30 18:54:17 UTC
Would this make the MARC previews in bibs and auts the same?  With 22.11, the authority MARC preview is just a repeat of the labeled display in one screen--it's not a clean, unlabeled MARC preview like the bib MARC preview.  Or is making the aut MARC preview look like the unlabele, bib MARC preview a separate bug (which I could create)?