There are several tables on opac-user.tt that would benefit from being column configurable. ( check-outs, overdues, charges, holds, article requests )
Created attachment 172214 [details] [review] Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University
We had a request from Lyon 2 Uni to make checkouts, overdues, holds and relative's issues configurable but I've just seen this bug so attached my patch to it instead of creating a new bug. Didn't handled the charges and article requests pages though, shall we make a followup to do handle those? Also I guess a couples of system preferences are made obsolete if the table is configurable, like "OPACFinesTab"... shall we make a followup patch to remove this? It probably need a closer look to see if thoses are not used somewhere else.
This is missing Recalls, Article requests, Clubs, Credits, and Charges tables. They should all be configurable.
(In reply to Lucas Gass from comment #3) > This is missing Recalls, Article requests, Clubs, Credits, and Charges > tables. They should all be configurable. Hi Lucas, maybe we can make this small improvement go through and file a linked bug for any other tables which needs to go to table settings? Also those other tables are not in opac-user.tt but in opac-account.tt or even includes templates, touching them all in a single bug would increase the risk of conflicting... :(
Created attachment 172451 [details] [review] Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University
Created attachment 172452 [details] [review] Bug 30221: add the checkout branch to the checkouts table on opac-user.pl
Created attachment 172453 [details] [review] Bug 30221: made opac-readingrecord.pl table configurable
Created attachment 172454 [details] [review] Bug 30221: clean unused code in opac-user.tt
Created attachment 172455 [details] [review] Bug 30221: fix Javascript error
Created attachment 172456 [details] [review] Bug 30221: (QA follow-up) perl-tidyness
(In reply to Arthur Suzuki from comment #4) > (In reply to Lucas Gass from comment #3) > > This is missing Recalls, Article requests, Clubs, Credits, and Charges > > tables. They should all be configurable. > > Hi Lucas, maybe we can make this small improvement go through and file a > linked bug for any other tables which needs to go to table settings? > Also those other tables are not in opac-user.tt but in opac-account.tt or > even includes templates, touching them all in a single bug would increase > the risk of conflicting... :( That's fair. But one more question. I do see the Columns ( gear icon ) button on those OPAC tables. Do we want OPAC users to be able to adjust which columns are visible?
(In reply to Lucas Gass from comment #11) > That's fair. But one more question. I do see the Columns ( gear icon ) > button on those OPAC tables. Do we want OPAC users to be able to adjust > which columns are visible? It is possible to disable which columns are visible and/or configurable by opac users by going to the Admin > Tables settings : https://koha-community.org/manual/latest/en/html/administration.html#table-settings
(In reply to Arthur Suzuki from comment #12) > (In reply to Lucas Gass from comment #11) > > That's fair. But one more question. I do see the Columns ( gear icon ) > > button on those OPAC tables. Do we want OPAC users to be able to adjust > > which columns are visible? > > It is possible to disable which columns are visible and/or configurable by > opac users by going to the Admin > Tables settings : > https://koha-community.org/manual/latest/en/html/administration.html#table- > settings I'm aware of Table settings. Have a look at other OPAC tables that are column configurable. The OPAC user cannot adjust what columns are visible when viewing the table. (Columns ( gear icon )) Should we not be consistent with this behavior with all OPAC tables?
I agree that we should not expose the column visibility feature in the OPAC. I think that introduces more complexity for the user than is necessary.
(In reply to Owen Leonard from comment #14) > I agree that we should not expose the column visibility feature in the OPAC. > I think that introduces more complexity for the user than is necessary. +1
Created attachment 172581 [details] [review] Bug 30221: (QA follow-up) remove columns settings for OPAC users
Created attachment 172610 [details] [review] Bug 30221: make the tables on opac-user.tt configurable Test plan: - apply patch - as an admin go to Administration / Table settings / Opac / Patron details - hide a few columns (duedate, barcode) - make a couple checkouts and/or holds for a patron - login to the opac as this patron - verify the tables on the patron account table is missing the selected columns sponsored-by: Lyon 2 University Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 172611 [details] [review] Bug 30221: add the checkout branch to the checkouts table on opac-user.pl Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 172613 [details] [review] Bug 30221: made opac-readingrecord.pl table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 172615 [details] [review] Bug 30221: clean unused code in opac-user.tt Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 172616 [details] [review] Bug 30221: fix Javascript error Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 172618 [details] [review] Bug 30221: (QA follow-up) perl-tidyness Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 172620 [details] [review] Bug 30221: (QA follow-up) remove columns settings for OPAC users Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
-Signed off, adding a couple notes: 1. I can hide every column. Should there be any that we consider cannot_be_toggled or cannot_be_modified? 2. I can hide the renew column but still seeing buttons for Renew/Renew all. Turning off the OpacRenewalAllowed fixes this.
(In reply to Lucas Gass (lukeg) from comment #24) > -Signed off, adding a couple notes: > > 1. I can hide every column. Should there be any that we consider > cannot_be_toggled or cannot_be_modified? > > 2. I can hide the renew column but still seeing buttons for Renew/Renew all. > Turning off the OpacRenewalAllowed fixes this. So maybe a "cannot_be_modified/cannot_be_toggled" flag on the "renew" column? What other columns did you have in mind which should not be configurable? I can make a small follow-up patch to solve this.
Created attachment 174014 [details] [review] Bug 30221: (QA follow-up) Fix column "renew" cannot be toggled
Created attachment 174015 [details] [review] Bug 30221: (QA follow-up) add checkout branch information to other tables
Created attachment 174016 [details] [review] Bug 30221: (QA follow-up) make holdshistory table configurable
Created attachment 174046 [details] [review] Bug 30221: (QA follow-up) Fix column "renew" cannot be toggled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 174047 [details] [review] Bug 30221: (QA follow-up) add checkout branch information to other tables Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 174048 [details] [review] Bug 30221: (QA follow-up) make holdshistory table configurable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Arthur, the follow-ups look good. I am adding my SO line to the last 3 follow-ups. Thanks!
Thank you Lucas! Very happy to get some more of my patches to Koha :)
KohaTable does not have bKohaColumnsUseNames at the OPAC, this cannot work correctly now. You need bug 26553 and friends. I would recommend to base this patch set on top of it.