Before a recent change Sort 1 and Sort 2 would appear as free text input fields when there were no AV values for Bsort1 and Bsort2. Now it appears as an empty pull down instead. This is a bigger regression and could possibly cause data loss if records are saved where Sort 1 and Sort 2 have been filled.
Created attachment 134778 [details] [review] Bug 30603: Display Sort1 and Sort2 as free text if no AV exists Test plan: Don't define AV for Sort1 and Sort2, edit a patron => Should be editable via an input box Define AVs for Sort1 and Sort2, edit a patron => Should see the dropdown
*** Bug 30602 has been marked as a duplicate of this bug. ***
Created attachment 134779 [details] [review] Bug 30603: Display Sort1 and Sort2 as free text if no AV exists Test plan: Don't define AV for Sort1 and Sort2, edit a patron => Should be editable via an input box Define AVs for Sort1 and Sort2, edit a patron => Should see the dropdown
Created attachment 134780 [details] [review] Bug 30603: Fix other occurrences
Created attachment 134798 [details] [review] Bug 30603: Display Sort1 and Sort2 as free text if no AV exists Test plan: Don't define AV for Sort1 and Sort2, edit a patron => Should be editable via an input box Define AVs for Sort1 and Sort2, edit a patron => Should see the dropdown Signed-off-by: David Nind <david@davidnind.com>
Created attachment 134799 [details] [review] Bug 30603: Fix other occurrences Signed-off-by: David Nind <david@davidnind.com>
Created attachment 134812 [details] [review] Bug 30603: Display Sort1 and Sort2 as free text if no AV exists Test plan: Don't define AV for Sort1 and Sort2, edit a patron => Should be editable via an input box Define AVs for Sort1 and Sort2, edit a patron => Should see the dropdown Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 134813 [details] [review] Bug 30603: Fix other occurrences Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]