Bug 22279 - Unify patron name display
Summary: Unify patron name display
Status: RESOLVED DUPLICATE of bug 30617
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 7183 (view as bug list)
Depends on:
Blocks: 7680
  Show dependency treegraph
 
Reported: 2019-02-06 07:25 UTC by paxed
Modified: 2022-04-27 06:50 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2019-02-06 07:25:14 UTC
The way patron's name is displayed should be unified into a single place.
There's template code in patron-title.inc for it, but it's not used in enough places. Using that would make the patron name display consistent, and if change is needed (eg. for GDPR), it would be easy to change.

For example:

koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:                    <li><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber | uri %]&amp;findborrower=[% holdfor_cardnumber | uri %]">Place hold for [% holdfor_firstname | html %] [% holdfor_surname | html %] ([% holdfor_cardnumber | html %])</a></li>


koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc:                        .append( "<a>" + item.surname + ", " + item.firstname + " (" + item.cardnumber + ") <small>" + item.dateofbirth + " " + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "</small></a>" )


koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc:                    <td><a href="[% data_url | url %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td>


koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt:    <title>Summary for [% patron.firstname | html %] [% patron.surname | html %] ([% patron.cardnumber | html %])</title>


koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt:    <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber | uri %]">Pay fines for [% patron.firstname | html %] [% patron.surname | html %]</a> &rsaquo;


and many, many more.
Comment 1 Katrin Fischer 2019-03-14 07:11:38 UTC
*** Bug 7183 has been marked as a duplicate of this bug. ***
Comment 2 Martin Renvoize 2022-04-27 06:50:24 UTC
Oop, I didn't spot this before I created an OMNIBUS bug around this issue.

*** This bug has been marked as a duplicate of bug 30617 ***