In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc there is : <select class="advsearch" name="idx" id="idx"> But this include is used several times, so there are several id="idx". We should remove this id.
Arf this is now used for id=refiner_idx from Bug 27546
Got to love these little gotchas...
This is bad right ?
(In reply to Fridolin Somers from comment #3) > This is bad right ? It's not good.
Some other errors I'll submit a fix for: More duplicate id problems, tab WRAPPER errors, invalid "href" attributes on <button>s, mismatched labels and form field ids.
Created attachment 170923 [details] [review] Bug 30699: Fix various HTML validity errors in staff interface templates This patch fixes several HTML validity issues in various staff interface templates. Most of these changes won't be visible in the interface. - Advanced search: - Remove stray </a> tags - Fix duplicate IDs by adding loop.index to repeated dropdown menus - Circulation - Fix mismatched label and form field id in checkouts table footer - Fix mismatched label and form field id claim returned modal - Remove invalid href attribute from button in claim returned modal - Wrap relatives' checkouts tab in conditional so that panel doesn't appear when tab has been hidden - Fix duplicate id attributes in patron messages-related markup - Remove redundant class attribute from patron messages-related markup - Acquisitions -> Vendor -> Basket -> Add to basket -> From staged file - Remove invalid "size" attribute from hidden form fields - Circulation -> Holds awaiting pickup - Fix mismatched label and form field id - Patron -> Accounting -> Pay fine -> Submit cash amount higher than the charge - Remove invalid href attribute from button in confirmation modal - Fix errors in tab markup WRAPPERs in html_helpers.inc to prevent mismatched aria-labelledby attributes - Footer language selector: - Fix markup to correct errors in aria-controls - Remove invalid href attribute from cookie consent modal Sponsored-by: Athens County Public Libraries
Created attachment 172679 [details] [review] Bug 30699: Fix various HTML validity errors in staff interface templates This patch fixes several HTML validity issues in various staff interface templates. Most of these changes won't be visible in the interface. - Advanced search: - Remove stray </a> tags - Fix duplicate IDs by adding loop.index to repeated dropdown menus - Circulation - Fix mismatched label and form field id in checkouts table footer - Fix mismatched label and form field id claim returned modal - Remove invalid href attribute from button in claim returned modal - Wrap relatives' checkouts tab in conditional so that panel doesn't appear when tab has been hidden - Fix duplicate id attributes in patron messages-related markup - Remove redundant class attribute from patron messages-related markup - Acquisitions -> Vendor -> Basket -> Add to basket -> From staged file - Remove invalid "size" attribute from hidden form fields - Circulation -> Holds awaiting pickup - Fix mismatched label and form field id - Patron -> Accounting -> Pay fine -> Submit cash amount higher than the charge - Remove invalid href attribute from button in confirmation modal - Fix errors in tab markup WRAPPERs in html_helpers.inc to prevent mismatched aria-labelledby attributes - Footer language selector: - Fix markup to correct errors in aria-controls - Remove invalid href attribute from cookie consent modal Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>