In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc some calls do not set 'index' var generating idx="idx_". Set 0 has default value.
Created attachment 182896 [details] [review] Bug 40042: Add default value 0 for index var in search_indexes.inc In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc some calls do not set 'index' var generating idx="idx_". Set 0 has default value. Test plan : 1) Enable system preference 'IntranetCatalogSearchPulldown' 2) Go to catalogue advanced search 3) Look HTML source and check you see: <select class="advsearch" name="idx" id="idx_0"> <select class="advsearch" name="idx" id="idx_1"> <select class="advsearch" name="idx" id="idx_2"> 4) In page page toolbar, click 'Search catalog' 5) Click on 'More options' icon 6) Look HTML source of this part and check you see: <select class="advsearch" name="idx" id="idx_0"> Without patch you see: <select class="advsearch" name="idx" id="idx_">
Created attachment 182938 [details] [review] Bug 40042: Add default value 0 for index var in search_indexes.inc In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc some calls do not set 'index' var generating idx="idx_". Set 0 has default value. Test plan : 1) Enable system preference 'IntranetCatalogSearchPulldown' 2) Go to catalogue advanced search 3) Look HTML source and check you see: <select class="advsearch" name="idx" id="idx_0"> <select class="advsearch" name="idx" id="idx_1"> <select class="advsearch" name="idx" id="idx_2"> 4) In page page toolbar, click 'Search catalog' 5) Click on 'More options' icon 6) Look HTML source of this part and check you see: <select class="advsearch" name="idx" id="idx_0"> Without patch you see: <select class="advsearch" name="idx" id="idx_"> Signed-off-by: Magnus Enger <magnus@libriotech.no>
Created attachment 183041 [details] [review] Bug 40042: Add default value 0 for index var in search_indexes.inc In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc some calls do not set 'index' var generating idx="idx_". Set 0 has default value. Test plan : 1) Enable system preference 'IntranetCatalogSearchPulldown' 2) Go to catalogue advanced search 3) Look HTML source and check you see: <select class="advsearch" name="idx" id="idx_0"> <select class="advsearch" name="idx" id="idx_1"> <select class="advsearch" name="idx" id="idx_2"> 4) In page page toolbar, click 'Search catalog' 5) Click on 'More options' icon 6) Look HTML source of this part and check you see: <select class="advsearch" name="idx" id="idx_0"> Without patch you see: <select class="advsearch" name="idx" id="idx_"> Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x for 25.05.03