Bug 30707 - Move container's closing div tag into template from intranet-bottom.inc
Summary: Move container's closing div tag into template from intranet-bottom.inc
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-06 08:50 UTC by Jonathan Druart
Modified: 2022-06-03 16:17 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-05-06 08:50:07 UTC
There is a closing div in intranet-bottom.inc, the related opening div is usually added by the different template.
Since it's at the top of the include file it does not make much sense to have it here, better to not add confusion to the templates and let them close it from there.
Comment 1 Jonathan Druart 2022-05-06 11:43:03 UTC
From IRC

oleonard> Joubu: Re: Bug 30707, I know it was my decision ages ago but I don't remember the reason. It may not have even been a good one at the time!