There are several occurrences of incorrect HTML structures in our templates. Mostly caused by opening tag without closing tag (or the reverse). This is not about a validator check.
Patches ready for testing, see the remote branch: https://gitlab.com/joubu/Koha/-/commits/bug_38713 They fix incorrect structures in our templates, like: * Fix wrong or missing closing tag * Remove extra closing tag * Fix </br> => <br/> * Add missing quotes around HTML attributes * Replace <p> with <p></p> when needed * Replace <p> with <div> when it contains `form` or other tags not allowed within `p`. Test plan: Most of the time a code review is enough to confirm the changes. For some more complicated use a test of the UI could be needed.
One blocker to signing off: https://gitlab.com/joubu/Koha/-/commit/4ef2233f4b9787ee533ce3ff84348575ba0cd591 leaves the <form> for the not-multi-hold case unclosed Two minor quibbles: In https://gitlab.com/joubu/Koha/-/commit/51746c7dda9d832c0efd91e66e59aac65e4e76ed the stray </em> should just be removed, .breadcrumb-item is font-style: italic so it's not needed In https://gitlab.com/joubu/Koha/-/commit/02e97eba3b88fb96bb94b3131722a94fa3fbed57 I think the intention of the original was to wrap that stuff in a block, not to put space above and below - while it would look better to me with some space below (and not above) I think the fix for structure is just to wrap it in a <div> rather than a <p>
(In reply to Phil Ringnalda from comment #2) Thanks a lot, Phil! > One blocker to signing off: > > https://gitlab.com/joubu/Koha/-/commit/ > 4ef2233f4b9787ee533ce3ff84348575ba0cd591 leaves the <form> for the > not-multi-hold case unclosed Fixed in "Bug 38713: (follow-up) reserve/request.tt" (will squash later) > Two minor quibbles: > > In > https://gitlab.com/joubu/Koha/-/commit/ > 51746c7dda9d832c0efd91e66e59aac65e4e76ed the stray </em> should just be > removed, .breadcrumb-item is font-style: italic so it's not needed Ok but not something for here. > In > https://gitlab.com/joubu/Koha/-/commit/ > 02e97eba3b88fb96bb94b3131722a94fa3fbed57 I think the intention of the > original was to wrap that stuff in a block, not to put space above and below > - while it would look better to me with some space below (and not above) I > think the fix for structure is just to wrap it in a <div> rather than a <p> It was the easiest, and it looks identically before and after. IIRC (didn't retest now) with a div the display was not the same (could be achieve with styling ofc). Happy to adjust if you have a better fix.
Branch rebased against main.
OK, I'm happy to sign off.
(In reply to Phil Ringnalda from comment #5) > OK, I'm happy to sign off. I've added your signed-off-by line on the 86 commits: 835944b856e Bug 38713: (follow-up) reserve/request.tt f1f38d8fee1 Bug 38713: opac-user.tt 108ede74b35 Bug 38713: opac-detail.tt 23fa962eab3 Bug 38713: opac-account-pay-error.tt 84a1a84d634 Bug 38713: result-batch-controls.inc [opac] 2af6ae9cc9a Bug 38713: modals/checkout.inc [opac] f255e51aa62 Bug 38713: masthead-sci.inc [opac] 67e4b551d5c Bug 38713: Add mising </ul> to opac-recall.tt 624f9d51152 Bug 38713: Remove stray closing tag from opac-addbybiblionumber.tt 97abfc22af8 Bug 38713: Fix opac-suggestions.tt dd6f6029061 Bug 38713: Fix opac-reset-password.tt 4e174ed23c5 Bug 38713: Fix mismatched closing tag in opac-discharge.tt 51f6c304953 Bug 38713: Fix mismatched closing tag in opac-curbside-pickups.tt 1e117d4f421 Bug 38713: tools/modborrowers.tt 7ef0ca2e9dc Bug 38713: tools/additional-contents.tt 8dfc9245703 Bug 38713: tags/list.tt 93922dd966e Bug 38713: serials/subscription-add.tt 15fc722e498 Bug 38713: serials/showpredictionpattern.tt 1ce5db69105 Bug 38713: serials/serials-edit.tt d85b1edf21a Bug 38713: serials/serials-collection.tt e10e38cd19f Bug 38713: serials/routing.tt 48e2bf6a525 Bug 38713: serials/routing-preview.tt 64c98a983cc Bug 38713: rotating_collections/transferCollection.tt ab5be54e5cb Bug 38713: rotating_collections/addItems.tt 87ec2f1641f Bug 38713: reserve/request.tt 60e7e3fd4af Bug 38713: reports/serials_stats.tt 4ef58cc8339 Bug 38713: reports/reports-home.tt 5956d7b6cc1 Bug 38713: reports/guided_reports_start.tt fa88eae9264 Bug 38713: reports/dictionary.tt da551eebde3 Bug 38713: plugins/plugins-home.tt 513f8688589 Bug 38713: patron_lists/patron-lists-tab.tt 41a6d40cbc3 Bug 38713: patron_lists/list.tt 0c928504153 Bug 38713: catalogue/results.tt 3131155c275 Bug 38713: members/merge-patrons.tt ca749ec6218 Bug 38713: members/memberentrygen.tt 3637ab833a0 Bug 38713: members/boraccount.tt d1f9833f3d2 Bug 38713: labels/label-manage.tt b015c816f62 Bug 38713: labels/label-edit-batch.tt 98a032be48f Bug 38713: installer/step3.tt 92464896ad3 Bug 38713: ill/ill-requests.tt 7959b027f72 Bug 38713: clubs/patron-clubs-tab.tt b1cfe51af44 Bug 38713: member-display-alt-address-style.inc 5c3c639453b Bug 38713: item-status.inc d49b618d45d Bug 38713: ill-toolbar.inc da6cc8613ec Bug 38713: html_helpers/tables/items/catalogue_detail.inc c04a1dc49e9 Bug 38713: budgets-admin-toolbar.inc 91e31abe800 Bug 38713: circ/returns.tt c45c70f4b6a Bug 38713: circ/printslip.tt 310f1ae47db Bug 38713: circ/circulation.tt d73fc9bffe9 Bug 38713: circ/article-requests.tt e4b78a67d07 Bug 38713: cataloguing/z3950_auth_search.tt 5013cd59d1c Bug 38713: cataloguing/editor.tt 71102ce128f Bug 38713: catalogue/stockrotation.tt 6fccf3ac57d Bug 38713: catalogue/labeledMARCdetail.tt 05b67f9767f Bug 38713: catalogue/MARCdetail.tt 0226be33a63 Bug 38713: catalogue/detail.tt 2357ecfa372 Bug 38713: catalogue/detail.tt 5ac1ae9644a Bug 38713: admin/restrictions.tt fed20a98437 Bug 38713: admin/patron-attr-types.tt d67afd91a53 Bug 38713: admin/oai_servers.tt eee76ca6bd7 Bug 38713: admin/koha2marclinks.tt d9916436617 Bug 38713: admin/itemtypes.tt d730a975c63 Bug 38713: admin/items_search_fields.tt 979103208c2 Bug 38713: admin/ill_batch_statuses.tt 83154395b3e Bug 38713: admin/currency.tt 6368fce1c58 Bug 38713: admin/curbside_pickup.tt 42ac7f643cb Bug 38713: admin/checkmarc.tt d2b195e4501 Bug 38713: admin/categories.tt bea78375f4b Bug 38713: admin/branches.tt 8d92b172279 Bug 38713: admin/auth_subfields_structure.tt d11afa403e2 Bug 38713: admin/authorised_values.tt d694e68de1c Bug 38713: admin/aqplan.tt 5df85e29ecd Bug 38713: admin/aqbudgetperiods.tt 63e7942b118 Bug 38713: admin/admin-home.tt 976bc045508 Bug 38713: admin/additional-fields.tt 5f4d506f1aa Bug 38713: acqui/supplier 0b46b678064 Bug 38713: acqui/supplier.tt 0a1eecc7fdb Bug 38713: acqui/neworderempty.tt 1962f82a05c Bug 38713: acqui/lateorders.tt b7d4f08d682 Bug 38713: acqui/invoices.tt 1835d888014 Bug 38713: acqui/edimsg.tt a421d80029e Bug 38713: acqui/duplicate_orders.tt 22bec0c0b1d Bug 38713: acqui/vendor_issues.tt 8e866032611 Bug 38713: auth.tt 64e4d70e800 Bug 38713: about.tt c4951567f74 Bug 38713: acqui-home.tt Please adjust the status of the bug report. Thanks! :)
I have reviewed each of the changed files: We should certainly fix this here: reserve/request.tt: <i class="fa fa-exclamation-triangle fa-lg" style="color:gold" title="Requires override of hold policy" /> <i> tags should not be self-closing. Things I am noting that we can fix here, or open separate bugs for: modules/opac-reset-password.tt: I know the others in the SWITCH/CASE are <span> but <span></span><br /> is better as just <div></div> <span>Please log-in to account to update your password.</span><br /> should be: <div>Please log-in to account to update your password.</div> serials/subscription-add.tt <center> tag is unsupported in HTML, should be CSS instead. catalogue/results.tt <br/>OR<br/> is weird. Should be <p>OR</p> and it’s parent probably needs to be a <div> includes/member-display-alt-address-style.inc Best to avoid <br/> for splitting up the content. Wrapping in <p> tags would be better, IMO.
(In reply to Lucas Gass (lukeg) from comment #7) > I have reviewed each of the changed files: > > > We should certainly fix this here: > > reserve/request.tt: > <i class="fa fa-exclamation-triangle fa-lg" style="color:gold" > title="Requires override of hold policy" /> > <i> tags should not be self-closing. Indeed, fixed in "Bug 38713: i tags should not be self-closing" It's the only occurrence I found. Command used: perl -0777 -ne 'print "Self-closing <i> tag found in $ARGV: $1\n" while /(<i(?:\s+[^>]*)?\/>)/ig' **/*.tt **/*.inc > Things I am noting that we can fix here, or open separate bugs for: > > modules/opac-reset-password.tt: > I know the others in the SWITCH/CASE are <span> but <span></span><br /> is > better as just <div></div> > <span>Please log-in to account to update your password.</span><br /> > > should be: <div>Please log-in to account to update your password.</div> Yes, that's for somewhere else as the change made here are only replacing </br> to the correct <br/> > serials/subscription-add.tt > <center> tag is unsupported in HTML, should be CSS instead. Done in "Bug 38713: Replace <center> by its css equivalent" There is another occurrence that is going to be removed on bug 38952. > catalogue/results.tt > <br/>OR<br/> is weird. Should be <p>OR</p> and it’s parent probably needs to > be a <div> I agree, but there is a tiny UI change when switching to p. Better to deal with this separately that making a change that will be hidden in this big set. > includes/member-display-alt-address-style.inc > Best to avoid <br/> for splitting up the content. Wrapping in <p> tags would > be better, IMO. Same that previously, br is the current tag, I prefer to deal with that separately.
Reviewing this after the follow-ups. I would pass QA here now.
Created attachment 176973 [details] [review] Bug 38713: acqui-home.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176974 [details] [review] Bug 38713: about.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176975 [details] [review] Bug 38713: auth.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176976 [details] [review] Bug 38713: acqui/vendor_issues.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176977 [details] [review] Bug 38713: acqui/duplicate_orders.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176978 [details] [review] Bug 38713: acqui/edimsg.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176979 [details] [review] Bug 38713: acqui/invoices.tt ul are not allowed in p Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176980 [details] [review] Bug 38713: acqui/lateorders.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176981 [details] [review] Bug 38713: acqui/neworderempty.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176982 [details] [review] Bug 38713: acqui/supplier.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176983 [details] [review] Bug 38713: acqui/supplier Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176984 [details] [review] Bug 38713: admin/additional-fields.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176985 [details] [review] Bug 38713: admin/admin-home.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176986 [details] [review] Bug 38713: admin/aqbudgetperiods.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176987 [details] [review] Bug 38713: admin/aqplan.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176988 [details] [review] Bug 38713: admin/authorised_values.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176989 [details] [review] Bug 38713: admin/auth_subfields_structure.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176990 [details] [review] Bug 38713: admin/branches.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176991 [details] [review] Bug 38713: admin/categories.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176992 [details] [review] Bug 38713: admin/checkmarc.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176993 [details] [review] Bug 38713: admin/curbside_pickup.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176994 [details] [review] Bug 38713: admin/currency.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176995 [details] [review] Bug 38713: admin/ill_batch_statuses.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176996 [details] [review] Bug 38713: admin/items_search_fields.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176997 [details] [review] Bug 38713: admin/itemtypes.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176998 [details] [review] Bug 38713: admin/koha2marclinks.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 176999 [details] [review] Bug 38713: admin/oai_servers.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177000 [details] [review] Bug 38713: admin/patron-attr-types.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177001 [details] [review] Bug 38713: admin/restrictions.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177002 [details] [review] Bug 38713: catalogue/detail.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177003 [details] [review] Bug 38713: catalogue/detail.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177004 [details] [review] Bug 38713: catalogue/MARCdetail.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177005 [details] [review] Bug 38713: catalogue/labeledMARCdetail.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177006 [details] [review] Bug 38713: catalogue/stockrotation.tt form in p is invalid Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177007 [details] [review] Bug 38713: cataloguing/editor.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177008 [details] [review] Bug 38713: cataloguing/z3950_auth_search.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177009 [details] [review] Bug 38713: circ/article-requests.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177010 [details] [review] Bug 38713: circ/circulation.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177011 [details] [review] Bug 38713: circ/printslip.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177012 [details] [review] Bug 38713: circ/returns.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177013 [details] [review] Bug 38713: budgets-admin-toolbar.inc Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177014 [details] [review] Bug 38713: html_helpers/tables/items/catalogue_detail.inc Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177015 [details] [review] Bug 38713: ill-toolbar.inc Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177016 [details] [review] Bug 38713: item-status.inc Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177017 [details] [review] Bug 38713: member-display-alt-address-style.inc Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177018 [details] [review] Bug 38713: clubs/patron-clubs-tab.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177019 [details] [review] Bug 38713: ill/ill-requests.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177020 [details] [review] Bug 38713: installer/step3.tt p cannot contain form Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177021 [details] [review] Bug 38713: labels/label-edit-batch.tt The first row is the headers for thead, then the other rows are the tbody. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177022 [details] [review] Bug 38713: labels/label-manage.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177023 [details] [review] Bug 38713: members/boraccount.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177024 [details] [review] Bug 38713: members/memberentrygen.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177025 [details] [review] Bug 38713: members/merge-patrons.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177026 [details] [review] Bug 38713: catalogue/results.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177027 [details] [review] Bug 38713: patron_lists/list.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177028 [details] [review] Bug 38713: patron_lists/patron-lists-tab.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177029 [details] [review] Bug 38713: plugins/plugins-home.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177030 [details] [review] Bug 38713: reports/dictionary.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177031 [details] [review] Bug 38713: reports/guided_reports_start.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177032 [details] [review] Bug 38713: reports/reports-home.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177033 [details] [review] Bug 38713: reports/serials_stats.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177034 [details] [review] Bug 38713: reserve/request.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177035 [details] [review] Bug 38713: rotating_collections/addItems.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177036 [details] [review] Bug 38713: rotating_collections/transferCollection.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177037 [details] [review] Bug 38713: serials/routing-preview.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177038 [details] [review] Bug 38713: serials/routing.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177039 [details] [review] Bug 38713: serials/serials-collection.tt p cannot contain div Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177040 [details] [review] Bug 38713: serials/serials-edit.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177041 [details] [review] Bug 38713: serials/showpredictionpattern.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177042 [details] [review] Bug 38713: serials/subscription-add.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177043 [details] [review] Bug 38713: tags/list.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177044 [details] [review] Bug 38713: tools/additional-contents.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177045 [details] [review] Bug 38713: tools/modborrowers.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177046 [details] [review] Bug 38713: Fix mismatched closing tag in opac-curbside-pickups.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177047 [details] [review] Bug 38713: Fix mismatched closing tag in opac-discharge.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177048 [details] [review] Bug 38713: Fix opac-reset-password.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177049 [details] [review] Bug 38713: Fix opac-suggestions.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177050 [details] [review] Bug 38713: Remove stray closing tag from opac-addbybiblionumber.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177051 [details] [review] Bug 38713: Add mising </ul> to opac-recall.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177052 [details] [review] Bug 38713: masthead-sci.inc [opac] Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177053 [details] [review] Bug 38713: modals/checkout.inc [opac] Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177054 [details] [review] Bug 38713: result-batch-controls.inc [opac] Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177055 [details] [review] Bug 38713: opac-account-pay-error.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177056 [details] [review] Bug 38713: opac-detail.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177057 [details] [review] Bug 38713: opac-user.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177058 [details] [review] Bug 38713: (follow-up) reserve/request.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177059 [details] [review] Bug 38713: i tags should not be self-closing Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 177060 [details] [review] Bug 38713: Replace <center> by its css equivalent Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Can we get a speedy check on bug 30707 please? It's the dependency here.
Let's coordinate this early next week!
Pushed for 25.05! Well done everyone, thank you!
Wow. So many commits...
Skip for 24.11.x LTS