Bug 38713 - Incorrect HTML structures
Summary: Incorrect HTML structures
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 30707
Blocks: 38664 38714
  Show dependency treegraph
 
Reported: 2024-12-16 13:08 UTC by Jonathan Druart
Modified: 2025-01-30 17:07 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38713: acqui-home.tt (1.50 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: about.tt (1.79 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: auth.tt (949 bytes, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: acqui/vendor_issues.tt (982 bytes, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: acqui/duplicate_orders.tt (1.32 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: acqui/edimsg.tt (1.18 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: acqui/invoices.tt (1.62 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: acqui/lateorders.tt (1.46 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: acqui/neworderempty.tt (3.41 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: acqui/supplier.tt (1.94 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: acqui/supplier (1.38 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/additional-fields.tt (1.29 KB, patch)
2025-01-23 14:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/admin-home.tt (2.94 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/aqbudgetperiods.tt (1.62 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/aqplan.tt (1.41 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/authorised_values.tt (2.58 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/auth_subfields_structure.tt (1.13 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/branches.tt (2.35 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/categories.tt (1.47 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/checkmarc.tt (1.08 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/curbside_pickup.tt (1.28 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/currency.tt (989 bytes, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/ill_batch_statuses.tt (1.27 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/items_search_fields.tt (1.59 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/itemtypes.tt (1.17 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/koha2marclinks.tt (884 bytes, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/oai_servers.tt (1.05 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/patron-attr-types.tt (1.54 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: admin/restrictions.tt (1.84 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: catalogue/detail.tt (2.38 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: catalogue/detail.tt (1.57 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: catalogue/MARCdetail.tt (2.01 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: catalogue/labeledMARCdetail.tt (1.95 KB, patch)
2025-01-23 14:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: catalogue/stockrotation.tt (1.69 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: cataloguing/editor.tt (1.82 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: cataloguing/z3950_auth_search.tt (2.31 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: circ/article-requests.tt (4.38 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: circ/circulation.tt (3.01 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: circ/printslip.tt (1.10 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: circ/returns.tt (1.91 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: budgets-admin-toolbar.inc (1.57 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: html_helpers/tables/items/catalogue_detail.inc (2.59 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: ill-toolbar.inc (1.23 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: item-status.inc (1.01 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: member-display-alt-address-style.inc (1.89 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: clubs/patron-clubs-tab.tt (918 bytes, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: ill/ill-requests.tt (1.61 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: installer/step3.tt (2.82 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: labels/label-edit-batch.tt (11.48 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: labels/label-manage.tt (1.18 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: members/boraccount.tt (1.26 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: members/memberentrygen.tt (1.82 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: members/merge-patrons.tt (1.56 KB, patch)
2025-01-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: catalogue/results.tt (2.60 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: patron_lists/list.tt (1.28 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: patron_lists/patron-lists-tab.tt (1.08 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: plugins/plugins-home.tt (1.41 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: reports/dictionary.tt (1.07 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: reports/guided_reports_start.tt (7.07 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: reports/reports-home.tt (1.33 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: reports/serials_stats.tt (897 bytes, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: reserve/request.tt (4.26 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: rotating_collections/addItems.tt (1.50 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: rotating_collections/transferCollection.tt (1.53 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: serials/routing-preview.tt (1.04 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: serials/routing.tt (2.61 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: serials/serials-collection.tt (2.09 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: serials/serials-edit.tt (2.94 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: serials/showpredictionpattern.tt (1.11 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: serials/subscription-add.tt (1.69 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: tags/list.tt (1016 bytes, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: tools/additional-contents.tt (2.39 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: tools/modborrowers.tt (1.60 KB, patch)
2025-01-23 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: Fix mismatched closing tag in opac-curbside-pickups.tt (1.33 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: Fix mismatched closing tag in opac-discharge.tt (1.36 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: Fix opac-reset-password.tt (1.89 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: Fix opac-suggestions.tt (4.27 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: Remove stray closing tag from opac-addbybiblionumber.tt (1.61 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: Add mising </ul> to opac-recall.tt (1.46 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: masthead-sci.inc [opac] (1.40 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: modals/checkout.inc [opac] (1.33 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: result-batch-controls.inc [opac] (1.22 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: opac-account-pay-error.tt (1.57 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: opac-detail.tt (1.50 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: opac-user.tt (1.23 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: (follow-up) reserve/request.tt (1.10 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: i tags should not be self-closing (1.80 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38713: Replace <center> by its css equivalent (2.03 KB, patch)
2025-01-23 14:54 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-12-16 13:08:12 UTC
There are several occurrences of incorrect HTML structures in our templates.

Mostly caused by opening tag without closing tag (or the reverse).

This is not about a validator check.
Comment 1 Jonathan Druart 2025-01-13 14:12:50 UTC
Patches ready for testing, see the remote branch: https://gitlab.com/joubu/Koha/-/commits/bug_38713

They fix incorrect structures in our templates, like:
* Fix wrong or missing closing tag
* Remove extra closing tag
* Fix </br> => <br/>
* Add missing quotes around HTML attributes
* Replace <p> with <p></p> when needed
* Replace <p> with <div> when it contains `form` or other tags not allowed within `p`.

Test plan:
Most of the time a code review is enough to confirm the changes.
For some more complicated use a test of the UI could be needed.
Comment 2 Phil Ringnalda 2025-01-17 01:56:22 UTC
One blocker to signing off:

https://gitlab.com/joubu/Koha/-/commit/4ef2233f4b9787ee533ce3ff84348575ba0cd591 leaves the <form> for the not-multi-hold case unclosed

Two minor quibbles:

In https://gitlab.com/joubu/Koha/-/commit/51746c7dda9d832c0efd91e66e59aac65e4e76ed the stray </em> should just be removed, .breadcrumb-item is font-style: italic so it's not needed

In https://gitlab.com/joubu/Koha/-/commit/02e97eba3b88fb96bb94b3131722a94fa3fbed57 I think the intention of the original was to wrap that stuff in a block, not to put space above and below - while it would look better to me with some space below (and not above) I think the fix for structure is just to wrap it in a <div> rather than a <p>
Comment 3 Jonathan Druart 2025-01-17 07:35:07 UTC
(In reply to Phil Ringnalda from comment #2)

Thanks a lot, Phil!

> One blocker to signing off:
> 
> https://gitlab.com/joubu/Koha/-/commit/
> 4ef2233f4b9787ee533ce3ff84348575ba0cd591 leaves the <form> for the
> not-multi-hold case unclosed

Fixed in "Bug 38713: (follow-up) reserve/request.tt" (will squash later)

> Two minor quibbles:
> 
> In
> https://gitlab.com/joubu/Koha/-/commit/
> 51746c7dda9d832c0efd91e66e59aac65e4e76ed the stray </em> should just be
> removed, .breadcrumb-item is font-style: italic so it's not needed

Ok but not something for here.

> In
> https://gitlab.com/joubu/Koha/-/commit/
> 02e97eba3b88fb96bb94b3131722a94fa3fbed57 I think the intention of the
> original was to wrap that stuff in a block, not to put space above and below
> - while it would look better to me with some space below (and not above) I
> think the fix for structure is just to wrap it in a <div> rather than a <p>

It was the easiest, and it looks identically before and after. IIRC (didn't retest now) with a div the display was not the same (could be achieve with styling ofc).
Happy to adjust if you have a better fix.
Comment 4 Jonathan Druart 2025-01-17 07:37:41 UTC
Branch rebased against main.
Comment 5 Phil Ringnalda 2025-01-17 19:18:25 UTC
OK, I'm happy to sign off.
Comment 6 Jonathan Druart 2025-01-20 08:39:11 UTC
(In reply to Phil Ringnalda from comment #5)
> OK, I'm happy to sign off.

I've added your signed-off-by line on the 86 commits:

835944b856e Bug 38713: (follow-up) reserve/request.tt
f1f38d8fee1 Bug 38713: opac-user.tt
108ede74b35 Bug 38713: opac-detail.tt
23fa962eab3 Bug 38713: opac-account-pay-error.tt
84a1a84d634 Bug 38713: result-batch-controls.inc [opac]
2af6ae9cc9a Bug 38713: modals/checkout.inc [opac]
f255e51aa62 Bug 38713: masthead-sci.inc [opac]
67e4b551d5c Bug 38713: Add mising </ul> to opac-recall.tt
624f9d51152 Bug 38713: Remove stray closing tag from opac-addbybiblionumber.tt
97abfc22af8 Bug 38713: Fix opac-suggestions.tt
dd6f6029061 Bug 38713: Fix opac-reset-password.tt
4e174ed23c5 Bug 38713: Fix mismatched closing tag in opac-discharge.tt
51f6c304953 Bug 38713: Fix mismatched closing tag in opac-curbside-pickups.tt
1e117d4f421 Bug 38713: tools/modborrowers.tt
7ef0ca2e9dc Bug 38713: tools/additional-contents.tt
8dfc9245703 Bug 38713: tags/list.tt
93922dd966e Bug 38713: serials/subscription-add.tt
15fc722e498 Bug 38713: serials/showpredictionpattern.tt
1ce5db69105 Bug 38713: serials/serials-edit.tt
d85b1edf21a Bug 38713: serials/serials-collection.tt
e10e38cd19f Bug 38713: serials/routing.tt
48e2bf6a525 Bug 38713: serials/routing-preview.tt
64c98a983cc Bug 38713: rotating_collections/transferCollection.tt
ab5be54e5cb Bug 38713: rotating_collections/addItems.tt
87ec2f1641f Bug 38713: reserve/request.tt
60e7e3fd4af Bug 38713: reports/serials_stats.tt
4ef58cc8339 Bug 38713: reports/reports-home.tt
5956d7b6cc1 Bug 38713: reports/guided_reports_start.tt
fa88eae9264 Bug 38713: reports/dictionary.tt
da551eebde3 Bug 38713: plugins/plugins-home.tt
513f8688589 Bug 38713: patron_lists/patron-lists-tab.tt
41a6d40cbc3 Bug 38713: patron_lists/list.tt
0c928504153 Bug 38713: catalogue/results.tt
3131155c275 Bug 38713: members/merge-patrons.tt
ca749ec6218 Bug 38713: members/memberentrygen.tt
3637ab833a0 Bug 38713: members/boraccount.tt
d1f9833f3d2 Bug 38713: labels/label-manage.tt
b015c816f62 Bug 38713: labels/label-edit-batch.tt
98a032be48f Bug 38713: installer/step3.tt
92464896ad3 Bug 38713: ill/ill-requests.tt
7959b027f72 Bug 38713: clubs/patron-clubs-tab.tt
b1cfe51af44 Bug 38713: member-display-alt-address-style.inc
5c3c639453b Bug 38713: item-status.inc
d49b618d45d Bug 38713: ill-toolbar.inc
da6cc8613ec Bug 38713: html_helpers/tables/items/catalogue_detail.inc
c04a1dc49e9 Bug 38713: budgets-admin-toolbar.inc
91e31abe800 Bug 38713: circ/returns.tt
c45c70f4b6a Bug 38713: circ/printslip.tt
310f1ae47db Bug 38713: circ/circulation.tt
d73fc9bffe9 Bug 38713: circ/article-requests.tt
e4b78a67d07 Bug 38713: cataloguing/z3950_auth_search.tt
5013cd59d1c Bug 38713: cataloguing/editor.tt
71102ce128f Bug 38713: catalogue/stockrotation.tt
6fccf3ac57d Bug 38713: catalogue/labeledMARCdetail.tt
05b67f9767f Bug 38713: catalogue/MARCdetail.tt
0226be33a63 Bug 38713: catalogue/detail.tt
2357ecfa372 Bug 38713: catalogue/detail.tt
5ac1ae9644a Bug 38713: admin/restrictions.tt
fed20a98437 Bug 38713: admin/patron-attr-types.tt
d67afd91a53 Bug 38713: admin/oai_servers.tt
eee76ca6bd7 Bug 38713: admin/koha2marclinks.tt
d9916436617 Bug 38713: admin/itemtypes.tt
d730a975c63 Bug 38713: admin/items_search_fields.tt
979103208c2 Bug 38713: admin/ill_batch_statuses.tt
83154395b3e Bug 38713: admin/currency.tt
6368fce1c58 Bug 38713: admin/curbside_pickup.tt
42ac7f643cb Bug 38713: admin/checkmarc.tt
d2b195e4501 Bug 38713: admin/categories.tt
bea78375f4b Bug 38713: admin/branches.tt
8d92b172279 Bug 38713: admin/auth_subfields_structure.tt
d11afa403e2 Bug 38713: admin/authorised_values.tt
d694e68de1c Bug 38713: admin/aqplan.tt
5df85e29ecd Bug 38713: admin/aqbudgetperiods.tt
63e7942b118 Bug 38713: admin/admin-home.tt
976bc045508 Bug 38713: admin/additional-fields.tt
5f4d506f1aa Bug 38713: acqui/supplier
0b46b678064 Bug 38713: acqui/supplier.tt
0a1eecc7fdb Bug 38713: acqui/neworderempty.tt
1962f82a05c Bug 38713: acqui/lateorders.tt
b7d4f08d682 Bug 38713: acqui/invoices.tt
1835d888014 Bug 38713: acqui/edimsg.tt
a421d80029e Bug 38713: acqui/duplicate_orders.tt
22bec0c0b1d Bug 38713: acqui/vendor_issues.tt
8e866032611 Bug 38713: auth.tt
64e4d70e800 Bug 38713: about.tt
c4951567f74 Bug 38713: acqui-home.tt

Please adjust the status of the bug report.

Thanks! :)
Comment 7 Lucas Gass (lukeg) 2025-01-22 19:16:45 UTC
I have reviewed each of the changed files: 


We should certainly fix this here: 

reserve/request.tt:
<i class="fa fa-exclamation-triangle fa-lg" style="color:gold" title="Requires override of hold policy" />
<i> tags should not be self-closing. 


Things I am noting that we can fix here, or open separate bugs for: 

modules/opac-reset-password.tt:
I know the others in the SWITCH/CASE are <span> but <span></span><br /> is better as just <div></div>
<span>Please log-in to account to update your password.</span><br /> 

should be: <div>Please log-in to account to update your password.</div> 

serials/subscription-add.tt
<center> tag is unsupported in HTML, should be CSS instead.

catalogue/results.tt
<br/>OR<br/> is weird. Should be <p>OR</p> and it’s parent probably needs to be a <div>

includes/member-display-alt-address-style.inc
Best to avoid <br/> for splitting up the content. Wrapping in <p> tags would be better, IMO.
Comment 8 Jonathan Druart 2025-01-23 08:34:33 UTC
(In reply to Lucas Gass (lukeg) from comment #7)
> I have reviewed each of the changed files: 
> 
> 
> We should certainly fix this here: 
> 
> reserve/request.tt:
> <i class="fa fa-exclamation-triangle fa-lg" style="color:gold"
> title="Requires override of hold policy" />
> <i> tags should not be self-closing. 

Indeed, fixed in "Bug 38713: i tags should not be self-closing"
It's the only occurrence I found.

Command used:
perl -0777 -ne 'print "Self-closing <i> tag found in $ARGV: $1\n" while /(<i(?:\s+[^>]*)?\/>)/ig' **/*.tt **/*.inc

> Things I am noting that we can fix here, or open separate bugs for: 
> 
> modules/opac-reset-password.tt:
> I know the others in the SWITCH/CASE are <span> but <span></span><br /> is
> better as just <div></div>
> <span>Please log-in to account to update your password.</span><br /> 
> 
> should be: <div>Please log-in to account to update your password.</div> 

Yes, that's for somewhere else as the change made here are only replacing </br> to the correct <br/>

> serials/subscription-add.tt
> <center> tag is unsupported in HTML, should be CSS instead.

Done in "Bug 38713: Replace <center> by its css equivalent"
There is another occurrence that is going to be removed on bug 38952.

> catalogue/results.tt
> <br/>OR<br/> is weird. Should be <p>OR</p> and it’s parent probably needs to
> be a <div>

I agree, but there is a tiny UI change when switching to p. Better to deal with this separately that making a change that will be hidden in this big set.

> includes/member-display-alt-address-style.inc
> Best to avoid <br/> for splitting up the content. Wrapping in <p> tags would
> be better, IMO.

Same that previously, br is the current tag, I prefer to deal with that separately.
Comment 9 Lucas Gass (lukeg) 2025-01-23 14:36:19 UTC
Reviewing this after the follow-ups. I would pass QA here now.
Comment 10 Jonathan Druart 2025-01-23 14:50:28 UTC
Created attachment 176973 [details] [review]
Bug 38713: acqui-home.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 11 Jonathan Druart 2025-01-23 14:50:30 UTC
Created attachment 176974 [details] [review]
Bug 38713: about.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 12 Jonathan Druart 2025-01-23 14:50:33 UTC
Created attachment 176975 [details] [review]
Bug 38713: auth.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 13 Jonathan Druart 2025-01-23 14:50:36 UTC
Created attachment 176976 [details] [review]
Bug 38713: acqui/vendor_issues.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 14 Jonathan Druart 2025-01-23 14:50:38 UTC
Created attachment 176977 [details] [review]
Bug 38713: acqui/duplicate_orders.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 15 Jonathan Druart 2025-01-23 14:50:41 UTC
Created attachment 176978 [details] [review]
Bug 38713: acqui/edimsg.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 16 Jonathan Druart 2025-01-23 14:50:44 UTC
Created attachment 176979 [details] [review]
Bug 38713: acqui/invoices.tt

ul are not allowed in p

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 17 Jonathan Druart 2025-01-23 14:50:47 UTC
Created attachment 176980 [details] [review]
Bug 38713: acqui/lateorders.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 18 Jonathan Druart 2025-01-23 14:50:50 UTC
Created attachment 176981 [details] [review]
Bug 38713: acqui/neworderempty.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 19 Jonathan Druart 2025-01-23 14:50:53 UTC
Created attachment 176982 [details] [review]
Bug 38713: acqui/supplier.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 20 Jonathan Druart 2025-01-23 14:50:55 UTC
Created attachment 176983 [details] [review]
Bug 38713: acqui/supplier

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 21 Jonathan Druart 2025-01-23 14:50:58 UTC
Created attachment 176984 [details] [review]
Bug 38713: admin/additional-fields.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 22 Jonathan Druart 2025-01-23 14:51:01 UTC
Created attachment 176985 [details] [review]
Bug 38713: admin/admin-home.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 23 Jonathan Druart 2025-01-23 14:51:04 UTC
Created attachment 176986 [details] [review]
Bug 38713: admin/aqbudgetperiods.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 24 Jonathan Druart 2025-01-23 14:51:07 UTC
Created attachment 176987 [details] [review]
Bug 38713: admin/aqplan.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 25 Jonathan Druart 2025-01-23 14:51:10 UTC
Created attachment 176988 [details] [review]
Bug 38713: admin/authorised_values.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 26 Jonathan Druart 2025-01-23 14:51:13 UTC
Created attachment 176989 [details] [review]
Bug 38713: admin/auth_subfields_structure.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 27 Jonathan Druart 2025-01-23 14:51:15 UTC
Created attachment 176990 [details] [review]
Bug 38713: admin/branches.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 28 Jonathan Druart 2025-01-23 14:51:18 UTC
Created attachment 176991 [details] [review]
Bug 38713: admin/categories.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 29 Jonathan Druart 2025-01-23 14:51:21 UTC
Created attachment 176992 [details] [review]
Bug 38713: admin/checkmarc.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 30 Jonathan Druart 2025-01-23 14:51:23 UTC
Created attachment 176993 [details] [review]
Bug 38713: admin/curbside_pickup.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 31 Jonathan Druart 2025-01-23 14:51:26 UTC
Created attachment 176994 [details] [review]
Bug 38713: admin/currency.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 32 Jonathan Druart 2025-01-23 14:51:28 UTC
Created attachment 176995 [details] [review]
Bug 38713: admin/ill_batch_statuses.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 33 Jonathan Druart 2025-01-23 14:51:31 UTC
Created attachment 176996 [details] [review]
Bug 38713: admin/items_search_fields.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 34 Jonathan Druart 2025-01-23 14:51:34 UTC
Created attachment 176997 [details] [review]
Bug 38713: admin/itemtypes.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 35 Jonathan Druart 2025-01-23 14:51:38 UTC
Created attachment 176998 [details] [review]
Bug 38713: admin/koha2marclinks.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 36 Jonathan Druart 2025-01-23 14:51:40 UTC
Created attachment 176999 [details] [review]
Bug 38713: admin/oai_servers.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 37 Jonathan Druart 2025-01-23 14:51:43 UTC
Created attachment 177000 [details] [review]
Bug 38713: admin/patron-attr-types.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 38 Jonathan Druart 2025-01-23 14:51:46 UTC
Created attachment 177001 [details] [review]
Bug 38713: admin/restrictions.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 39 Jonathan Druart 2025-01-23 14:51:48 UTC
Created attachment 177002 [details] [review]
Bug 38713: catalogue/detail.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 40 Jonathan Druart 2025-01-23 14:51:51 UTC
Created attachment 177003 [details] [review]
Bug 38713: catalogue/detail.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 41 Jonathan Druart 2025-01-23 14:51:55 UTC
Created attachment 177004 [details] [review]
Bug 38713: catalogue/MARCdetail.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 42 Jonathan Druart 2025-01-23 14:51:57 UTC
Created attachment 177005 [details] [review]
Bug 38713: catalogue/labeledMARCdetail.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 43 Jonathan Druart 2025-01-23 14:52:00 UTC
Created attachment 177006 [details] [review]
Bug 38713: catalogue/stockrotation.tt

form in p is invalid

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 44 Jonathan Druart 2025-01-23 14:52:03 UTC
Created attachment 177007 [details] [review]
Bug 38713: cataloguing/editor.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 45 Jonathan Druart 2025-01-23 14:52:06 UTC
Created attachment 177008 [details] [review]
Bug 38713: cataloguing/z3950_auth_search.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 46 Jonathan Druart 2025-01-23 14:52:09 UTC
Created attachment 177009 [details] [review]
Bug 38713: circ/article-requests.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 47 Jonathan Druart 2025-01-23 14:52:12 UTC
Created attachment 177010 [details] [review]
Bug 38713: circ/circulation.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 48 Jonathan Druart 2025-01-23 14:52:15 UTC
Created attachment 177011 [details] [review]
Bug 38713: circ/printslip.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 49 Jonathan Druart 2025-01-23 14:52:18 UTC
Created attachment 177012 [details] [review]
Bug 38713: circ/returns.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 50 Jonathan Druart 2025-01-23 14:52:20 UTC
Created attachment 177013 [details] [review]
Bug 38713: budgets-admin-toolbar.inc

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 51 Jonathan Druart 2025-01-23 14:52:23 UTC
Created attachment 177014 [details] [review]
Bug 38713: html_helpers/tables/items/catalogue_detail.inc

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 52 Jonathan Druart 2025-01-23 14:52:26 UTC
Created attachment 177015 [details] [review]
Bug 38713: ill-toolbar.inc

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 53 Jonathan Druart 2025-01-23 14:52:29 UTC
Created attachment 177016 [details] [review]
Bug 38713: item-status.inc

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 54 Jonathan Druart 2025-01-23 14:52:32 UTC
Created attachment 177017 [details] [review]
Bug 38713: member-display-alt-address-style.inc

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 55 Jonathan Druart 2025-01-23 14:52:35 UTC
Created attachment 177018 [details] [review]
Bug 38713: clubs/patron-clubs-tab.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 56 Jonathan Druart 2025-01-23 14:52:38 UTC
Created attachment 177019 [details] [review]
Bug 38713: ill/ill-requests.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 57 Jonathan Druart 2025-01-23 14:52:41 UTC
Created attachment 177020 [details] [review]
Bug 38713: installer/step3.tt

p cannot contain form

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 58 Jonathan Druart 2025-01-23 14:52:44 UTC
Created attachment 177021 [details] [review]
Bug 38713: labels/label-edit-batch.tt

The first row is the headers for thead, then the other rows are the
tbody.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 59 Jonathan Druart 2025-01-23 14:52:48 UTC
Created attachment 177022 [details] [review]
Bug 38713: labels/label-manage.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 60 Jonathan Druart 2025-01-23 14:52:51 UTC
Created attachment 177023 [details] [review]
Bug 38713: members/boraccount.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 61 Jonathan Druart 2025-01-23 14:52:55 UTC
Created attachment 177024 [details] [review]
Bug 38713: members/memberentrygen.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 62 Jonathan Druart 2025-01-23 14:52:58 UTC
Created attachment 177025 [details] [review]
Bug 38713: members/merge-patrons.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 63 Jonathan Druart 2025-01-23 14:53:01 UTC
Created attachment 177026 [details] [review]
Bug 38713: catalogue/results.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 64 Jonathan Druart 2025-01-23 14:53:04 UTC
Created attachment 177027 [details] [review]
Bug 38713: patron_lists/list.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 65 Jonathan Druart 2025-01-23 14:53:07 UTC
Created attachment 177028 [details] [review]
Bug 38713: patron_lists/patron-lists-tab.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 66 Jonathan Druart 2025-01-23 14:53:10 UTC
Created attachment 177029 [details] [review]
Bug 38713: plugins/plugins-home.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 67 Jonathan Druart 2025-01-23 14:53:13 UTC
Created attachment 177030 [details] [review]
Bug 38713: reports/dictionary.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 68 Jonathan Druart 2025-01-23 14:53:16 UTC
Created attachment 177031 [details] [review]
Bug 38713: reports/guided_reports_start.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 69 Jonathan Druart 2025-01-23 14:53:19 UTC
Created attachment 177032 [details] [review]
Bug 38713: reports/reports-home.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 70 Jonathan Druart 2025-01-23 14:53:22 UTC
Created attachment 177033 [details] [review]
Bug 38713: reports/serials_stats.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 71 Jonathan Druart 2025-01-23 14:53:25 UTC
Created attachment 177034 [details] [review]
Bug 38713: reserve/request.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 72 Jonathan Druart 2025-01-23 14:53:28 UTC
Created attachment 177035 [details] [review]
Bug 38713: rotating_collections/addItems.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 73 Jonathan Druart 2025-01-23 14:53:31 UTC
Created attachment 177036 [details] [review]
Bug 38713: rotating_collections/transferCollection.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 74 Jonathan Druart 2025-01-23 14:53:34 UTC
Created attachment 177037 [details] [review]
Bug 38713: serials/routing-preview.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 75 Jonathan Druart 2025-01-23 14:53:37 UTC
Created attachment 177038 [details] [review]
Bug 38713: serials/routing.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 76 Jonathan Druart 2025-01-23 14:53:40 UTC
Created attachment 177039 [details] [review]
Bug 38713: serials/serials-collection.tt

p cannot contain div

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 77 Jonathan Druart 2025-01-23 14:53:43 UTC
Created attachment 177040 [details] [review]
Bug 38713: serials/serials-edit.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 78 Jonathan Druart 2025-01-23 14:53:46 UTC
Created attachment 177041 [details] [review]
Bug 38713: serials/showpredictionpattern.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 79 Jonathan Druart 2025-01-23 14:53:49 UTC
Created attachment 177042 [details] [review]
Bug 38713: serials/subscription-add.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 80 Jonathan Druart 2025-01-23 14:53:52 UTC
Created attachment 177043 [details] [review]
Bug 38713: tags/list.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 81 Jonathan Druart 2025-01-23 14:53:55 UTC
Created attachment 177044 [details] [review]
Bug 38713: tools/additional-contents.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 82 Jonathan Druart 2025-01-23 14:53:58 UTC
Created attachment 177045 [details] [review]
Bug 38713: tools/modborrowers.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 83 Jonathan Druart 2025-01-23 14:54:01 UTC
Created attachment 177046 [details] [review]
Bug 38713: Fix mismatched closing tag in opac-curbside-pickups.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 84 Jonathan Druart 2025-01-23 14:54:04 UTC
Created attachment 177047 [details] [review]
Bug 38713: Fix mismatched closing tag in opac-discharge.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 85 Jonathan Druart 2025-01-23 14:54:07 UTC
Created attachment 177048 [details] [review]
Bug 38713: Fix opac-reset-password.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 86 Jonathan Druart 2025-01-23 14:54:10 UTC
Created attachment 177049 [details] [review]
Bug 38713: Fix opac-suggestions.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 87 Jonathan Druart 2025-01-23 14:54:13 UTC
Created attachment 177050 [details] [review]
Bug 38713: Remove stray closing tag from opac-addbybiblionumber.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 88 Jonathan Druart 2025-01-23 14:54:17 UTC
Created attachment 177051 [details] [review]
Bug 38713: Add mising </ul> to opac-recall.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 89 Jonathan Druart 2025-01-23 14:54:20 UTC
Created attachment 177052 [details] [review]
Bug 38713: masthead-sci.inc [opac]

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 90 Jonathan Druart 2025-01-23 14:54:23 UTC
Created attachment 177053 [details] [review]
Bug 38713: modals/checkout.inc [opac]

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 91 Jonathan Druart 2025-01-23 14:54:26 UTC
Created attachment 177054 [details] [review]
Bug 38713: result-batch-controls.inc [opac]

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 92 Jonathan Druart 2025-01-23 14:54:29 UTC
Created attachment 177055 [details] [review]
Bug 38713: opac-account-pay-error.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 93 Jonathan Druart 2025-01-23 14:54:32 UTC
Created attachment 177056 [details] [review]
Bug 38713: opac-detail.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 94 Jonathan Druart 2025-01-23 14:54:35 UTC
Created attachment 177057 [details] [review]
Bug 38713: opac-user.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 95 Jonathan Druart 2025-01-23 14:54:38 UTC
Created attachment 177058 [details] [review]
Bug 38713: (follow-up) reserve/request.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 96 Jonathan Druart 2025-01-23 14:54:41 UTC
Created attachment 177059 [details] [review]
Bug 38713: i tags should not be self-closing

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 97 Jonathan Druart 2025-01-23 14:54:44 UTC
Created attachment 177060 [details] [review]
Bug 38713: Replace <center> by its css equivalent

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 98 Katrin Fischer 2025-01-24 14:06:02 UTC
Can we get a speedy check on bug 30707 please? It's the dependency here.
Comment 99 Katrin Fischer 2025-01-24 14:12:06 UTC
Let's coordinate this early next week!
Comment 100 Katrin Fischer 2025-01-30 17:07:18 UTC
Pushed for 25.05!

Well done everyone, thank you!