Bug 31063 - [OMNIBUS] QOTD tool
Summary: [OMNIBUS] QOTD tool
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 31012 30903 31014 31062
Blocks:
  Show dependency treegraph
 
Reported: 2022-06-29 01:27 UTC by David Nind
Modified: 2022-07-15 14:22 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 31036: (QA follow-up) Add a warning to the system preference (1.44 KB, patch)
2022-07-15 14:21 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2022-06-29 01:27:34 UTC
There are several current bugs for the Quote of The Day tool. 

I've created this omnibus bug so that any changes required (including improvements) to the tool can be managed in small steps.
Comment 1 David Nind 2022-06-29 02:23:22 UTC
Some ideas and areas for improvement:

1. Title and description for the QOTD tool (on the tools page) - bug 31062
   . the pages in the tool use 'Quote editor' as part of the breadcrumb

2. Quote list page:
   - Is the ID column required? If you delete a quote, it leaves a gap in the numbering.
   - Alignment of table of quotes: if you make your browser screen wide enough, the table is centered. Generally, tables elsewhere in the staff interface are left aligned.

3. Importing quotes:
   - Page name: change from 'Quote uploader' to 'Import quotes' - rationale: button on quotes page is "Import quotes"
   - Breadcrumb: Home > Tools Quote editor > Import quotes
   - Placement of instructions: there is quite a gap between the page heading (Quote uploader) and the instructions box
   - Instructions: text says "Click the "Choose file" button....", button name is "Browse", change text to "Browse and select the CSV file with the quotes to import."
   - Instructions: not sure the last bullet point is needed, "The file will be imported into an editable table for review prior to saving." (see discussion on process for import)
   - Upload quotes box: 
     . change to title to "Import quotes" to be consistent
     . placement of the Browse button - too close to the heading, lots of extra space after
     . if process changed for how to import (for example, not giving the chance to review and edit), then add a button below browse - "Import quotes"
   - Actual import screen: 
     . Instructions: gap between heading and instructions, if changed so that don't get a chance to edit then this can be removed (see next item), also there is extra space after the last bullet point in the instructions
     . Listing and editing: the layout reflects the old way to edit quotes, where you clicked on a cell to edit. I don't think we should give importers a chance to edit here - it should just cover whether the import was successful, or if there were any errors.
    - Title: change form 'Quote uploader' to 'Import quotes'
    - 'Save quotes' button: change to 'Import quotes'
    - How should this page work? bug 31012 
      . List quotes and then have 'Import quotes' and 'Cancel import' options
      . Error message if CSV file not in the right format
      . Go back to the main screen with a message box at the top saying something like "X quotes successfully imported", or if it is 'enqued', then 'The quotes are enqued' (or whatever message we use when enqued)

4. New quotes:
   - Size of input fields: These are quite small - make larger (bug 31014)
   - Breadcrumb: suggestion - Home > Tools > Quote editor > New quote

5. Modify quotes:
   - Size of input fields: same as 4 (new quotes) these are quite small (however, not familiar enough with our normal user interface patterns) (bug 31014)
   - Breadcrumb: not sure if one can be added, but maybe Home > Tools > Quote editor > Modify quote (not sure if we have standardised on 'Modify' or 'Edit" - I think we use both in various places!)

6. Deleting quotes:
   - Message: when you delete a quite, the modal windows says "You are about to delete the quote #2", if we do away with displaying the number in the quotes list this would need changed. Perhaps:
     "You are about to delete the quote:
        Whatever the quote is
                      ~ Source ~"
Comment 2 Martin Renvoize 2022-07-15 14:21:06 UTC
Created attachment 137761 [details] [review]
Bug 31036: (QA follow-up) Add a warning to the system preference

As suggested by Katrin, adding a warning to the system preference that
this has an effect on SIP configurations that needs to be understood.
Comment 3 Martin Renvoize 2022-07-15 14:22:48 UTC
Doh, wrong bug.. sorry for the noise