We would like a new layout that puts library, vendor and order information on one page, that reads more like an invoice with a letter head.
Created attachment 138236 [details] [review] Bug 31257: WIP
Created attachment 138454 [details] [review] Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College
Created attachment 140644 [details] [review] Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind <david@davidnind.com>
Created attachment 140645 [details] Example PDF output - Document column is very narrow I've signed off, but noted that: 1. The Document column is very narrow and the Qty column is very wide. Could this be fixed? Have attached an example. 2. I assume there is a limit on the number of lines for address fields, otherwise it displays "funny". Also, should the WIP patch be obsoleted?
Created attachment 141299 [details] [review] Bug 31257: (follow-up) Fix display of PDF This patch rearranges the Qty and Document columns and shifts the vendor account number field lower to make room for address fields
Thank you for your testing. I've left your signed off patch and attached a follow-up to address the two comments below. (In reply to David Nind from comment #4) > Created attachment 140645 [details] > Example PDF output - Document column is very narrow > > I've signed off, but noted that: > > 1. The Document column is very narrow and the Qty column is very wide. Could > this be fixed? Have attached an example. > Switched these around. > 2. I assume there is a limit on the number of lines for address fields, > otherwise it displays "funny". Shifted the account number field lower to make space for address fields. But yes if there are a lot of address lines then there will be overlap. > > Also, should the WIP patch be obsoleted? Yes! Have done so. Ready for testing please
Created attachment 141304 [details] [review] Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind <david@davidnind.com>
Created attachment 141305 [details] [review] Bug 31257: (follow-up) Fix display of PDF This patch rearranges the Qty and Document columns and shifts the vendor account number field lower to make room for address fields Signed-off-by: David Nind <david@davidnind.com>
Thanks Aleisha for updating. Have signed off.
Comment on attachment 140645 [details] Example PDF output - Document column is very narrow Obsoleted as layout now updated.
Created attachment 141551 [details] [review] Bug 31257: Add a new English 1 page layout to export basketgroup This patch adds a new English 1 page layout to be used when exporting a basketgroup as PDF. This has been modelled after an example PDF from another library system. To test: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to the new English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add a few orders to the basket. 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm all of the information displayed is correct. 9) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141552 [details] [review] Bug 31257: (follow-up) Fix display of PDF This patch rearranges the Qty and Document columns and shifts the vendor account number field lower to make room for address fields Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141553 [details] [review] Bug 31257: (QA follow-up) Fix some typos The QA tools highlighted some typos in the code comments that this fixes: measurment and milimeter Also removes a space befor colon form: Vendor note : Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This works and I can see how this simpler format will be helpful. But at the same time I wish we had a better technical solution for the PDF printing. The combination of strings in .pm and .odt/.pdf makes every attempt to make these translatable pretty futile... Also no customizations of text etc. without programming :( So I've filed bug 31723 to have a 'home' for that wish to evolve :)
Pushed to master for 22.11. Nice work everyone, thanks!
Hi all, We have a follow-up patch set for this enhancement on bug 33340 ready for testing! Thanks, Alex