Bug 33340 - Correct formatting of English 1-page order PDF when the basket group covers multiple pages
Summary: Correct formatting of English 1-page order PDF when the basket group covers m...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Alex Buckley
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 31257
Blocks: 33393
  Show dependency treegraph
 
Reported: 2023-03-27 03:13 UTC by Alex Buckley
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
If a basket group contains many order lines, this will ensure: * The page number at the bottom of the first page is not obscured. * The table of ordered items does not start half way down the second page.
Version(s) released in:
23.05.00,22.11.07


Attachments
English 1-page order PDF covering multiple pages with page number obscured and table starting halfway down second page (47.09 KB, application/pdf)
2023-03-27 03:13 UTC, Alex Buckley
Details
Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages (2.35 KB, patch)
2023-03-27 03:46 UTC, Alex Buckley
Details | Diff | Splinter Review
English 1-page order PDF covering multiple pages with formatting fixed (47.20 KB, application/pdf)
2023-03-27 03:49 UTC, Alex Buckley
Details
Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages (2.41 KB, patch)
2023-03-27 13:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages (2.47 KB, patch)
2023-04-28 13:45 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2023-03-27 03:13:30 UTC
Created attachment 148731 [details]
English 1-page order PDF covering multiple pages with page number obscured and table starting halfway down second page

Currently, when a basket group contains a lot of ordered items (more than be listed on one page) the following happens:

- The page numbers at the bottom of the first page are obscured.
- The table on the second page starts halfway down the page.

See the attachment as an example.

We would like the page numbers on the first page to be visible, and the table to start near the top of the second (and all subsequent pages).
Comment 1 Alex Buckley 2023-03-27 03:46:12 UTC
Created attachment 148732 [details] [review]
Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages

If a basket group contains many ordered items then this patchset will
ensure:
 - The page number at the bottom of the first page is not obscured
 - The table of ordered items does not start half way down the second
 page

Test plan:

1) Go to Koha Administration -> Libraries. Ensure Library A has an
address, phone and fax.
2) Go to Koha Administration -> System preferences. Search for
OrderPdfFormat. Set this to English 1-page layout option.
3) Go to Acquisitions. Use an existing vendor or create a new one.
Ensure the vendor has a postal address, phone, fax and accout number.
4) Create a basket for this vendor. Add many orders to this basket, for
example 25 items (this is to make the Order PDF cover multiple pages).
5) Close the basket and add it to a basket group of the same name.
6) Edit the basket group. Add an address in the delivery place, and a
delivery comment. Check the box to close the basket group and Save.
7) Click the button to Export as PDF.
8) View the exported PDF. Confirm the PDF is multiple pages long. If it
is not then re-open the basketgroup and add more orders to the basket
and repeat steps 5, 6, 7 and 8
9) If the PDF is multiple pages long then confirm:
- The page numbers at the bottom of the first page are not obscured by
the order table.
- That the order table starts near the top of the second page, and not
half way down.
10) Reopen the basketgroup. Edit the details and remove the delivery
place text. Re-close the basketgroup.
10) Repeat steps 7 and 8.

Sponsored-by: Pymble Ladies' College
Comment 2 Alex Buckley 2023-03-27 03:49:57 UTC
Created attachment 148733 [details]
English 1-page order PDF covering multiple pages with formatting fixed

- The page numbers at the bottom of the first page not obscured 
- The table starts near the top of the second page
Comment 3 Alex Buckley 2023-03-27 04:19:57 UTC
Ready for testing
Comment 4 ByWater Sandboxes 2023-03-27 13:01:16 UTC
Created attachment 148764 [details] [review]
Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages

If a basket group contains many ordered items then this patchset will
ensure:
 - The page number at the bottom of the first page is not obscured
 - The table of ordered items does not start half way down the second
 page

Test plan:

1) Go to Koha Administration -> Libraries. Ensure Library A has an
address, phone and fax.
2) Go to Koha Administration -> System preferences. Search for
OrderPdfFormat. Set this to English 1-page layout option.
3) Go to Acquisitions. Use an existing vendor or create a new one.
Ensure the vendor has a postal address, phone, fax and accout number.
4) Create a basket for this vendor. Add many orders to this basket, for
example 25 items (this is to make the Order PDF cover multiple pages).
5) Close the basket and add it to a basket group of the same name.
6) Edit the basket group. Add an address in the delivery place, and a
delivery comment. Check the box to close the basket group and Save.
7) Click the button to Export as PDF.
8) View the exported PDF. Confirm the PDF is multiple pages long. If it
is not then re-open the basketgroup and add more orders to the basket
and repeat steps 5, 6, 7 and 8
9) If the PDF is multiple pages long then confirm:
- The page numbers at the bottom of the first page are not obscured by
the order table.
- That the order table starts near the top of the second page, and not
half way down.
10) Reopen the basketgroup. Edit the details and remove the delivery
place text. Re-close the basketgroup.
10) Repeat steps 7 and 8.

Sponsored-by: Pymble Ladies' College
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 5 Kyle M Hall 2023-04-28 13:45:48 UTC
Created attachment 150384 [details] [review]
Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages

If a basket group contains many ordered items then this patchset will
ensure:
 - The page number at the bottom of the first page is not obscured
 - The table of ordered items does not start half way down the second
 page

Test plan:

1) Go to Koha Administration -> Libraries. Ensure Library A has an
address, phone and fax.
2) Go to Koha Administration -> System preferences. Search for
OrderPdfFormat. Set this to English 1-page layout option.
3) Go to Acquisitions. Use an existing vendor or create a new one.
Ensure the vendor has a postal address, phone, fax and accout number.
4) Create a basket for this vendor. Add many orders to this basket, for
example 25 items (this is to make the Order PDF cover multiple pages).
5) Close the basket and add it to a basket group of the same name.
6) Edit the basket group. Add an address in the delivery place, and a
delivery comment. Check the box to close the basket group and Save.
7) Click the button to Export as PDF.
8) View the exported PDF. Confirm the PDF is multiple pages long. If it
is not then re-open the basketgroup and add more orders to the basket
and repeat steps 5, 6, 7 and 8
9) If the PDF is multiple pages long then confirm:
- The page numbers at the bottom of the first page are not obscured by
the order table.
- That the order table starts near the top of the second page, and not
half way down.
10) Reopen the basketgroup. Edit the details and remove the delivery
place text. Re-close the basketgroup.
10) Repeat steps 7 and 8.

Sponsored-by: Pymble Ladies' College
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-05-16 18:19:30 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Alex Buckley 2023-05-17 19:56:30 UTC
Thank you Tomás!

Could we please request that this enhancement be backported to 22.11.x?

Our client who sponsored the enhancement would love to benefit from having it sooner than their next major upgrade in Jan-March next year.
Comment 8 Pedro Amorim 2023-06-07 12:18:50 UTC
Nice work everyone!

Pushed to 22.11.x for next release
Comment 9 Alex Buckley 2023-06-13 22:15:58 UTC
Thank you very much indeed for backporting this to 22.11.x. 

It is hugely appreciated by us and the client who sponsored it.