Bug 31320 - Remove GetItemsInfo from virtualshelves/sendshelf.pl
Summary: Remove GetItemsInfo from virtualshelves/sendshelf.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Joonas Kylmälä
URL:
Keywords:
: 22352 (view as bug list)
Depends on: 31306
Blocks: 27272
  Show dependency treegraph
 
Reported: 2022-08-08 14:23 UTC by Jonathan Druart
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl (7.00 KB, patch)
2022-08-08 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl (7.04 KB, patch)
2022-08-09 13:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl (7.19 KB, patch)
2022-08-14 14:27 UTC, Joonas Kylmälä
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-08-08 14:23:13 UTC
Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with virtualshelves/sendshelf.pl
Comment 1 Jonathan Druart 2022-08-08 14:53:20 UTC
Created attachment 138830 [details] [review]
Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl

And GetItemsLocationInfo from shelves.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with virtualshelves/sendshelf.pl

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly
Comment 2 Owen Leonard 2022-08-09 13:10:43 UTC
Created attachment 138909 [details] [review]
Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl

And GetItemsLocationInfo from shelves.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with virtualshelves/sendshelf.pl

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Joonas Kylmälä 2022-08-14 14:27:33 UTC
Created attachment 139094 [details] [review]
Bug 31320: Remove GetItemsInfo from virtualshelves/sendshelf.pl

And GetItemsLocationInfo from shelves.pl

Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with virtualshelves/sendshelf.pl

Test plan:
List items on the modified view and confirm that all the info is
displayed correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Comment 4 Tomás Cohen Arazi 2022-08-16 13:22:30 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Kyle M Hall 2022-08-19 14:19:41 UTC
*** Bug 22352 has been marked as a duplicate of this bug. ***