Refactor to use Koha::Import::Records
Created attachment 140659 [details] [review] Bug 31569: DB update and objects
Created attachment 140660 [details] [review] Bug 31569: DO NOT PUSH Schema Updates RM: Please copy object class lines :-)
Created attachment 140661 [details] [review] Bug 31569: Remove GetImportRecordsRange from import_biblios_list This patch changes the way records are loaded for display when adding to a basket from a staged file To test: 1 - Stage a file of records for import 2 - Go to Acquisitions, find a vendor, create or find a basket 3 - Add to basket from staged file 4 - Choose the file 5 - Note the display of records 6 - Cancel 7 - Apply patch 8 - Stage from same file 9 - Note the display is unchanged
Created attachment 140662 [details] [review] Bug 31569: Remove GetImportRecordsRange from import stage This patch removes the use of GetimportRecordsRange from the importing step To test: 0 - Apply patch 1 - Stage a marc file for import 2 - Add to basket from a staged file 3 - Select titles to import (don't select all) 4 - Fill out necessary fields, be sure to select itemtype on items tab 5 - Import 6 - Confirm titles successfully added to basket 7 - Confirm staged import not marked as imported 8 - Add to basket from same file 9 - Select rest of titles 10 - Import 11 - Confirm staged file now marked imported
Created attachment 140663 [details] [review] Bug 31569: Remove GetImportRecordsRange from list step This patch removes the use of GetImportRecordsRange from the step of listing import batches to choose. It was only used for a count so is a simple replacement To test: 1 - Stage a number of files for import 2 - Import one of the files from tools 3 - Add to basket form a staged file 4 - Confirm staged baskets are listed, and imported basket is not
Created attachment 140664 [details] [review] Bug 31569: Remove unecessary imports By using objects a number of other routines are not needed: GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber To test: Grep for routines above in addorderiso2709 and confirm they are not used
Created attachment 140665 [details] [review] Bug 31569: Add filters
Created attachment 140676 [details] [review] Bug 31569: DB update and objects Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 140677 [details] [review] Bug 31569: DO NOT PUSH Schema Updates RM: Please copy object class lines :-) Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 140678 [details] [review] Bug 31569: Remove GetImportRecordsRange from import_biblios_list This patch changes the way records are loaded for display when adding to a basket from a staged file To test: 1 - Stage a file of records for import 2 - Go to Acquisitions, find a vendor, create or find a basket 3 - Add to basket from staged file 4 - Choose the file 5 - Note the display of records 6 - Cancel 7 - Apply patch 8 - Stage from same file 9 - Note the display is unchanged Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 140679 [details] [review] Bug 31569: Remove GetImportRecordsRange from import stage This patch removes the use of GetimportRecordsRange from the importing step To test: 0 - Apply patch 1 - Stage a marc file for import 2 - Add to basket from a staged file 3 - Select titles to import (don't select all) 4 - Fill out necessary fields, be sure to select itemtype on items tab 5 - Import 6 - Confirm titles successfully added to basket 7 - Confirm staged import not marked as imported 8 - Add to basket from same file 9 - Select rest of titles 10 - Import 11 - Confirm staged file now marked imported Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 140680 [details] [review] Bug 31569: Remove GetImportRecordsRange from list step This patch removes the use of GetImportRecordsRange from the step of listing import batches to choose. It was only used for a count so is a simple replacement To test: 1 - Stage a number of files for import 2 - Import one of the files from tools 3 - Add to basket form a staged file 4 - Confirm staged baskets are listed, and imported basket is not Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 140681 [details] [review] Bug 31569: Remove unecessary imports By using objects a number of other routines are not needed: GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber To test: Grep for routines above in addorderiso2709 and confirm they are not used Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 140682 [details] [review] Bug 31569: Add filters Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 141504 [details] [review] Bug 31569: DB update and objects Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 141505 [details] [review] Bug 31569: DO NOT PUSH Schema Updates RM: Please copy object class lines :-) Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 141506 [details] [review] Bug 31569: Remove GetImportRecordsRange from import_biblios_list This patch changes the way records are loaded for display when adding to a basket from a staged file To test: 1 - Stage a file of records for import 2 - Go to Acquisitions, find a vendor, create or find a basket 3 - Add to basket from staged file 4 - Choose the file 5 - Note the display of records 6 - Cancel 7 - Apply patch 8 - Stage from same file 9 - Note the display is unchanged Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 141507 [details] [review] Bug 31569: Remove GetImportRecordsRange from import stage This patch removes the use of GetimportRecordsRange from the importing step To test: 0 - Apply patch 1 - Stage a marc file for import 2 - Add to basket from a staged file 3 - Select titles to import (don't select all) 4 - Fill out necessary fields, be sure to select itemtype on items tab 5 - Import 6 - Confirm titles successfully added to basket 7 - Confirm staged import not marked as imported 8 - Add to basket from same file 9 - Select rest of titles 10 - Import 11 - Confirm staged file now marked imported Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 141508 [details] [review] Bug 31569: Remove GetImportRecordsRange from list step This patch removes the use of GetImportRecordsRange from the step of listing import batches to choose. It was only used for a count so is a simple replacement To test: 1 - Stage a number of files for import 2 - Import one of the files from tools 3 - Add to basket form a staged file 4 - Confirm staged baskets are listed, and imported basket is not Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 141509 [details] [review] Bug 31569: Remove unecessary imports By using objects a number of other routines are not needed: GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber To test: Grep for routines above in addorderiso2709 and confirm they are not used Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 141510 [details] [review] Bug 31569: Add filters Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 141511 [details] [review] Bug 31569: (QA follow-up) Remove additional spaces from ISBN/ISSN Before this change, the ISBN woudl display like: ( isbn ) This patch removes the additional spaces so the display is the same as without this patch set on current master: (isbn) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Created attachment 142031 [details] [review] Bug 31569: (QA follow-up) Add missing entries in schema Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>