Bug 31569 - Remove GetImportsRecordRange from acqui/addorderiso2709
Summary: Remove GetImportsRecordRange from acqui/addorderiso2709
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 19358 31708 31709 31710 32166
  Show dependency treegraph
 
Reported: 2022-09-15 12:40 UTC by Nick Clemens
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31569: DB update and objects (5.22 KB, patch)
2022-09-15 13:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31569: DO NOT PUSH Schema Updates (2.56 KB, patch)
2022-09-15 13:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from import_biblios_list (7.39 KB, patch)
2022-09-15 13:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from import stage (4.44 KB, patch)
2022-09-15 13:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from list step (2.48 KB, patch)
2022-09-15 13:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31569: Remove unecessary imports (1.38 KB, patch)
2022-09-15 13:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31569: Add filters (2.05 KB, patch)
2022-09-15 13:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31569: DB update and objects (5.28 KB, patch)
2022-09-15 15:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31569: DO NOT PUSH Schema Updates (2.62 KB, patch)
2022-09-15 15:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from import_biblios_list (7.45 KB, patch)
2022-09-15 15:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from import stage (4.50 KB, patch)
2022-09-15 15:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from list step (2.54 KB, patch)
2022-09-15 15:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31569: Remove unecessary imports (1.44 KB, patch)
2022-09-15 15:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31569: Add filters (2.11 KB, patch)
2022-09-15 15:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31569: DB update and objects (5.34 KB, patch)
2022-10-07 14:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31569: DO NOT PUSH Schema Updates (2.68 KB, patch)
2022-10-07 14:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from import_biblios_list (7.51 KB, patch)
2022-10-07 14:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from import stage (4.55 KB, patch)
2022-10-07 14:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31569: Remove GetImportRecordsRange from list step (2.60 KB, patch)
2022-10-07 14:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31569: Remove unecessary imports (1.49 KB, patch)
2022-10-07 14:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31569: Add filters (2.16 KB, patch)
2022-10-07 14:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31569: (QA follow-up) Remove additional spaces from ISBN/ISSN (2.23 KB, patch)
2022-10-07 14:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31569: (QA follow-up) Add missing entries in schema (1.40 KB, patch)
2022-10-17 21:01 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-09-15 12:40:21 UTC
Refactor to use Koha::Import::Records
Comment 1 Nick Clemens 2022-09-15 13:55:06 UTC
Created attachment 140659 [details] [review]
Bug 31569: DB update and objects
Comment 2 Nick Clemens 2022-09-15 13:55:10 UTC
Created attachment 140660 [details] [review]
Bug 31569: DO NOT PUSH Schema Updates

RM: Please copy object class lines :-)
Comment 3 Nick Clemens 2022-09-15 13:55:13 UTC
Created attachment 140661 [details] [review]
Bug 31569: Remove GetImportRecordsRange from import_biblios_list

This patch changes the way records are loaded for display when adding to
a basket from a staged file

To test:
1 - Stage a file of records for import
2 - Go to Acquisitions, find a vendor, create or find a basket
3 - Add to basket from staged file
4 - Choose the file
5 - Note the display of records
6 - Cancel
7 - Apply patch
8 - Stage from same file
9 - Note the display is unchanged
Comment 4 Nick Clemens 2022-09-15 13:55:17 UTC
Created attachment 140662 [details] [review]
Bug 31569: Remove GetImportRecordsRange from import stage

This patch removes the use of GetimportRecordsRange from the importing
step

To test:
 0 - Apply patch
 1 - Stage a marc file for import
 2 - Add to basket from a staged file
 3 - Select titles to import (don't select all)
 4 - Fill out necessary fields, be sure to select itemtype on items tab
 5 - Import
 6 - Confirm titles successfully added to basket
 7 - Confirm staged import not marked as imported
 8 - Add to basket from same file
 9 - Select rest of titles
10 - Import
11 - Confirm staged file now marked imported
Comment 5 Nick Clemens 2022-09-15 13:55:21 UTC
Created attachment 140663 [details] [review]
Bug 31569: Remove GetImportRecordsRange from list step

This patch removes the use of GetImportRecordsRange from the step
of listing import batches to choose. It was only used for a count so is a simple
replacement

To test:
1 - Stage a number of files for import
2 - Import one of the files from tools
3 - Add to basket form a staged file
4 - Confirm staged baskets are listed, and imported basket is not
Comment 6 Nick Clemens 2022-09-15 13:55:24 UTC
Created attachment 140664 [details] [review]
Bug 31569: Remove unecessary imports

By using objects a number of other routines are not needed:
GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber

To test:
Grep for routines above in addorderiso2709 and confirm they are not used
Comment 7 Nick Clemens 2022-09-15 13:55:29 UTC
Created attachment 140665 [details] [review]
Bug 31569: Add filters
Comment 8 ByWater Sandboxes 2022-09-15 15:01:11 UTC
Created attachment 140676 [details] [review]
Bug 31569: DB update and objects

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 9 ByWater Sandboxes 2022-09-15 15:01:15 UTC
Created attachment 140677 [details] [review]
Bug 31569: DO NOT PUSH Schema Updates

RM: Please copy object class lines :-)

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 10 ByWater Sandboxes 2022-09-15 15:01:18 UTC
Created attachment 140678 [details] [review]
Bug 31569: Remove GetImportRecordsRange from import_biblios_list

This patch changes the way records are loaded for display when adding to
a basket from a staged file

To test:
1 - Stage a file of records for import
2 - Go to Acquisitions, find a vendor, create or find a basket
3 - Add to basket from staged file
4 - Choose the file
5 - Note the display of records
6 - Cancel
7 - Apply patch
8 - Stage from same file
9 - Note the display is unchanged

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 11 ByWater Sandboxes 2022-09-15 15:01:22 UTC
Created attachment 140679 [details] [review]
Bug 31569: Remove GetImportRecordsRange from import stage

This patch removes the use of GetimportRecordsRange from the importing
step

To test:
 0 - Apply patch
 1 - Stage a marc file for import
 2 - Add to basket from a staged file
 3 - Select titles to import (don't select all)
 4 - Fill out necessary fields, be sure to select itemtype on items tab
 5 - Import
 6 - Confirm titles successfully added to basket
 7 - Confirm staged import not marked as imported
 8 - Add to basket from same file
 9 - Select rest of titles
10 - Import
11 - Confirm staged file now marked imported

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 12 ByWater Sandboxes 2022-09-15 15:01:25 UTC
Created attachment 140680 [details] [review]
Bug 31569: Remove GetImportRecordsRange from list step

This patch removes the use of GetImportRecordsRange from the step
of listing import batches to choose. It was only used for a count so is a simple
replacement

To test:
1 - Stage a number of files for import
2 - Import one of the files from tools
3 - Add to basket form a staged file
4 - Confirm staged baskets are listed, and imported basket is not

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 13 ByWater Sandboxes 2022-09-15 15:01:28 UTC
Created attachment 140681 [details] [review]
Bug 31569: Remove unecessary imports

By using objects a number of other routines are not needed:
GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber

To test:
Grep for routines above in addorderiso2709 and confirm they are not used

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 14 ByWater Sandboxes 2022-09-15 15:01:32 UTC
Created attachment 140682 [details] [review]
Bug 31569: Add filters

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 15 Katrin Fischer 2022-10-07 14:30:04 UTC
Created attachment 141504 [details] [review]
Bug 31569: DB update and objects

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 16 Katrin Fischer 2022-10-07 14:30:09 UTC
Created attachment 141505 [details] [review]
Bug 31569: DO NOT PUSH Schema Updates

RM: Please copy object class lines :-)

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 17 Katrin Fischer 2022-10-07 14:30:14 UTC
Created attachment 141506 [details] [review]
Bug 31569: Remove GetImportRecordsRange from import_biblios_list

This patch changes the way records are loaded for display when adding to
a basket from a staged file

To test:
1 - Stage a file of records for import
2 - Go to Acquisitions, find a vendor, create or find a basket
3 - Add to basket from staged file
4 - Choose the file
5 - Note the display of records
6 - Cancel
7 - Apply patch
8 - Stage from same file
9 - Note the display is unchanged

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 18 Katrin Fischer 2022-10-07 14:30:18 UTC
Created attachment 141507 [details] [review]
Bug 31569: Remove GetImportRecordsRange from import stage

This patch removes the use of GetimportRecordsRange from the importing
step

To test:
 0 - Apply patch
 1 - Stage a marc file for import
 2 - Add to basket from a staged file
 3 - Select titles to import (don't select all)
 4 - Fill out necessary fields, be sure to select itemtype on items tab
 5 - Import
 6 - Confirm titles successfully added to basket
 7 - Confirm staged import not marked as imported
 8 - Add to basket from same file
 9 - Select rest of titles
10 - Import
11 - Confirm staged file now marked imported

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 19 Katrin Fischer 2022-10-07 14:30:23 UTC
Created attachment 141508 [details] [review]
Bug 31569: Remove GetImportRecordsRange from list step

This patch removes the use of GetImportRecordsRange from the step
of listing import batches to choose. It was only used for a count so is a simple
replacement

To test:
1 - Stage a number of files for import
2 - Import one of the files from tools
3 - Add to basket form a staged file
4 - Confirm staged baskets are listed, and imported basket is not

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 20 Katrin Fischer 2022-10-07 14:30:28 UTC
Created attachment 141509 [details] [review]
Bug 31569: Remove unecessary imports

By using objects a number of other routines are not needed:
GetImportRecordMarc SetImportRecordStatus SetMatchedBiblionumber

To test:
Grep for routines above in addorderiso2709 and confirm they are not used

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 21 Katrin Fischer 2022-10-07 14:30:32 UTC
Created attachment 141510 [details] [review]
Bug 31569: Add filters

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 22 Katrin Fischer 2022-10-07 14:30:36 UTC
Created attachment 141511 [details] [review]
Bug 31569: (QA follow-up) Remove additional spaces from ISBN/ISSN

Before this change, the ISBN woudl display like: ( isbn )
This patch removes the additional spaces so the display is
the same as without this patch set on current master: (isbn)

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 23 Tomás Cohen Arazi 2022-10-17 11:28:57 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 24 Tomás Cohen Arazi 2022-10-17 21:01:29 UTC
Created attachment 142031 [details] [review]
Bug 31569: (QA follow-up) Add missing entries in schema

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>