Bug 31906 - Managed by on basket summary page is misaligned
Summary: Managed by on basket summary page is misaligned
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-21 11:56 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31906: Fix alignment of managed by button on basket summary page (3.19 KB, patch)
2022-10-24 16:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31906: Fix alignment of managed by button on basket summary page (3.19 KB, patch)
2022-10-24 16:29 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot showing labels (47.28 KB, image/png)
2022-10-24 18:48 UTC, Katrin Fischer
Details
Bug 31906: Fix alignment of managed by button on basket summary page (3.19 KB, patch)
2022-10-24 18:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-21 11:56:43 UTC

    
Comment 1 Katrin Fischer 2022-10-21 11:57:47 UTC
At the top part of the basket summary page the "managed by" is misaligned.

Also: bug 31837 added page-section to the order parts - should we also do the same for the information on top?
Comment 2 Owen Leonard 2022-10-24 16:22:32 UTC
Created attachment 142529 [details] [review]
Bug 31906: Fix alignment of managed by button on basket summary page

This patch makes a couple of changes to CSS which affect, globally, the
alignment of labels in forms. With lables corresponding to text areas or
other multi-line controls, the label should be aligned with the top of
the control.

This patch also changes the inline style attribute on the control that
lets a user add an additional manager to a basket in acquisitions. It
requires an update to work with the new default form layout.

To test, apply the patch and go to Acquisitions -> Vendor -> Baskets.

 - View the details of a basket.
 - You should see a line labeled "Manged by." The label should be
   top-aligned to match the "Add user" link next to it.
 - Test that the link works correctly and that the layout is correct
   after adding additional managers.

View other forms in the staff interface to confirm that the changes
work correctly and have not broken layout anywhere else. For instance,
in the patron add/edit form, the "Contact note," "OPAC note," labels etc.
Comment 3 Owen Leonard 2022-10-24 16:29:42 UTC
Created attachment 142531 [details] [review]
Bug 31906: Fix alignment of managed by button on basket summary page

This patch makes a couple of changes to CSS which affect, globally, the
alignment of labels in forms. With lables corresponding to text areas or
other multi-line controls, the label should be aligned with the top of
the control.

This patch also changes the inline style attribute on the control that
lets a user add an additional manager to a basket in acquisitions. It
requires an update to work with the new default form layout.

To test, apply the patch and go to Acquisitions -> Vendor -> Baskets.

 - View the details of a basket.
 - You should see a line labeled "Manged by." The label should be
   top-aligned to match the "Add user" link next to it.
 - Test that the link works correctly and that the layout is correct
   after adding additional managers.

View other forms in the staff interface to confirm that the changes
work correctly and have not broken layout anywhere else. For instance,
in the patron add/edit form, the "Contact note," "OPAC note," labels etc.
Comment 4 Katrin Fischer 2022-10-24 18:48:06 UTC
Created attachment 142551 [details]
Screenshot showing labels

Two small things:
* it looks like the label aligns to the bottom here, but it feels like it should be the same line as 'null koha' here (null case filed separately as bug 31959)
* Labels in the second column are already wrapping now and there is not a lot of space on the left column either. They don't extend for longer translations. Can we make this flexible or give some extra space here?
Comment 5 Katrin Fischer 2022-10-24 18:51:01 UTC
Hm, only 1 small thing: I realized I had typoed the yarn build. The label is now correct. Leaving second comment about more flexible layout for contemplation.
Comment 6 Katrin Fischer 2022-10-24 18:51:49 UTC
Created attachment 142552 [details] [review]
Bug 31906: Fix alignment of managed by button on basket summary page

This patch makes a couple of changes to CSS which affect, globally, the
alignment of labels in forms. With lables corresponding to text areas or
other multi-line controls, the label should be aligned with the top of
the control.

This patch also changes the inline style attribute on the control that
lets a user add an additional manager to a basket in acquisitions. It
requires an update to work with the new default form layout.

To test, apply the patch and go to Acquisitions -> Vendor -> Baskets.

 - View the details of a basket.
 - You should see a line labeled "Manged by." The label should be
   top-aligned to match the "Add user" link next to it.
 - Test that the link works correctly and that the layout is correct
   after adding additional managers.

View other forms in the staff interface to confirm that the changes
work correctly and have not broken layout anywhere else. For instance,
in the patron add/edit form, the "Contact note," "OPAC note," labels etc.
Comment 7 Tomás Cohen Arazi 2022-10-24 20:23:24 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!