When receiving a shipment, the list of pending and then received orders (table below the first one) requires the treatment with page-section classes.
Created attachment 142217 [details] [review] Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div.
Created attachment 142232 [details] [review] Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind <david@davidnind.com>
This one is confusing to me... it fixes the basket page, but it looks like I intended to file for parcels?
Ok, I see waht happened here... this is actually the fix for bug 31820 :P I'll switch things around a bit, so we also have a bug for the receive page.
Hi Lucas, compared this to some other pages and it looks like the h2/h3 are usually inside the page-section. Could we move them here as well? The h1 appears to always be outside. For comparison see patron form, patron details and patron import.
Sorry, for the confusion here Cait. I'll move these patches over to Bug 31820 and address the heading problem.
(In reply to Lucas Gass from comment #6) > Sorry, for the confusion here Cait. I'll move these patches over to Bug > 31820 and address the heading problem. Please don't move, I fixed the descriptions and the patch is ok here now!
Created attachment 142459 [details] [review] Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 142460 [details] [review] Bug 31837: (follow-up) Move page-section to include h2 headings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This template needs an indentation cleanup.. rather confusing as it stands. More directly related.. I think perhaps each of the top columns should also be carded.. but that's not immediately trivial, as I just found.. so I'll open a new bug for that one.. Finally.. there's also a bug around the 'Managed by'.. the 'add user' is on the wrong side of the label.
Working on a follow-up
Created attachment 142473 [details] [review] Bug 31837: Add page-section class to tables on basket.tt This patch adds the page-section class to the orders and cancelled orders tables. To test: 1. Have a vendor, basket, and create an order. 2. Go look at the table on basket.tt and make sure the orders table looks good. 3. Cancel some orders and look at the cancelled order table, make sure it also looks good. Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 142474 [details] [review] Bug 31837: (follow-up) Move page-section to include h2 headings Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
OK.. I gave up.. this template is a real mess. So.. passing QA as is and I'll raise a new bug for going through the template
Pushed to master for 22.11. Nice work everyone, thanks!