These admin pages need a page-section div to be added: additional-fields.tt aqbudgets.tt auth_subfields_structure.tt auth_tag_structure.tt authtypes.tt biblio_framework.tt checkmarc.tt classsources.tt currency.tt edi_accounts.tt edi_ean_accounts.tt items_search_fields.tt koha2marclinks.tt marc-overlay-rules.tt marc_subfields_structure.tt marctagstructure.tt matching-rules.tt oai_sets.tt smtp_servers.tt z3950servers.tt
Created attachment 142666 [details] [review] Bug 31986: Add page-section to various administration pages This patch adds a page-section div to some administration pages in order to provide a consistent structure visual contrast. The following pages are modified: Additional fields Funds Authority types Authority types -> MARC tag structure Authority types -> MARC tag structure -> Subfields MARC bibliographic framework MARC bibliographic framework -> MARC tag structure MARC bibliographic framework -> MARC tag structure -> Subfields MARC Bibliographic framework test Classification configuration Currencies and exchange rates EDI accounts Library EANs Item search fields Koha to MARC mapping Record overlay rules Record matching rules OAI sets configuration SMTP servers Z39.50/SRU servers To test, view each page to confirm that the page-section div visibly delineates the main content area.
Created attachment 142671 [details] [review] Bug 31986: Add page-section to various administration pages This patch adds a page-section div to some administration pages in order to provide a consistent structure visual contrast. The following pages are modified: Additional fields Funds Authority types Authority types -> MARC tag structure Authority types -> MARC tag structure -> Subfields MARC bibliographic framework MARC bibliographic framework -> MARC tag structure MARC bibliographic framework -> MARC tag structure -> Subfields MARC Bibliographic framework test Classification configuration Currencies and exchange rates EDI accounts Library EANs Item search fields Koha to MARC mapping Record overlay rules Record matching rules OAI sets configuration SMTP servers Z39.50/SRU servers To test, view each page to confirm that the page-section div visibly delineates the main content area. Signed-off-by: David Nind <david@davidnind.com>
I've signed off as the mentioned pages now have the page-sections. Some notes and observations - may need separate bugs if required/or have not yet been created. Needs div class: - OIA sets configuration > [OIA set] > Actions > Define mappings (http://127.0.0.1:8081/cgi-bin/koha/admin/oai_set_mappings.pl?id=1) Misaligned add and modify forms: - Authority types > New authority type (http://127.0.0.1:8081/cgi-bin/koha/admin/authtypes.pl?op=add_form) - Authority types > Modify authority type (http://127.0.0.1:8081/cgi-bin/koha/admin/authtypes.pl?op=add_form&authtypecode=GEOGR_NAME) - Add/modify forms in general: Submit / Cancel buttons area at bottom of form has extra white space before buttons, for example: New Z39.50 server Other: - Currencies and exchange rates: DataTables look is different from the standard look - EDI accounts: enable the EDIFACT system preference - Item search fields: first add works OK, trying to add another 'New search field' results in a blank page (http://127.0.0.1:8081/cgi-bin/koha/admin/items_search_fields.pl)
Hi Owen, could you have a look at these again for possible follow-ups here? * h1 should not be inside page section for currencies * Item fields has 2 h1, which makes the heading inside the page section bigger than the first one * OAI sets: 3rd step, defining mappings is missing page section: admin/oai_set_mappings.pl?id=1 * Share contents with Hea: we usually put the h2+ now inside the page-section, but there is a lot of additional text on this screen between form and headings. Should these also be blocks? Some more notes, happy to file new bugs if they make some sense: * auth_subfields_structure.pl - The submit/cancel are in a separate 'block', I have also seen this on other pages. Should we make this a general rule for our style guide? * The save buttons for the 'new' actions on classification configuration are not 'centered'. There is a lot more white space to the top than to the bottom. Maybe a mark-up problem? Same for: admin/edi_accounts.pl?op=acct_form ... But: branch_transfer_limits.pl has no additional space on top and bottom. Maybe a 'part 2' bug for this one or did I miss the single bugs? * Missing - or maybe in another bug? ** Jobs ** circulation rules ** Patron attributes ** Cities ** Patron restrictions ** Debit types ** Credit types ** Cash registers ** Plugins
*** Bug 31926 has been marked as a duplicate of this bug. ***
(In reply to Katrin Fischer from comment #4) > * h1 should not be inside page section for currencies I didn't change this in my patch because presents a problem which needs to be addressed globally. Sometimes, as on this page, the H1 is inside a <legend>: <legend> <h1> <span>New currency</span> I want to look at how consistent we are with this structure and try to address it in another patch. item_search_fields.tt is a similar issue. > * auth_subfields_structure.pl - The submit/cancel are in a separate 'block', > I have also seen this on other pages. Should we make this a general rule for > our style guide? This will be addressed in another bug, and should probably be covered in the style guide. > * The save buttons for the 'new' actions on classification configuration are > not 'centered'. There is a lot more white space to the top than to the > bottom. This is essentially the same problem as the previous one. > Maybe a 'part 2' bug for this one or did I miss the single bugs? This patch wasn't comprehensive, so more work remains to be done.
> > * auth_subfields_structure.pl - The submit/cancel are in a separate 'block', > > I have also seen this on other pages. Should we make this a general rule for > > our style guide? See Bug 32022
Owen's comments all make good sense. I filed for the remaining admin pages: Bug 32028 - Add page-section to various administration pages (part 2)
Created attachment 142735 [details] [review] Bug 31986: Add page-section to various administration pages This patch adds a page-section div to some administration pages in order to provide a consistent structure visual contrast. The following pages are modified: Additional fields Funds Authority types Authority types -> MARC tag structure Authority types -> MARC tag structure -> Subfields MARC bibliographic framework MARC bibliographic framework -> MARC tag structure MARC bibliographic framework -> MARC tag structure -> Subfields MARC Bibliographic framework test Classification configuration Currencies and exchange rates EDI accounts Library EANs Item search fields Koha to MARC mapping Record overlay rules Record matching rules OAI sets configuration SMTP servers Z39.50/SRU servers To test, view each page to confirm that the page-section div visibly delineates the main content area. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!