A lot of changes were made the the style of sidebar forms (usually filter forms in an <aside> which I don't think were necessary to keep with the new design. I think it would be better to keep (and tweak) the old CSS.
Created attachment 142673 [details] [review] Bug 31991: Restore style of sidebar forms This patch restores the aside{} section of staff-global.scss from before the staff redesign and makes some tweaks to make it consisten with the redesign. The goal is to make the spacing of the form more compact but still readable, and to correct some layout inconsistencies. The patch also modifies the order filter form to fix the layout of some checkboxes. To test, apply the patch and rebuild the staff interface CSS. Test various pages with sidebar forms to confirm that the form looks readable and usable. For example: - Patrons - Acquisitions -> Invoices - Tools -> Tags - Serials -> Subscription search results - Overdues - Holds to pull
Created attachment 142684 [details] [review] Bug 31991: Restore style of sidebar forms This patch restores the aside{} section of staff-global.scss from before the staff redesign and makes some tweaks to make it consisten with the redesign. The goal is to make the spacing of the form more compact but still readable, and to correct some layout inconsistencies. The patch also modifies the order filter form to fix the layout of some checkboxes. To test, apply the patch and rebuild the staff interface CSS. Test various pages with sidebar forms to confirm that the form looks readable and usable. For example: - Patrons - Acquisitions -> Invoices - Tools -> Tags - Serials -> Subscription search results - Overdues - Holds to pull Signed-off-by: David Nind <david@davidnind.com>
Not sure about these ones, as I think they are outside the scope of this bug. Happy to add separate bugs for these to fix up the form inconsistencies. 1. Acquisitions > Suggestions management: has expandable sections that open when clicked with the form for each option - there is no space between the last field and the button(s), there is no space before the left margin for the "Filter by:" heading. 2. Administration > Budgets > All funds: "Filters" link outside the filter box, here is no space between the last field and the button(s), grey space after before the other sidebar options. 3. Tools > Tags: apply filters button has no colour 4. Tools > News: the heading "Filter" is outside the box with the white background, there is no "Action" button - but selections work, however, there is a grey background line after the end of the filter and the other sidebar options. 5. Tools > Pages: same as for Tools > News. 6. Reports > Use saved: Gray space before buttons, no white space after. Others checked: - Acquisitions > Late orders: OK.
Created attachment 142685 [details] [review] k
Created attachment 142686 [details] [review] Bug 31991: Restore style of sidebar forms This patch restores the aside{} section of staff-global.scss from before the staff redesign and makes some tweaks to make it consisten with the redesign. The goal is to make the spacing of the form more compact but still readable, and to correct some layout inconsistencies. The patch also modifies the order filter form to fix the layout of some checkboxes. To test, apply the patch and rebuild the staff interface CSS. Test various pages with sidebar forms to confirm that the form looks readable and usable. For example: - Patrons - Acquisitions -> Invoices - Tools -> Tags - Serials -> Subscription search results - Overdues - Holds to pull Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!