Bug 32023 - Remove horizontal line from OPAC navigation for CMS pages
Summary: Remove horizontal line from OPAC navigation for CMS pages
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 15326
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-27 18:21 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32023: Remove hr in OpacNav for CMS pages (1.52 KB, patch)
2023-02-06 21:46 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32023: Remove hr in OpacNav for CMS pages (1.59 KB, patch)
2023-02-06 22:02 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 32023: Remove hr in OpacNav for CMS pages (1.65 KB, patch)
2023-02-07 13:08 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-10-27 18:21:17 UTC
In a page created with the new Pages tool, there is a <hr> above the OpacNav block. This hr is not there on other OPAC pages.

To test:
1. Go to Tools > Pages > New entry
2. Create a page and save
3. Copy the OPAC link
4. Go to Tools > HTML customizations > New entry
5. Create an OpacNav entry with the link to the page
6. Go to the OPAC main page
   --> Notice how the left navigation section looks
7. Click on the link on the left to go to the page
   --> an horizontal line appears above OpacNav
Comment 1 Katrin Fischer 2023-02-06 21:46:22 UTC
Created attachment 146298 [details] [review]
Bug 32023: Remove hr in OpacNav for CMS pages

In a page created with the new Pages tool, there is a
<hr> above the OpacNav block.
This hr is not present on other OPAC pages and is
removed by this patch.

To test:
1. Go to Tools > Pages > New entry
2. Create a page and save
3. Copy the OPAC link
4. Go to Tools > HTML customizations > New entry
5. Create an OpacNav entry with the link to the page
6. Go to the OPAC main page
   --> Notice how the left navigation section looks
7. Click on the link on the left to go to the page
   --> an horizontal line appears above OpacNav
8. Apply patch
9. Repeat test - the horizontal line should be gone now
Comment 2 Caroline Cyr La Rose 2023-02-06 22:02:22 UTC
Created attachment 146300 [details] [review]
Bug 32023: Remove hr in OpacNav for CMS pages

In a page created with the new Pages tool, there is a
<hr> above the OpacNav block.
This hr is not present on other OPAC pages and is
removed by this patch.

To test:
1. Go to Tools > Pages > New entry
2. Create a page and save
3. Copy the OPAC link
4. Go to Tools > HTML customizations > New entry
5. Create an OpacNav entry with the link to the page
6. Go to the OPAC main page
   --> Notice how the left navigation section looks
7. Click on the link on the left to go to the page
   --> an horizontal line appears above OpacNav
8. Apply patch
9. Repeat test - the horizontal line should be gone now

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Caroline Cyr La Rose 2023-02-06 22:04:46 UTC
Thanks Katrin!
Comment 4 Martin Renvoize 2023-02-07 13:08:37 UTC
Created attachment 146321 [details] [review]
Bug 32023: Remove hr in OpacNav for CMS pages

In a page created with the new Pages tool, there is a
<hr> above the OpacNav block.
This hr is not present on other OPAC pages and is
removed by this patch.

To test:
1. Go to Tools > Pages > New entry
2. Create a page and save
3. Copy the OPAC link
4. Go to Tools > HTML customizations > New entry
5. Create an OpacNav entry with the link to the page
6. Go to the OPAC main page
   --> Notice how the left navigation section looks
7. Click on the link on the left to go to the page
   --> an horizontal line appears above OpacNav
8. Apply patch
9. Repeat test - the horizontal line should be gone now

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-02-07 13:09:12 UTC
That HR was weird.. nice fix.

PQA
Comment 6 Tomás Cohen Arazi 2023-02-07 13:51:03 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-02-08 16:37:38 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.