In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing.
Created attachment 142752 [details] [review] Bug 32029: Automatic item modifications by age add biblio table In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing. Test plan : 1) Create an automatic item modifications by age with a condition on a column of biblio table 2) Create a record and item matching the rule 3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v => Check only matching items are impacted
without packages 1.Created a "Rules for automatically changing articles by age" with condition biblioitems.biblioitemnumber=7(new article) and substitutions=REF. 2.Created a record with biblioitemnumber=7 and substitutions=BK. 3.In terminal:Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v. Answer:There is no item to modify. With packages 1.Created a "Rules for automatic item modifications by age" with condition biblioitems.biblioitemnumber=8(new item) and substitutions=REF. 2.Created a record with biblioitemnumber=8 and substitutions=BK. 3.In terminal:Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v. Answer:There is no item to modify. Packages do not change anything.
Hi, Thanks for testing. You need to create a rule with a condition on biblio table, for example biblio.title. > without packages You mean patches I bet.
Created attachment 151073 [details] [review] Bug 32029: Automatic item modifications by age add biblio table In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing. Test plan : 1) Create an automatic item modifications by age with a condition on a column of biblio table 2) Create a record and item matching the rule 3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v => Check only matching items are impacted Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Please add some tests to t/db_dependent/Items/AutomaticItemModificationByAge.t
Created attachment 159574 [details] [review] Bug 32029: Automatic item modifications by age add biblio table In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing. Test plan : 1) Create an automatic item modifications by age with a condition on a column of biblio table 2) Create a record and item matching the rule 3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v => Check only matching items are impacted Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Created attachment 159575 [details] [review] Bug 32029: (follow-up) unit test
(In reply to Marcel de Rooy from comment #5) > Please add some tests to > t/db_dependent/Items/AutomaticItemModificationByAge.t Here it is :D
Created attachment 160977 [details] [review] Bug 32029: (follow-up) unit test Signed-off-by: matthias le gac <matthias.le-gac@inlibro.com>
All files are failing tidiness check.
Created attachment 161053 [details] [review] Bug 32029: Automatic item modifications by age add biblio table In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing. Test plan : 1) Create an automatic item modifications by age with a condition on a column of biblio table 2) Create a record and item matching the rule 3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v => Check only matching items are impacted Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Created attachment 161054 [details] [review] Bug 32029: (follow-up) unit test Signed-off-by: matthias le gac <matthias.le-gac@inlibro.com>
Created attachment 161055 [details] [review] Bug 32029: (follow-up) tidy
Tidy test is now OK in KTD
Created attachment 161489 [details] [review] Bug 32029: Automatic item modifications by age add biblio table In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing. Test plan : 1) Create an automatic item modifications by age with a condition on a column of biblio table 2) Create a record and item matching the rule 3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v => Check only matching items are impacted Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Bug 32029: (follow-up) unit test Signed-off-by: matthias le gac <matthias.le-gac@inlibro.com> Bug 32029: (follow-up) tidy Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
If possible, no separate tidy patches please.
Maybe bordering on enh? ;)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03
It caused a failure, see bug 36010
(In reply to Fridolin Somers from comment #19) > Pushed to 23.11.x for 23.11.03 Oh strange it is missing in this release. I push for 23.11.04
Backported to 23.05.x for upcoming 23.05.10