Bug 32029 - Automatic item modifications by age missing biblio table
Summary: Automatic item modifications by age missing biblio table
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 36010
  Show dependency treegraph
 
Reported: 2022-10-28 07:59 UTC by Fridolin Somers
Modified: 2024-12-23 08:07 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:


Attachments
Bug 32029: Automatic item modifications by age add biblio table (3.05 KB, patch)
2022-10-28 08:02 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 32029: Automatic item modifications by age add biblio table (3.10 KB, patch)
2023-05-11 12:46 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 32029: Automatic item modifications by age add biblio table (3.10 KB, patch)
2023-12-05 06:10 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 32029: (follow-up) unit test (2.29 KB, patch)
2023-12-05 06:10 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 32029: (follow-up) unit test (2.34 KB, patch)
2024-01-12 15:01 UTC, Matthias Le Gac
Details | Diff | Splinter Review
Bug 32029: Automatic item modifications by age add biblio table (3.10 KB, patch)
2024-01-16 08:47 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 32029: (follow-up) unit test (2.34 KB, patch)
2024-01-16 08:47 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 32029: (follow-up) tidy (7.21 KB, patch)
2024-01-16 08:48 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 32029: Automatic item modifications by age add biblio table (8.83 KB, patch)
2024-01-26 08:15 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2022-10-28 07:59:12 UTC
In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing.
Comment 1 Fridolin Somers 2022-10-28 08:02:44 UTC
Created attachment 142752 [details] [review]
Bug 32029: Automatic item modifications by age add biblio table

In automatic item modifications by age missing,
conditions can be on columns of tables items or biblioitems.
Table biblio is missing.

Test plan :
1) Create an automatic item modifications by age with a condition on a column of biblio table
2) Create a record and item matching the rule
3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v
=> Check only matching items are impacted
Comment 2 Marius 2023-01-16 14:24:03 UTC
without packages
1.Created a "Rules for automatically changing articles by age" with condition biblioitems.biblioitemnumber=7(new article) and substitutions=REF.
2.Created a record with biblioitemnumber=7 and substitutions=BK.
3.In terminal:Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v.
Answer:There is no item to modify.

With packages
1.Created a "Rules for automatic item modifications by age" with condition biblioitems.biblioitemnumber=8(new item) and substitutions=REF.
2.Created a record with biblioitemnumber=8 and substitutions=BK.
3.In terminal:Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v.
Answer:There is no item to modify.

Packages do not change anything.
Comment 3 Fridolin Somers 2023-01-18 01:22:00 UTC
Hi,

Thanks for testing.

You need to create a rule with a condition on biblio table, for example biblio.title.

> without packages
You mean patches I bet.
Comment 4 Philip Orr 2023-05-11 12:46:33 UTC
Created attachment 151073 [details] [review]
Bug 32029: Automatic item modifications by age add biblio table

In automatic item modifications by age missing,
conditions can be on columns of tables items or biblioitems.
Table biblio is missing.

Test plan :
1) Create an automatic item modifications by age with a condition on a column of biblio table
2) Create a record and item matching the rule
3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v
=> Check only matching items are impacted

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 5 Marcel de Rooy 2023-05-17 14:17:54 UTC
Please add some tests to t/db_dependent/Items/AutomaticItemModificationByAge.t
Comment 6 Fridolin Somers 2023-12-05 06:10:15 UTC
Created attachment 159574 [details] [review]
Bug 32029: Automatic item modifications by age add biblio table

In automatic item modifications by age missing,
conditions can be on columns of tables items or biblioitems.
Table biblio is missing.

Test plan :
1) Create an automatic item modifications by age with a condition on a column of biblio table
2) Create a record and item matching the rule
3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v
=> Check only matching items are impacted

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 7 Fridolin Somers 2023-12-05 06:10:27 UTC
Created attachment 159575 [details] [review]
Bug 32029: (follow-up) unit test
Comment 8 Fridolin Somers 2023-12-05 06:10:53 UTC
(In reply to Marcel de Rooy from comment #5)
> Please add some tests to
> t/db_dependent/Items/AutomaticItemModificationByAge.t

Here it is :D
Comment 9 Matthias Le Gac 2024-01-12 15:01:31 UTC
Created attachment 160977 [details] [review]
Bug 32029: (follow-up) unit test

Signed-off-by: matthias le gac <matthias.le-gac@inlibro.com>
Comment 10 Jonathan Druart 2024-01-12 15:28:01 UTC
All files are failing tidiness check.
Comment 11 Fridolin Somers 2024-01-16 08:47:39 UTC
Created attachment 161053 [details] [review]
Bug 32029: Automatic item modifications by age add biblio table

In automatic item modifications by age missing,
conditions can be on columns of tables items or biblioitems.
Table biblio is missing.

Test plan :
1) Create an automatic item modifications by age with a condition on a column of biblio table
2) Create a record and item matching the rule
3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v
=> Check only matching items are impacted

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 12 Fridolin Somers 2024-01-16 08:47:54 UTC
Created attachment 161054 [details] [review]
Bug 32029: (follow-up) unit test

Signed-off-by: matthias le gac <matthias.le-gac@inlibro.com>
Comment 13 Fridolin Somers 2024-01-16 08:48:05 UTC
Created attachment 161055 [details] [review]
Bug 32029: (follow-up) tidy
Comment 14 Fridolin Somers 2024-01-16 09:07:02 UTC
Tidy test is now OK in KTD
Comment 15 Marcel de Rooy 2024-01-26 08:15:08 UTC
Created attachment 161489 [details] [review]
Bug 32029: Automatic item modifications by age add biblio table

In automatic item modifications by age missing,
conditions can be on columns of tables items or biblioitems.
Table biblio is missing.

Test plan :
1) Create an automatic item modifications by age with a condition on a column of biblio table
2) Create a record and item matching the rule
3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v
=> Check only matching items are impacted

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>

Bug 32029: (follow-up) unit test

Signed-off-by: matthias le gac <matthias.le-gac@inlibro.com>

Bug 32029: (follow-up) tidy

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 16 Marcel de Rooy 2024-01-26 08:16:16 UTC
If possible, no separate tidy patches please.
Comment 17 Katrin Fischer 2024-01-26 13:27:15 UTC
Maybe bordering on enh? ;)
Comment 18 Katrin Fischer 2024-01-26 14:17:20 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 19 Fridolin Somers 2024-01-31 13:06:37 UTC
Pushed to 23.11.x for 23.11.03
Comment 20 Jonathan Druart 2024-02-07 07:26:24 UTC
It caused a failure, see bug 36010
Comment 21 Fridolin Somers 2024-03-11 10:17:23 UTC
(In reply to Fridolin Somers from comment #19)
> Pushed to 23.11.x for 23.11.03

Oh strange it is missing in this release.
I push for 23.11.04
Comment 22 Lucas Gass (lukeg) 2024-03-19 19:51:11 UTC
Backported to 23.05.x for upcoming 23.05.10