koha_1 | # Failed test 'ToggleNewStatus: conditions on biblio' koha_1 | # at t/db_dependent/Items/AutomaticItemModificationByAge.t line 356. koha_1 | # got: 'agefield_new_value' koha_1 | # expected: 'new_updated_value_biblio' koha_1 | # Looks like you failed 1 test of 20. Koha_Master_My8/1279 First failure from this one that has been pushed recently. I don't recreate locally (even using MySQL8). Maybe something to do with the age comparison if the node is slow?
It is actually failing consistently, see https://jenkins.koha-community.org/job/Koha_Master_My8/1274/ https://jenkins.koha-community.org/job/Koha_Master_My8/1275/ https://jenkins.koha-community.org/job/Koha_Master_My8/1276/ https://jenkins.koha-community.org/job/Koha_Master_My8/1277/ https://jenkins.koha-community.org/job/Koha_Master_My8/1278/ https://jenkins.koha-community.org/job/Koha_Master_My8/1279/
Hmm, I couldn't get this to fail locally.. strange.
I'll try to fix ASAP
(In reply to Martin Renvoize from comment #2) > Hmm, I couldn't get this to fail locally.. strange. Same. Is it possible the koha to marc mapping on 245$h does not exists ? Since biblio.medium is a recent column.
Created attachment 161889 [details] [review] Bug 36010: Fix Items/AutomaticItemModificationByAge.t failing since Bug 32029 UT is failing in jenkins. Change to use biblio.copyrightdate instead of bilio.medium Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t
biblio.copyrightdate is a more ancient column. I hope it fixes.
It's failing on MySQL8 only.
(In reply to Jonathan Druart from comment #7) > It's failing on MySQL8 only. Forget that, I don't recreate locally either!
Given we're all failing to get this one to fail locally, I'm tempted to say we push it and see what Jenkins does. It's really odd
I don't really understand how you are trying to fix the problem. Why would it come from this specific field?
Well, recreating what Jenkins does is always a good thing. So, it's failing: koha-mysql kohadev -e "DROP DATABASE koha_kohadev" || true mysql -h db -u koha_kohadev -ppassword -e"CREATE DATABASE koha_kohadev" flush_memcached sudo service apache2 restart sudo service koha-common restart koha-mysql kohadev < /kohadevbox/misc4dev/data/sql/marc21/dump_kohadev_v19.11.00.sql sudo koha-shell kohadev -p -c 'perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl' koha-mysql kohadev -e 'UPDATE systempreferences SET value="21.1100000" WHERE variable="version"' sudo koha-shell kohadev -p -c 'perl /kohadevbox/koha/installer/data/mysql/updatedatabase.pl' Then: prove t/db_dependent/Items/AutomaticItemModificationByAge.tt/db_dependent/Items/AutomaticItemModificationByAge.t .. 18/20 # Failed test 'ToggleNewStatus: conditions on biblio'# at t/db_dependent/Items/AutomaticItemModificationByAge.t line 356.# got: 'agefield_new_value'# expected: 'new_updated_value_biblio'# Looks like you failed 1 test of 20. t/db_dependent/Items/AutomaticItemModificationByAge.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/20 subtests Test Summary Report ------------------- t/db_dependent/Items/AutomaticItemModificationByAge.t (Wstat: 256 Tests: 20 Failed: 1) Failed test: 19 Non-zero exit status: 1 Files=1, Tests=20, 3 wallclock secs ( 0.02 usr 0.01 sys + 1.84 cusr 0.26 csys = 2.13 CPU) Result: FAIL
Applying the patch and it's passing...? Signing off
Created attachment 161959 [details] [review] Bug 36010: Fix Items/AutomaticItemModificationByAge.t failing since Bug 32029 UT is failing in jenkins. Change to use biblio.copyrightdate instead of bilio.medium Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 162597 [details] [review] Bug 36010: Fix Items/AutomaticItemModificationByAge.t failing since Bug 32029 UT is failing in jenkins. Change to use biblio.copyrightdate instead of bilio.medium Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Well done Jonathan for finding a way to reproduce :D . It can be reproduced even with MariaDB (11.3) in my case. (In reply to Jonathan Druart from comment #10) > I don't really understand how you are trying to fix the problem. Why would > it come from this specific field? Me neither ^^" Thanks Fridolin for good intuition that allows to dodge the bug. There is likely a real bug underneath. But since it's not obvious and until it's seen in real usage, there no need to bother more that fixing the test here. Works, QA script happy, code looks good, passing QA :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.04
Backported to 23.05.x for upcoming 23.05.10