Bug 32042 - Add page-section to catalog's item detail view
Summary: Add page-section to catalog's item detail view
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952 32193
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-30 09:28 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32042: Add page-section to catalog's item detail view (63.50 KB, patch)
2022-11-14 17:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32042: Add page-section to catalog's item detail view (63.56 KB, patch)
2022-11-14 17:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32042: Add page-section to catalog's item detail view (63.56 KB, patch)
2022-11-14 17:45 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-30 09:28:31 UTC
The items tab you reach from the catalog detail page needs some page-sectioning.
Comment 1 Martin Renvoize 2022-11-10 10:31:35 UTC
OK, I tried to take a look at this one and found the template insanely confusing... I gave up :(
Comment 2 Katrin Fischer 2022-11-10 16:30:25 UTC
Ok. I now tried too and it's really confusing. Help?
Comment 3 Owen Leonard 2022-11-14 17:14:26 UTC
Created attachment 143847 [details] [review]
Bug 32042: Add page-section to catalog's item detail view

This patch adds a couple of .page-section divs to the item detail view
in the catalog. A "clearfix" class is also added in order to make sure
the sections don't overlap.

To test, apply the patch and locate a bibliographic record in the
catalog.

- In the sidebar menu of the bibliographic detail view, click "Items."
- On the item detail page, confirm that the information is displayed
  well.
Comment 4 Katrin Fischer 2022-11-14 17:29:49 UTC
It looks so easy now... :(
Comment 5 Katrin Fischer 2022-11-14 17:30:25 UTC
Created attachment 143851 [details] [review]
Bug 32042: Add page-section to catalog's item detail view

This patch adds a couple of .page-section divs to the item detail view
in the catalog. A "clearfix" class is also added in order to make sure
the sections don't overlap.

To test, apply the patch and locate a bibliographic record in the
catalog.

- In the sidebar menu of the bibliographic detail view, click "Items."
- On the item detail page, confirm that the information is displayed
  well.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2022-11-14 17:45:12 UTC
Created attachment 143852 [details] [review]
Bug 32042: Add page-section to catalog's item detail view

This patch adds a couple of .page-section divs to the item detail view
in the catalog. A "clearfix" class is also added in order to make sure
the sections don't overlap.

To test, apply the patch and locate a bibliographic record in the
catalog.

- In the sidebar menu of the bibliographic detail view, click "Items."
- On the item detail page, confirm that the information is displayed
  well.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2022-11-14 17:46:00 UTC
Again, an easy fix. PQA.
Comment 8 Tomás Cohen Arazi 2022-11-16 12:39:34 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!