Bug 32193 - Reindent item details template
Summary: Reindent item details template
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/catalogue/moredetail.pl...
Keywords:
Depends on:
Blocks: 32042
  Show dependency treegraph
 
Reported: 2022-11-14 16:10 UTC by Owen Leonard
Modified: 2022-11-16 12:40 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32193: Reindent item details template (55.35 KB, patch)
2022-11-14 16:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32193: (follow-up) Add markup comments (3.95 KB, patch)
2022-11-14 16:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32193: (follow-up) Add markup comments (4.01 KB, patch)
2022-11-14 17:21 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-14 16:10:47 UTC
I propose to reformat the item details template in the staff interface (moredetail.tt) so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2022-11-14 16:37:39 UTC
Created attachment 143844 [details] [review]
Bug 32193: Reindent item details template

This patch performs general template cleanup to the lists template:
Make indentation consistent, replace tabs with spaces, and trim trailing
whitespace.

To test, apply the patch and confirm that the layout of the page is
unchanged. Test the various operations on the page:

- Setting lost status
- Setting damaged status
- Setting withdrawn status
- Setting local holds priority status
- Adding a public or non-public note
Comment 2 Owen Leonard 2022-11-14 16:37:44 UTC
Created attachment 143845 [details] [review]
Bug 32193: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 Katrin Fischer 2022-11-14 17:21:25 UTC
Created attachment 143848 [details] [review]
Bug 32193: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-16 12:40:26 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!