Bug 32051 - Rename 'Library' page link to 'Contact' for single library
Summary: Rename 'Library' page link to 'Contact' for single library
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Marcel de Rooy
QA Contact: Paul Derscheid
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-31 12:21 UTC by Marcel de Rooy
Modified: 2025-05-26 14:57 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
If there is only one library marked as 'public' in the library configuration page, the navigation item on the OPAC will change from 'Libraries' to 'Contact'.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 32051: Rename Library to Contact for one public library (4.04 KB, patch)
2025-02-20 09:30 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32051: Rename Library to Contact for one public library (4.06 KB, patch)
2025-02-20 12:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32051: (follow-up) Make the same change to page title (1.00 KB, patch)
2025-02-20 12:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32051: Rename Library to Contact for one public library (4.11 KB, patch)
2025-03-07 10:12 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 32051: (follow-up) Make the same change to page title (1.06 KB, patch)
2025-03-07 10:12 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-10-31 12:21:40 UTC
We are wondering if it would be better/clearer to use a Contact link for a single library. If you list multiple libraries, we should stick to Libraries of course.
Comment 1 Owen Leonard 2024-06-27 21:40:15 UTC
I think it's a good idea. "Libraries" is inaccurate and "Library" seems weird.
Comment 2 Marcel de Rooy 2025-02-20 09:30:39 UTC
Created attachment 178385 [details] [review]
Bug 32051: Rename Library to Contact for one public library

Note:
I am using $rs in the script to prevent searching branches again
unneeded. And pass public_count to opac-library.tt to prevent
another call of Branches.all (for bread crumbs), like masthead
already does btw.

Test plan:
[1] Have two (or more) public libraries.
Verify that you see Libraries on the OPAC home page and that when
clicking Libraries, you first have the library list. Are the bread
crumbs as expected?
Click a library on that list. Do you get its details? Are the bread
crumbs as expected?

[2] Now have only one public library.
Verify that you see Contact on the home page.
And that when clicking Contact you go directly to the library details
without the intermediate library list. Are the bread crumbs still
as expected (with Contact instead of Libraries)?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Owen Leonard 2025-02-20 12:50:50 UTC
Created attachment 178403 [details] [review]
Bug 32051: Rename Library to Contact for one public library

Note:
I am using $rs in the script to prevent searching branches again
unneeded. And pass public_count to opac-library.tt to prevent
another call of Branches.all (for bread crumbs), like masthead
already does btw.

Test plan:
[1] Have two (or more) public libraries.
Verify that you see Libraries on the OPAC home page and that when
clicking Libraries, you first have the library list. Are the bread
crumbs as expected?
Click a library on that list. Do you get its details? Are the bread
crumbs as expected?

[2] Now have only one public library.
Verify that you see Contact on the home page.
And that when clicking Contact you go directly to the library details
without the intermediate library list. Are the bread crumbs still
as expected (with Contact instead of Libraries)?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2025-02-20 12:50:52 UTC
Created attachment 178404 [details] [review]
Bug 32051: (follow-up) Make the same change to page title

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Marcel de Rooy 2025-02-20 13:29:01 UTC
(In reply to Owen Leonard from comment #4)
> Created attachment 178404 [details] [review] [review]
> Bug 32051: (follow-up) Make the same change to page title
> 
> Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Great. Thanks
Comment 6 Paul Derscheid 2025-03-07 10:12:07 UTC
Created attachment 179051 [details] [review]
Bug 32051: Rename Library to Contact for one public library

Note:
I am using $rs in the script to prevent searching branches again
unneeded. And pass public_count to opac-library.tt to prevent
another call of Branches.all (for bread crumbs), like masthead
already does btw.

Test plan:
[1] Have two (or more) public libraries.
Verify that you see Libraries on the OPAC home page and that when
clicking Libraries, you first have the library list. Are the bread
crumbs as expected?
Click a library on that list. Do you get its details? Are the bread
crumbs as expected?

[2] Now have only one public library.
Verify that you see Contact on the home page.
And that when clicking Contact you go directly to the library details
without the intermediate library list. Are the bread crumbs still
as expected (with Contact instead of Libraries)?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 7 Paul Derscheid 2025-03-07 10:12:09 UTC
Created attachment 179052 [details] [review]
Bug 32051: (follow-up) Make the same change to page title

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 8 Katrin Fischer 2025-03-07 17:04:03 UTC
Pushed for 25.05!

Well done everyone, thank you!