Bug 32244 - Add Vue and Cypress to the About Koha > Licenses page
Summary: Add Vue and Cypress to the About Koha > Licenses page
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Aman
QA Contact: Brendan Lawlor
URL:
Keywords: Academy
Depends on: 32030
Blocks: 40468
  Show dependency treegraph
 
Reported: 2022-11-17 09:53 UTC by Martin Renvoize (ashimema)
Modified: 2025-07-31 19:19 UTC (History)
7 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This adds Cypress and Vue to the About Koha > Licenses page.
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 32244: Add vue to the about page (1.16 KB, patch)
2025-07-18 00:35 UTC, Aman
Details | Diff | Splinter Review
Bug 32244: Add Vue license information to the about page (1.29 KB, patch)
2025-07-18 06:44 UTC, David Nind
Details | Diff | Splinter Review
Bug 32244: Add Cypress license information to the about page (1.42 KB, patch)
2025-07-18 06:44 UTC, David Nind
Details | Diff | Splinter Review
Bug 32244: (follow-up) Update Vue.js version and terminology (1.30 KB, patch)
2025-07-22 18:35 UTC, David Nind
Details | Diff | Splinter Review
Bug 32244: Add Vue license information to the about page (1.34 KB, patch)
2025-07-30 15:26 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 32244: Add Cypress license information to the about page (1.47 KB, patch)
2025-07-30 15:26 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 32244: (follow-up) Update Vue.js version and terminology (1.35 KB, patch)
2025-07-30 15:26 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 32244: (QA follow-up) Fixed html formatting and added link for Cypress (1.29 KB, patch)
2025-07-30 15:46 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-11-17 09:53:22 UTC
Now we've introduced Vue in to our software stack, we need to add it to our `About > Licenses` page.
Comment 1 Martin Renvoize (ashimema) 2022-11-17 09:54:21 UTC
This will clearly be a string change...
Comment 2 Aman 2025-07-18 00:35:10 UTC
Created attachment 184267 [details] [review]
Bug 32244: Add vue to the about page

To Test:
1. Apply the patch
2. Within staff client, click More > About > Licences tab
3. Scroll to the bottom to see Vue library url, version and licencing information
Comment 3 David Nind 2025-07-18 06:44:44 UTC
Created attachment 184279 [details] [review]
Bug 32244: Add Vue license information to the about page

This patch updates the license page with information
about Vue.

Test plan:
1. Apply the patch.
2. In the staff interface, go to More > About > Licenses.
3. Scroll down to Vue and note the library name and
   licensing information.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2025-07-18 06:44:47 UTC
Created attachment 184280 [details] [review]
Bug 32244: Add Cypress license information to the about page

This patch updates the license page with information
about Cypress.

Test plan:
1. Apply the patch.
2. In the staff interface, go to More > About > Licenses.
3. Scroll to Cypress and note the library name and
   licensing information.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-07-18 06:50:54 UTC
Thanks for the patch Aman!

I've also added a patch for Cypress (I didn't include the version number), and amended the commit messages so that are consistent.

I'm not sure about the license version for Vue - in the current main, node_modules/view/package.json says 3.5.13, rather than 3.5.4.

I've also added a release note.

David Nind
Comment 6 Aleisha Amohia 2025-07-20 21:48:46 UTC
(In reply to David Nind from comment #5)
> Thanks for the patch Aman!
> 
> I've also added a patch for Cypress (I didn't include the version number),
> and amended the commit messages so that are consistent.

Thanks!

> 
> I'm not sure about the license version for Vue - in the current main,
> node_modules/view/package.json says 3.5.13, rather than 3.5.4.

We got this from package.json under 'dependencies':

    "vue": "^3.5.4",

But can see now the different version in node_modules/vue/package.json

{
  "name": "vue",
  "version": "3.5.13",
}

Is there any guidance on which we should use?

> 
> I've also added a release note.
> 
> David Nind
Comment 7 Jonathan Druart 2025-07-21 07:20:46 UTC
(In reply to Aleisha Amohia from comment #6)
> (In reply to David Nind from comment #5)
> > I'm not sure about the license version for Vue - in the current main,
> > node_modules/view/package.json says 3.5.13, rather than 3.5.4.
> 
> We got this from package.json under 'dependencies':
> 
>     "vue": "^3.5.4",
> 
> But can see now the different version in node_modules/vue/package.json
> 
> {
>   "name": "vue",
>   "version": "3.5.13",
> }
> 
> Is there any guidance on which we should use?

^3.5.4 means minimum 3.5.4. Then 3.5.13 is the version we are using, which will certainly change soon. You should not use the exact version but "VueJS 3" instead I would say.
Comment 8 David Nind 2025-07-22 18:35:44 UTC
Created attachment 184499 [details] [review]
Bug 32244: (follow-up) Update Vue.js version and terminology

Update to show license version as v3, instead of the specific
minor and point release.

Update license to use US American spelling.

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Brendan Lawlor 2025-07-30 15:26:19 UTC
Created attachment 184900 [details] [review]
Bug 32244: Add Vue license information to the about page

This patch updates the license page with information
about Vue.

Test plan:
1. Apply the patch.
2. In the staff interface, go to More > About > Licenses.
3. Scroll down to Vue and note the library name and
   licensing information.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 10 Brendan Lawlor 2025-07-30 15:26:21 UTC
Created attachment 184901 [details] [review]
Bug 32244: Add Cypress license information to the about page

This patch updates the license page with information
about Cypress.

Test plan:
1. Apply the patch.
2. In the staff interface, go to More > About > Licenses.
3. Scroll to Cypress and note the library name and
   licensing information.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 11 Brendan Lawlor 2025-07-30 15:26:24 UTC
Created attachment 184902 [details] [review]
Bug 32244: (follow-up) Update Vue.js version and terminology

Update to show license version as v3, instead of the specific
minor and point release.

Update license to use US American spelling.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 12 Brendan Lawlor 2025-07-30 15:46:26 UTC
Created attachment 184904 [details] [review]
Bug 32244: (QA follow-up) Fixed html formatting and added link for Cypress
Comment 13 Lucas Gass (lukeg) 2025-07-31 18:46:10 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 14 David Nind 2025-07-31 19:19:50 UTC
Thanks Brendan for the QA follow-up!