Now we've introduced Vue in to our software stack, we need to add it to our `About > Licenses` page.
This will clearly be a string change...
Created attachment 184267 [details] [review] Bug 32244: Add vue to the about page To Test: 1. Apply the patch 2. Within staff client, click More > About > Licences tab 3. Scroll to the bottom to see Vue library url, version and licencing information
Created attachment 184279 [details] [review] Bug 32244: Add Vue license information to the about page This patch updates the license page with information about Vue. Test plan: 1. Apply the patch. 2. In the staff interface, go to More > About > Licenses. 3. Scroll down to Vue and note the library name and licensing information. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 184280 [details] [review] Bug 32244: Add Cypress license information to the about page This patch updates the license page with information about Cypress. Test plan: 1. Apply the patch. 2. In the staff interface, go to More > About > Licenses. 3. Scroll to Cypress and note the library name and licensing information. Signed-off-by: David Nind <david@davidnind.com>
Thanks for the patch Aman! I've also added a patch for Cypress (I didn't include the version number), and amended the commit messages so that are consistent. I'm not sure about the license version for Vue - in the current main, node_modules/view/package.json says 3.5.13, rather than 3.5.4. I've also added a release note. David Nind
(In reply to David Nind from comment #5) > Thanks for the patch Aman! > > I've also added a patch for Cypress (I didn't include the version number), > and amended the commit messages so that are consistent. Thanks! > > I'm not sure about the license version for Vue - in the current main, > node_modules/view/package.json says 3.5.13, rather than 3.5.4. We got this from package.json under 'dependencies': "vue": "^3.5.4", But can see now the different version in node_modules/vue/package.json { "name": "vue", "version": "3.5.13", } Is there any guidance on which we should use? > > I've also added a release note. > > David Nind
(In reply to Aleisha Amohia from comment #6) > (In reply to David Nind from comment #5) > > I'm not sure about the license version for Vue - in the current main, > > node_modules/view/package.json says 3.5.13, rather than 3.5.4. > > We got this from package.json under 'dependencies': > > "vue": "^3.5.4", > > But can see now the different version in node_modules/vue/package.json > > { > "name": "vue", > "version": "3.5.13", > } > > Is there any guidance on which we should use? ^3.5.4 means minimum 3.5.4. Then 3.5.13 is the version we are using, which will certainly change soon. You should not use the exact version but "VueJS 3" instead I would say.
Created attachment 184499 [details] [review] Bug 32244: (follow-up) Update Vue.js version and terminology Update to show license version as v3, instead of the specific minor and point release. Update license to use US American spelling. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 184900 [details] [review] Bug 32244: Add Vue license information to the about page This patch updates the license page with information about Vue. Test plan: 1. Apply the patch. 2. In the staff interface, go to More > About > Licenses. 3. Scroll down to Vue and note the library name and licensing information. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 184901 [details] [review] Bug 32244: Add Cypress license information to the about page This patch updates the license page with information about Cypress. Test plan: 1. Apply the patch. 2. In the staff interface, go to More > About > Licenses. 3. Scroll to Cypress and note the library name and licensing information. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 184902 [details] [review] Bug 32244: (follow-up) Update Vue.js version and terminology Update to show license version as v3, instead of the specific minor and point release. Update license to use US American spelling. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 184904 [details] [review] Bug 32244: (QA follow-up) Fixed html formatting and added link for Cypress
Nice work everyone! Pushed to main for 25.11
Thanks Brendan for the QA follow-up!