Bug 32257 - Label for patron attributes misaligned on patron batch mod
Summary: Label for patron attributes misaligned on patron batch mod
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 34181
  Show dependency treegraph
 
Reported: 2022-11-17 18:41 UTC by Katrin Fischer
Modified: 2023-07-16 14:01 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01


Attachments
Bug 32257 : Label for Patron Attributes Misaligned (3.29 KB, patch)
2022-11-23 17:19 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32257: Label for patron attributes misaligned (3.27 KB, patch)
2022-11-28 19:27 UTC, David Nind
Details | Diff | Splinter Review
Bug 32257 : Label for Patron Attributes Misaligned (4.27 KB, patch)
2022-12-06 12:14 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32257: Label for Patron Attributes Misaligned (4.27 KB, patch)
2022-12-06 17:01 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32257: Label for Patron Attributes Misaligned (4.26 KB, patch)
2022-12-06 17:08 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32257: Label for patron attributes misaligned (4.31 KB, patch)
2022-12-07 20:18 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32257: Fix capitalization - Patron Attribute (1.27 KB, patch)
2022-12-07 20:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-17 18:41:47 UTC
On the patron batch modification tool, the label for patron attributes is misaligned.
Comment 1 Matt Blenkinsop 2022-11-23 17:19:20 UTC Comment hidden (obsolete)
Comment 2 David Nind 2022-11-28 19:27:00 UTC
Created attachment 144305 [details] [review]
Bug 32257: Label for patron attributes misaligned

Label has now been realigned to match the format of the fields above.

Test plan:
1) Navigate to Tools > Batch patron modification
2) Add either card or borrower numbers to bring up the edit patrons fields
3) "Patron attributes:" is on the far right and above the select box
4) Apply patch and navigate to same area
5) Observe that the Patron attributes option is aligned to match the fields above

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-11-28 19:31:13 UTC
Hi Matt.

I probably should have marked as Failed QA, but have amended your patch as this is an easy change:

1. We normally use sentence case for field labels: I changed "Patron Attribute" to "Patron attribute".

2. Commit message title: I changed the bug title in the patch, see the development guidelines https://wiki.koha-community.org/wiki/Commit_messages#Subject_line

David
Comment 4 Martin Renvoize 2022-11-30 11:04:51 UTC
Thanks for the little fixes in line David.. Great to see a new dev getting welcomed to the community so nicely :)
Comment 5 Katrin Fischer 2022-12-04 13:03:05 UTC
This improves the situation, but there is a remaining alignment issue:

When you click on the plus, the Delete link shows far to the right.

Matt, could you maybe have another look here? Thx!
Comment 6 Matt Blenkinsop 2022-12-06 12:05:34 UTC
Looks like there is an empty span tag with 25% width as a placeholder for info hints for each field. I've amended the JQuery to append the Delete button before this span tag
Comment 7 Matt Blenkinsop 2022-12-06 12:14:01 UTC
Created attachment 144443 [details] [review]
Bug 32257 : Label for Patron Attributes Misaligned

Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button

Test Plan:
1) Navigate to Tools > Batch patron modification
2) Add either card or borrower numbers to bring up the edit patrons fields
3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and  Delete buttons
4) Apply patch and navigate to same area
5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed
Comment 8 Lucas Gass 2022-12-06 16:00:15 UTC
Matt, everything is good looking great here except your commit title. The QA tool complains about that:

* Commit title does not start with 'Bug XXXXX: ' - 32e5a26b389


Can you just change it from 'Bug 32257 ' to 'Bug 32257: ' ?
Comment 9 Matt Blenkinsop 2022-12-06 17:01:04 UTC
Sorry not sure how I managed to add that space in! Just removed it
Comment 10 Matt Blenkinsop 2022-12-06 17:01:25 UTC
Created attachment 144452 [details] [review]
Bug 32257: Label for Patron Attributes Misaligned

Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button

Test Plan:
1) Navigate to Tools > Batch patron modification
2) Add either card or borrower numbers to bring up the edit patrons fields
3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and  Delete buttons
4) Apply patch and navigate to same area
5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed
Comment 11 Lucas Gass 2022-12-06 17:08:57 UTC
Created attachment 144453 [details] [review]
Bug 32257: Label for Patron Attributes Misaligned

Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button

Test Plan:
1) Navigate to Tools > Batch patron modification
2) Add either card or borrower numbers to bring up the edit patrons fields
3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and  Delete buttons
4) Apply patch and navigate to same area
5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 12 Katrin Fischer 2022-12-07 20:13:22 UTC
Comment on attachment 144453 [details] [review]
Bug 32257: Label for Patron Attributes Misaligned

Review of attachment 144453 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
@@ +368,5 @@
>                                          [% END %]
>                                          [% IF ( patron_attributes_codes ) %]
>                                              <li class="attributes">
> +                                                <label style="width:auto;">
> +                                                    <span>Patron Attribute:</span>

This is meant well, but Koha uses sentence case everywhere (it's coding guideline too) :) I'll fix in a tiny follow-up.
Comment 13 Katrin Fischer 2022-12-07 20:18:49 UTC
Created attachment 144489 [details] [review]
Bug 32257: Label for patron attributes misaligned

Label has now been realigned to match the format of the fields above. When clicking to add a new field, the delete button was also misaligned. This has now been reformatted to sit next to the "New" button

Test Plan:
1) Navigate to Tools > Batch patron modification
2) Add either card or borrower numbers to bring up the edit patrons fields
3) "Patron attributes:" is on the far right and above the select box. When adding a new field there is a big gap between the Add and  Delete buttons
4) Apply patch and navigate to same area
5) Observe that the Patron attributes option is aligned to match the fields above and the gap between the buttons has been removed

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Katrin Fischer 2022-12-07 20:18:54 UTC
Created attachment 144490 [details] [review]
Bug 32257: Fix capitalization - Patron Attribute
Comment 15 Tomás Cohen Arazi 2022-12-12 15:21:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 16 Martin Renvoize 2022-12-15 13:21:40 UTC
Nice work everyone!

Pushed to 22.11.x for the next release