Bug 34181 - Batch patron modification tool missing checkboxes to clear field values
Summary: Batch patron modification tool missing checkboxes to clear field values
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Katrin Fischer
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 32257
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-30 21:13 UTC by Catrina Berka
Modified: 2023-09-13 20:50 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.09


Attachments
22.05 Batch Patron Modification Tool with Checkboxes (116.04 KB, image/png)
2023-06-30 21:13 UTC, Catrina Berka
Details
Bug 34181: Fix jQuery selector to make delete checkboxes reappear (1.78 KB, patch)
2023-07-16 14:15 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34181: Fix jQuery selector to make delete checkboxes reappear (1.85 KB, patch)
2023-07-17 14:31 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34181: Fix jQuery selector to make delete checkboxes reappear (1.91 KB, patch)
2023-07-19 14:16 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Catrina Berka 2023-06-30 21:13:52 UTC
Created attachment 152920 [details]
22.05 Batch Patron Modification Tool with Checkboxes

When using the batch patron modification tool in 22.05, you could select one of the boxes to the right of the field to clear the value. The instructions for this feature are in 22.11, but the checkboxes and functionality is missing. See attached screenshots for examples.
Comment 1 AspenCat Team 2023-07-12 15:54:08 UTC
This is something we use fairly regularly and without it, it would require a much more time consuming overlay with a patron file.  In some cases we would have too many patrons to go that route without having to bother ByWater with something that used to take a couple of minutes. - Bob
Comment 2 Jennifer Marlatt 2023-07-13 22:06:58 UTC
We use this feature at least once a week. I have a workaround in place, but takes significantly more time to complete what was once a quick and simple task.
Comment 3 Katrin Fischer 2023-07-16 13:45:49 UTC
The checkboxes are still there, but they are set to 'display:none' in the source code.
Comment 4 Katrin Fischer 2023-07-16 14:01:29 UTC
A git bisect points to:
Bug 32257 - Label for patron attributes misaligned on patron batch mod
Comment 5 Katrin Fischer 2023-07-16 14:15:32 UTC
Created attachment 153521 [details] [review]
Bug 34181: Fix jQuery selector to make delete checkboxes reappear

Bug 32257 changed the page structure slightly to fix a display
issue with the labels. This resulted in a broken selector in the
function for displaying the checkboxes for deleting/emptying a
certain patron field.

To test:
* Go to Tools > Batch patron modifications
* Enter some cardnumbers or borrowernumbers
* On the batch patron edit form, verify that the checkboxes
  behind each input field are missing
* Apply patch
* Verify the checkboxes reappeared
  * Verify that for mandatory fields the checkbox is locked
* Make some batch edits and verify the checkboxes work as
  intended
Comment 6 ByWater Sandboxes 2023-07-17 14:31:01 UTC
Created attachment 153558 [details] [review]
Bug 34181: Fix jQuery selector to make delete checkboxes reappear

Bug 32257 changed the page structure slightly to fix a display
issue with the labels. This resulted in a broken selector in the
function for displaying the checkboxes for deleting/emptying a
certain patron field.

To test:
* Go to Tools > Batch patron modifications
* Enter some cardnumbers or borrowernumbers
* On the batch patron edit form, verify that the checkboxes
  behind each input field are missing
* Apply patch
* Verify the checkboxes reappeared
  * Verify that for mandatory fields the checkbox is locked
* Make some batch edits and verify the checkboxes work as
  intended

Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>
Comment 7 Lisette Scheer 2023-07-17 15:09:33 UTC
Worked as expected!
Lisette
Comment 8 Katrin Fischer 2023-07-17 15:13:37 UTC
Thanks, Lisette :)
Comment 9 Martin Renvoize 2023-07-19 14:16:51 UTC
Created attachment 153662 [details] [review]
Bug 34181: Fix jQuery selector to make delete checkboxes reappear

Bug 32257 changed the page structure slightly to fix a display
issue with the labels. This resulted in a broken selector in the
function for displaying the checkboxes for deleting/emptying a
certain patron field.

To test:
* Go to Tools > Batch patron modifications
* Enter some cardnumbers or borrowernumbers
* On the batch patron edit form, verify that the checkboxes
  behind each input field are missing
* Apply patch
* Verify the checkboxes reappeared
  * Verify that for mandatory fields the checkbox is locked
* Make some batch edits and verify the checkboxes work as
  intended

Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2023-07-19 14:17:16 UTC
All working as described.. Passing QA
Comment 11 Tomás Cohen Arazi 2023-07-24 17:03:26 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 12 Fridolin Somers 2023-07-25 20:23:51 UTC
Pushed to 23.05.x for 23.05.02
Comment 13 Pedro Amorim 2023-08-17 16:05:54 UTC
Nice work everyone!

Pushed to 22.11.x for next release