Created attachment 152920 [details] 22.05 Batch Patron Modification Tool with Checkboxes When using the batch patron modification tool in 22.05, you could select one of the boxes to the right of the field to clear the value. The instructions for this feature are in 22.11, but the checkboxes and functionality is missing. See attached screenshots for examples.
This is something we use fairly regularly and without it, it would require a much more time consuming overlay with a patron file. In some cases we would have too many patrons to go that route without having to bother ByWater with something that used to take a couple of minutes. - Bob
We use this feature at least once a week. I have a workaround in place, but takes significantly more time to complete what was once a quick and simple task.
The checkboxes are still there, but they are set to 'display:none' in the source code.
A git bisect points to: Bug 32257 - Label for patron attributes misaligned on patron batch mod
Created attachment 153521 [details] [review] Bug 34181: Fix jQuery selector to make delete checkboxes reappear Bug 32257 changed the page structure slightly to fix a display issue with the labels. This resulted in a broken selector in the function for displaying the checkboxes for deleting/emptying a certain patron field. To test: * Go to Tools > Batch patron modifications * Enter some cardnumbers or borrowernumbers * On the batch patron edit form, verify that the checkboxes behind each input field are missing * Apply patch * Verify the checkboxes reappeared * Verify that for mandatory fields the checkbox is locked * Make some batch edits and verify the checkboxes work as intended
Created attachment 153558 [details] [review] Bug 34181: Fix jQuery selector to make delete checkboxes reappear Bug 32257 changed the page structure slightly to fix a display issue with the labels. This resulted in a broken selector in the function for displaying the checkboxes for deleting/emptying a certain patron field. To test: * Go to Tools > Batch patron modifications * Enter some cardnumbers or borrowernumbers * On the batch patron edit form, verify that the checkboxes behind each input field are missing * Apply patch * Verify the checkboxes reappeared * Verify that for mandatory fields the checkbox is locked * Make some batch edits and verify the checkboxes work as intended Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>
Worked as expected! Lisette
Thanks, Lisette :)
Created attachment 153662 [details] [review] Bug 34181: Fix jQuery selector to make delete checkboxes reappear Bug 32257 changed the page structure slightly to fix a display issue with the labels. This resulted in a broken selector in the function for displaying the checkboxes for deleting/emptying a certain patron field. To test: * Go to Tools > Batch patron modifications * Enter some cardnumbers or borrowernumbers * On the batch patron edit form, verify that the checkboxes behind each input field are missing * Apply patch * Verify the checkboxes reappeared * Verify that for mandatory fields the checkbox is locked * Make some batch edits and verify the checkboxes work as intended Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All working as described.. Passing QA
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.02
Nice work everyone! Pushed to 22.11.x for next release