Created attachment 144048 [details] [review] Bug 32260: Patron autocomplete - Do not display an alert if request is rejected Not sure what is going on exactly, neither if this patch is the correct way to fix this. The request is "rejected" at some point (by the browser?), when we search for patrons using the autocomplete and DT "at the same time". To recreate: Don't apply this patch Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5 Search for "edn" then hit enter You may see an alert, that will disappear If you don't see the alert, repeat This patch suggests to ignore the alert if the status of the request is "rejected".
Created attachment 144057 [details] [review] Bug 32260: Patron autocomplete - Do not display an alert if request is rejected Not sure what is going on exactly, neither if this patch is the correct way to fix this. The request is "rejected" at some point (by the browser?), when we search for patrons using the autocomplete and DT "at the same time". To recreate: Don't apply this patch Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5 Search for "edn" then hit enter You may see an alert, that will disappear If you don't see the alert, repeat This patch suggests to ignore the alert if the status of the request is "rejected". Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I was able to reproduce this problem by following the test plan, bug specifically: - You must search for a string which will return only one result. - You must enter the string and hit ENTER before the autocomplete has time to show any results. I was able to do this by copying the string and using Ctrl-V to quickly paste and hit enter right away.
Created attachment 144092 [details] [review] Bug 32260: Patron autocomplete - Do not display an alert if request is rejected Not sure what is going on exactly, neither if this patch is the correct way to fix this. The request is "rejected" at some point (by the browser?), when we search for patrons using the autocomplete and DT "at the same time". To recreate: Don't apply this patch Go to /cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=5 Search for "edn" then hit enter You may see an alert, that will disappear If you don't see the alert, repeat This patch suggests to ignore the alert if the status of the request is "rejected". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!