It would be nice to have a descriptive resolution text for different standard resolutions to catalog problems reported via the new catalog concerns feature. We're envisaging using the authorized values system to populate a drop down of resolutions available.
Created attachment 160211 [details] [review] Bug 32435: Add status to ticket_updates table
Created attachment 160212 [details] [review] Bug 32435: DBIC Schema dump
Created attachment 160213 [details] [review] Bug 32435: Add status to ticket_update definition
Created attachment 160214 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above.
Created attachment 160260 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value
Created attachment 160261 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above.
Created attachment 160291 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com>
Created attachment 160292 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 160306 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above.
Created attachment 160321 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com>
Created attachment 160322 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 162493 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164919 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164920 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Quick rebase to make sure it all still applies.
Created attachment 164921 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164922 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Tidied the db update to pass QA scripts.
Should I repeat the signoff? Is this necessary after such a db update?
Created attachment 165558 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165559 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165565 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165566 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165567 [details] [review] Bug 32435: Unit tests for Ticket/Ticket::Update change We add a fallback to allow TICKET_RESOLUTIONS to be returned in the strings_map as additional TICKET_STATUS states.
Created attachment 165611 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165612 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165613 [details] [review] Bug 32435: Unit tests for Ticket/Ticket::Update change We add a fallback to allow TICKET_RESOLUTIONS to be returned in the strings_map as additional TICKET_STATUS states. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Passing QA but with the following remarks: WARN t/db_dependent/Koha/Ticket.t WARN tidiness The file is less tidy than before (bad/messy lines before: 44, now: 48) WARN t/db_dependent/Koha/Ticket/Update.t WARN tidiness The file is less tidy than before (bad/messy lines before: 10, now: 14) Added Resolved_2 status. Resolved a concern. Resolved_2 does not show up under main status. But is listed (suboptimal) when clicking details. my $av = Koha::AuthorisedValues->search( { category => 'TICKET_STATUS', authorised_value => $self->status, } ); # Fall back to TICKET_RESOLUTION as needed if ( !$av->count ) { $av = Koha::AuthorisedValues->search( { category => 'TICKET_RESOLUTION', authorised_value => $self->status, } ); } No blocker. But not sure if we create maintainable code when we are going to look for statuses in several AVs.
Created attachment 165656 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165657 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165658 [details] [review] Bug 32435: Unit tests for Ticket/Ticket::Update change We add a fallback to allow TICKET_RESOLUTIONS to be returned in the strings_map as additional TICKET_STATUS states. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Just fixed the Tidy issue. I agree with the somewhat odd use of two AV's.. I couldn't come up with a better solution that gave the end result people wanted.. maybe we'll eventually migrate these out of AV's though if they end up with a stronger workflow management piece.. which is planned.. at that point I could see a 'flag' being added that marked some as 'resolutions' vs 'general status' steps. I'll certainly bear that in mind for the future. Thanks for the review.
Waiting for rebase of dependency. Please switch back to Passed QA once resolved.
Created attachment 165781 [details] [review] Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165782 [details] [review] Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165783 [details] [review] Bug 32435: Unit tests for Ticket/Ticket::Update change We add a fallback to allow TICKET_RESOLUTIONS to be returned in the strings_map as additional TICKET_STATUS states. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x