Bug 32710 - UI/Form/Builder/Item.t is failing randomly (itemtypes sort)
Summary: UI/Form/Builder/Item.t is failing randomly (itemtypes sort)
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 28445
Blocks: 25551 37870
  Show dependency treegraph
 
Reported: 2023-01-24 15:11 UTC by Jonathan Druart
Modified: 2024-09-10 08:41 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:


Attachments
Bug 32710: Try to prevent UI/Form/Builder/Item.t to fail randomly (2.19 KB, patch)
2023-03-31 08:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32710: Try to prevent UI/Form/Builder/Item.t to fail randomly (2.24 KB, patch)
2023-03-31 09:33 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-01-24 15:11:20 UTC
koha_1       |         #   Failed test 'Item types should be sorted by description and an empty entry should be shown'
koha_1       |         #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 135.
koha_1       |         #     Structures begin differing at:
koha_1       |         #          $got->[8] = 'TjMK6RmH'
koha_1       |         #     $expected->[8] = 'REF'
koha_1       |         # Looks like you failed 1 test of 2.
koha_1       | 
koha_1       |     #   Failed test 'itemtypes'
koha_1       |     #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 143.
koha_1       |     # Looks like you failed 1 test of 5.
koha_1       | 
koha_1       | #   Failed test 'authorised values'
koha_1       | #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 144.
koha_1       | # Looks like you failed 1 test of 9.
koha_1       | [15:16:06] t/db_dependent/Koha/UI/Form/Builder/Item.t

Koha_Master_D10/1006
Comment 1 Jonathan Druart 2023-03-31 07:33:52 UTC
koha_1       |         #   Failed test 'Item types should be sorted by description and an empty entry should be shown'
koha_1       |         #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 135.
koha_1       |         #     Structures begin differing at:
koha_1       |         #          $got->[11] = 'qbZe6s__5Y'
koha_1       |         #     $expected->[11] = 'REF'
koha_1       |         # Looks like you failed 1 test of 2.
koha_1       | 
koha_1       |     #   Failed test 'itemtypes'
koha_1       |     #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 143.
koha_1       |     # Looks like you failed 1 test of 5.
koha_1       | 
koha_1       | #   Failed test 'authorised values'
koha_1       | #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 144.
koha_1       | # Looks like you failed 1 test of 9.
koha_1       | [16:48:09] t/db_dependent/Koha/UI/Form/Builder/Item.t

Koha_Master/2449
Comment 2 Jonathan Druart 2023-03-31 08:40:26 UTC
Created attachment 149018 [details] [review]
Bug 32710: Try to prevent UI/Form/Builder/Item.t to fail randomly

See the FIXME, and commit 77a34e099a9f3bcef2076a4170e8c8d843c403eb
Actually we are doing the trick (of removing _) before we are creating
another itemtype, we need to do it right before we are comparing.

Test plan:
Run in a loop, be patient, it failed for me (without the patch) at run
245
Comment 3 Tomás Cohen Arazi (tcohen) 2023-03-31 09:33:58 UTC
Created attachment 149020 [details] [review]
Bug 32710: Try to prevent UI/Form/Builder/Item.t to fail randomly

See the FIXME, and commit 77a34e099a9f3bcef2076a4170e8c8d843c403eb
Actually we are doing the trick (of removing _) before we are creating
another itemtype, we need to do it right before we are comparing.

Test plan:
Run in a loop, be patient, it failed for me (without the patch) at run
245

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-03-31 10:04:18 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-04-11 11:20:03 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Jonathan Druart 2024-08-27 12:16:00 UTC
Koha_Main_D11 run #681 on Docker_13

12:41:15 koha_1       |         #   Failed test at t/db_dependent/Koha/UI/Form/Builder/Item.t line 104.
12:41:15 koha_1       |         #     Structures begin differing at:
12:41:15 koha_1       |         #          $got->[2] = 'jNZJX3dNq'
12:41:15 koha_1       |         #     $expected->[2] = 'lcc'
12:41:15 koha_1       | 
12:41:15 koha_1       |         #   Failed test at t/db_dependent/Koha/UI/Form/Builder/Item.t line 108.
12:41:15 koha_1       |         #     Structures begin differing at:
12:41:15 koha_1       |         #          $got->{jNZJX3dNq} = 'VgHW_hzenA'
12:41:15 koha_1       |         #     $expected->{jNZJX3dNq} = Does not exist
12:41:15 koha_1       |         # Looks like you failed 2 tests of 2.
12:41:15 koha_1       | 
12:41:15 koha_1       |     #   Failed test 'cn_source'
12:41:15 koha_1       |     #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 112.
12:41:15 koha_1       |     # Looks like you failed 1 test of 5.
12:41:15 koha_1       | 
12:41:15 koha_1       | #   Failed test 'authorised values'
12:41:15 koha_1       | #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 150.
12:41:15 koha_1       | # Looks like you failed 1 test of 9.
12:41:15 koha_1       | [10:41:02] t/db_dependent/Koha/UI/Form/Builder/Item.t
Comment 7 Jonathan Druart 2024-09-03 14:23:21 UTC
Koha_Main_U24/73/ Docker_10

07:56:32 koha_1       |         #   Failed test at t/db_dependent/Koha/UI/Form/Builder/Item.t line 104.
07:56:32 koha_1       |         #     Structures begin differing at:
07:56:32 koha_1       |         #          $got->[1] = 'LPSRMWmf'
07:56:32 koha_1       |         #     $expected->[1] = 'ddc'
07:56:32 koha_1       | 
07:56:32 koha_1       |         #   Failed test at t/db_dependent/Koha/UI/Form/Builder/Item.t line 108.
07:56:32 koha_1       |         #     Structures begin differing at:
07:56:32 koha_1       |         #          $got->{LPSRMWmf} = 'pZtLIdi5k'
07:56:32 koha_1       |         #     $expected->{LPSRMWmf} = Does not exist
07:56:32 koha_1       |         # Looks like you failed 2 tests of 2.
07:56:32 koha_1       | 
07:56:32 koha_1       |     #   Failed test 'cn_source'
07:56:32 koha_1       |     #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 112.
07:56:32 koha_1       |     # Looks like you failed 1 test of 5.
07:56:32 koha_1       | 
07:56:32 koha_1       | #   Failed test 'authorised values'
07:56:32 koha_1       | #   at t/db_dependent/Koha/UI/Form/Builder/Item.t line 150.
07:56:32 koha_1       | # Looks like you failed 1 test of 9.
07:56:32 koha_1       | [05:51:21] t/db_dependent/Koha/UI/Form/Builder/Item.t



Failing on Biblio.t as well

07:45:12 koha_1       |     #   Failed test at t/db_dependent/Koha/UI/Form/Builder/Biblio.t line 147.
07:45:12 koha_1       |     #     Structures begin differing at:
07:45:12 koha_1       |     #          $got->[1] = 'LPSRMWmf'
07:45:12 koha_1       |     #     $expected->[1] = 'ddc'
07:45:12 koha_1       |     # Looks like you failed 1 test of 3.
07:45:12 koha_1       | 
07:45:12 koha_1       | #   Failed test 'generate_subfield_form class sources'
07:45:12 koha_1       | #   at t/db_dependent/Koha/UI/Form/Builder/Biblio.t line 148.