Currently, the basket summary page only puts the 'Orders' detail inside a page-section (and even if there are no orders associated with the basket yet, the page-section displays as an empty white block. I think, for consistency with other area's in the staff client, we should also put the other basket details in their own respective page-section 'cards'.
Created attachment 145688 [details] Card locations
Created attachment 145689 [details] [review] Bug 32733: Add page-section cards to basket summary This patch adds two new page-section divs to the basket summary page. One for each column of details in the top area of the summary page.
Set to NSO to gather comments. I've basically tried to make the display more closely match that of the patron details display page.
Created attachment 145691 [details] [review] Bug 32733: Add page-section cards to basket summary This patch adds two new page-section divs to the basket summary page. One for each column of details in the top area of the summary page. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 145692 [details] [review] Bug 32733: (follow-up) Reorganize classification of information If we're dividing the sections into labeled "Information" and "Settings," I propose that we try to put under "Information" lines which are just for display, and under "Settings" lines which allow the user to change things: Managed by, managing library, basket group, etc. This patch moves a few lines to accomplish this. The only other change is to remove a "float:left" inline style from the "Change library" form to make it display better.
Created attachment 145693 [details] [review] Bug 32733: (follow-up) Reorganize classification of information If we're dividing the sections into labeled "Information" and "Settings," I propose that we try to put under "Information" lines which are just for display, and under "Settings" lines which allow the user to change things: Managed by, managing library, basket group, etc. This patch moves a few lines to accomplish this. The only other change is to remove a "float:left" inline style from the "Change library" form to make it display better. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145738 [details] [review] Bug 32733: Add page-section cards to basket summary This patch adds two new page-section divs to the basket summary page. One for each column of details in the top area of the summary page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 145739 [details] [review] Bug 32733: (follow-up) Reorganize classification of information If we're dividing the sections into labeled "Information" and "Settings," I propose that we try to put under "Information" lines which are just for display, and under "Settings" lines which allow the user to change things: Managed by, managing library, basket group, etc. This patch moves a few lines to accomplish this. The only other change is to remove a "float:left" inline style from the "Change library" form to make it display better. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport