Bug 32955 - Standardize structure around action fieldsets in various templates
Summary: Standardize structure around action fieldsets in various templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32746
Blocks: 32744
  Show dependency treegraph
 
Reported: 2023-02-13 18:32 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 32955: Standardize structure around action fieldsets in various templates (8.55 KB, patch)
2023-02-13 18:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32955: Standardize structure around action fieldsets in various templates (8.56 KB, patch)
2023-02-23 21:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32955: Standardize structure around action fieldsets in various templates (8.60 KB, patch)
2023-03-29 13:31 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 32955: Standardize structure around action fieldsets in various templates (8.65 KB, patch)
2023-04-09 11:27 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-13 18:32:05 UTC
As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers templates in lables, patrons, offline circulation, patron cards, and point of sale.
Comment 1 Owen Leonard 2023-02-13 18:46:21 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-02-23 21:18:42 UTC
Created attachment 147270 [details] [review]
Bug 32955: Standardize structure around action fieldsets in various templates

This patch updates various templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and check the following pages to confirm that
changes to form structure look correct:

- Cataloging -> Quick spine label creator
- Patrons -> Patron details -> Files
- Patrons -> Patron details -> Housebound
- Circulation -> Upload offline circulation file
- Tools -> Patron card creator -> Manage -> Images
- Point of sale -> Transaction history -> "Older transactions" form
Comment 3 Philip Orr 2023-03-29 13:31:27 UTC
Created attachment 148915 [details] [review]
Bug 32955: Standardize structure around action fieldsets in various templates

This patch updates various templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and check the following pages to confirm that
changes to form structure look correct:

- Cataloging -> Quick spine label creator
- Patrons -> Patron details -> Files
- Patrons -> Patron details -> Housebound
- Circulation -> Upload offline circulation file
- Tools -> Patron card creator -> Manage -> Images
- Point of sale -> Transaction history -> "Older transactions" form

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 4 Katrin Fischer 2023-04-09 11:27:00 UTC
Created attachment 149351 [details] [review]
Bug 32955: Standardize structure around action fieldsets in various templates

This patch updates various templates so that fieldsets with the
"action" class are placed outside the form's main fieldset.

To test, apply the patch and check the following pages to confirm that
changes to form structure look correct:

- Cataloging -> Quick spine label creator
- Patrons -> Patron details -> Files
- Patrons -> Patron details -> Housebound
- Circulation -> Upload offline circulation file
- Tools -> Patron card creator -> Manage -> Images
- Point of sale -> Transaction history -> "Older transactions" form

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-04-14 14:20:00 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-04-18 12:11:53 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-05-05 22:22:02 UTC
Missing 22.05.x dependencies. No backport.