Bug 32781 - CreateEHoldingsFromBiblios not dealing with non-existent package correcly
Summary: CreateEHoldingsFromBiblios not dealing with non-existent package correcly
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 30943
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-01 15:12 UTC by Jonathan Druart
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32781: Prevent import from list to fail if package does not exist (5.11 KB, patch)
2023-02-01 15:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32781: Prevent import from list to fail if package does not exist (5.16 KB, patch)
2023-02-02 09:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32781: Prevent import from list to fail if package does not exist (5.22 KB, patch)
2023-03-10 15:47 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-02-01 15:12:29 UTC

    
Comment 1 Jonathan Druart 2023-02-01 15:25:33 UTC
Created attachment 145959 [details] [review]
Bug 32781: Prevent import from list to fail if package does not exist

This is theorical (caught when writting tests) but we need to deal with
it.

Can't call method "resources" on an undefined value at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 94.

Test plan:
  prove t/db_dependent/Koha/BackgroundJob/CreateEHoldingsFromBiblios.t
must return green
Comment 2 Pedro Amorim 2023-02-01 17:30:34 UTC
This is not applying for me:
Applying: Bug 32781: Prevent import from list to fail if package does not exist
error: sha1 information is lacking or useless (Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm).
error: could not build fake ancestor
Comment 3 Jonathan Druart 2023-02-01 20:34:00 UTC
(In reply to Pedro Amorim from comment #2)
> This is not applying for me:
> Applying: Bug 32781: Prevent import from list to fail if package does not
> exist
> error: sha1 information is lacking or useless
> (Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm).
> error: could not build fake ancestor

I was missing  dependency. It needs bug 32779 then bug 30943, and finally this one.
Comment 4 Pedro Amorim 2023-02-02 09:21:39 UTC
Created attachment 145992 [details] [review]
Bug 32781: Prevent import from list to fail if package does not exist

This is theorical (caught when writting tests) but we need to deal with
it.

Can't call method "resources" on an undefined value at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 94.

Test plan:
  prove t/db_dependent/Koha/BackgroundJob/CreateEHoldingsFromBiblios.t
must return green

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Kyle M Hall 2023-03-10 15:47:37 UTC
Created attachment 148077 [details] [review]
Bug 32781: Prevent import from list to fail if package does not exist

This is theorical (caught when writting tests) but we need to deal with
it.

Can't call method "resources" on an undefined value at /kohadevbox/koha/Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm line 94.

Test plan:
  prove t/db_dependent/Koha/BackgroundJob/CreateEHoldingsFromBiblios.t
must return green

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2023-03-13 19:05:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-03-14 10:44:40 UTC
Nice work everyone!

Pushed to stable for 22.11.x