When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item. This feature broke in v22.05.00 and is still broken [*] in the current master (ac1e80400d), as the <img> tag for the item type icon points to a path that begins with: /opac-tmpl/bootstrap/itemtypeimg instead of the correct path that begins with: /intranet-tmpl/prog/img/itemtypeimg So, instead of fetching the corresponding item type icon you get a 404 in your web server logs and the default 'broken image URL' image in your web browser. I will attach a couple of screenshots to demonstrate the problem. `git bisect` tells me that the relevant commit is d4855131e3b8e5852f221182ed9588f4ddc67368 from Bug 29660. [*] Please note: the bug outlined above occurs on Debian package installations. Koha instances created using koha-testing-docker or the Koha Sandboxes seem to be unaffected. I believe this has to do with the values of the <intrahtdocs> and <opachtdocs> settings in koha-conf.xml, and the fact that Gitified instances served by Apache use the same DocumentRoot path in their VirtualHost directives for both the OPAC and the Staff interface. However, when trying to reproduce this bug on Koha instances created with methods other than a Debian package install, you can still observe that the item type icon URL is wrong by right-clicking on the icon and selecting 'Inspect' to see its properties.
Created attachment 146389 [details] When trying to place a hold, no item type icon is displayed
Created attachment 146390 [details] When trying to place a hold, the item type icon is displayed correctly
Steps to reproduce: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon Then, visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser. [If you try the above in a Dockerised Koha instance the icon will -most likely- be displayed just fine. However, you can still verify that it's being loaded from the wrong path by right-clicking on the icon and selecting 'Inspect'.]
Created attachment 146391 [details] [review] Bug 32909: Load item type icons from the correct path When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item in the 'Item type' column. This feature broke in v22.05.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*] [*] In non-Debian package installs, the 'href' property of the item type icon's <img> tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, restart Plack and refresh the page. The item type icon should now be displayed correctly. KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect': the 'href' property of the <img> tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg'
I just wanted to point out that this bug is similar to the one George reported in Bug 32908, but actually has a different scope as it occurs when trying to place a hold. It also affects a wider range of Koha versions (v22.05.00 onwards) and has a test plan that's slightly different. Which is why I decided to submit a separate bug report and not a follow-up patch.
(In reply to Andreas Roussos from comment #4) > Created attachment 146391 [details] [review] [review] > Bug 32909: Load item type icons from the correct path > > When placing an item-level hold in the Staff interface, > the table at the bottom of the screen (under the "Place > a hold on a specific item" heading) should display the > icon associated with the item type of each item in the > 'Item type' column. > > This feature broke in v22.05.00 (for Debian package installs): > instead of the item type icon you get the default 'broken > image URL' image of your web browser. > > This patch fixes that. > > Test plan: > > 1) (if needed) Configure the following System preferences: > - item-level_itypes => 'specific item' > - noItemTypeImages => 'Show' > > 2) (if needed) In Koha Administration > Item types, create > an item type and associate it with an icon > > 3) (if needed) Create a test bibliographic record, and add > an item to it that has an item type with an icon > > 4) Visit the bibliographic record's details page in the > Staff interface. Select 'Holds' on the left hand side, > then pick a patron. The "Place a hold on ..." page should > load. In the 'Item type' column of the table at the bottom > of the screen notice that instead of seeing the icon > associated with the item type of each item you get the > default 'broken image URL' image of your web browser [*] > > [*] In non-Debian package installs, the 'href' property > of the item type icon's <img> tag should start with > '/opac-tmpl/bootstrap/itemtypeimg' > > 5) Apply this patch, restart Plack and refresh the page. > The item type icon should now be displayed correctly. > > KTD and Koha Sandboxes users: To verify the patch has > worked, you should right-click on the item type icon and > click 'Inspect': the 'href' property of the <img> tag > should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 146494 [details] [review] Bug 32909: Load item type icons from the correct path When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item in the 'Item type' column. This feature broke in v22.05.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*] [*] In non-Debian package installs, the 'href' property of the item type icon's <img> tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, restart Plack and refresh the page. The item type icon should now be displayed correctly. KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect': the 'href' property of the <img> tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All working, No qa script issues.. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for next release
Backported to 22.05.x for upcoming 22.05.11
applied to 21.11.x for 21.11.19