It can be useful for some kinds of biblio, like comic books
Created attachment 147118 [details] [review] Bug 33035: Add volume column in the item bundle table It can be useful for some kinds of biblio, like comic books Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Make sure that a MARC subfield is mapped to biblioitems.volume 3. Create a biblio with the volume's subfield filled, and create an item for this biblio 4. Add this item to the item bundle 5. In the table showing the bundle contents, you should see a new volume column with your data
Created attachment 147159 [details] [review] Bug 33035: Add volume column in the item bundle table It can be useful for some kinds of biblio, like comic books Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Make sure that a MARC subfield is mapped to biblioitems.volume 3. Create a biblio with the volume's subfield filled, and create an item for this biblio 4. Add this item to the item bundle 5. In the table showing the bundle contents, you should see a new volume column with your data Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
1. Create an item bundle (see bug 28854 comment 458) ↓↓↓ > 2) Creating a new bundle > * Add a new bib record > * Mark the bib record as a 'collection' type by setting leader > position 7 to 'c' > * Add a new item to this bib record > * You should see a new 'Manage bundle' button available in the > 'Actions' column of the Holdings table. Did that change with the redesign? I don't see an action column. I'm in the details page of my record. The Columns setting doesn't list actions.
Code looks good, passing QA :)
oops, wrong tab >_<
Actions column is in the holdings = items table of the bibliographic record. But the feature needs to be activated first too.
Hm, showing volume is quite unsusual. I have to say that I thought this patch was about the enumchron value when I tested it. Volume is not mapped by default in MARC21 and I think not widely used at all. Could we at least make the visibility of the column dependent on there being any data for it? Or could it be a thought to add it to the title display instead of introducing a separate column? - That seems to be the more common way on how we handle title information here. Otherwise I think it might be confusing to most users expecting enumchron as we often display this with the items, but we never display volume from biblioitems.
Created attachment 161627 [details] [review] Bug 33035: Add volume column in the item bundle table It can be useful for some kinds of biblio, like comic books Test plan: 1. Create an item bundle (see bug 28854 comment 458) 2. Make sure that a MARC subfield is mapped to biblioitems.volume 3. Create a biblio with the volume's subfield filled, and create an item for this biblio 4. Add this item to the item bundle 5. In the table showing the bundle contents, you should see a new volume column with your data Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Indeed we see for example in acqui/basket.pl adding volume to title : https://git.koha-community.org/Koha-community/Koha/src/branch/main/acqui/basket.pl#L485 I've look in BNF datas for Naruto, the volume is in 200$h and 461$v. 200$h should be linked to biblio.part_number, maybe add this to title : "data": "biblio.title:biblio.subtitle:biblio.medium" Like does koha-tmpl/intranet-tmpl/prog/en/includes/biblio-title.inc