Bug 33180 - Use template wrapper for tabs: Budgets and Search engine configuration
Summary: Use template wrapper for tabs: Budgets and Search engine configuration
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32571
Blocks: 34625
  Show dependency treegraph
 
Reported: 2023-03-09 15:19 UTC by Owen Leonard
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration (51.17 KB, patch)
2023-03-09 15:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration (52.08 KB, patch)
2023-03-20 17:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration (52.16 KB, patch)
2023-03-29 08:39 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration (52.20 KB, patch)
2023-04-08 22:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-03-09 15:19:52 UTC
Continuing the work of Bug 32571, I would like to update two templates to use the new WRAPPER for tabs: Administration -> Budgets, and Administration -> Search engine configuration.
Comment 1 Owen Leonard 2023-03-09 15:26:11 UTC
Created attachment 148015 [details] [review]
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.
Comment 2 Owen Leonard 2023-03-20 17:16:42 UTC
Created attachment 148422 [details] [review]
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.
Comment 3 Matt Blenkinsop 2023-03-29 08:39:22 UTC
Created attachment 148879 [details] [review]
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 Katrin Fischer 2023-04-08 22:03:26 UTC
Created attachment 149325 [details] [review]
Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration

This patch updates two administration templates so that they use the new
WRAPPER directive to build tabbed navigation: Budgets and Search engine
configuration.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test, apply the patch and check the updated pages:

 - Administration -> Budgets
 - Administration -> Search engine configuration

On both pages tabs should look correct and work correctly.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-04-12 14:44:24 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-16 20:37:40 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.