Created attachment 154849 [details] Screenshot of problem Search engine configuration, when selecting second tab you seen no header. When going down you see the floating header of first tab o_O
I bet it is since Bug 33180
Created attachment 154880 [details] [review] Bug 34625: Fix search engine configuration tables header problem This patch corrects the JavaScript which allows DataTables to be created and destroyed based on which tab is clicked on the search engine configuration page. When you click from one tab to the other, the original tab's DataTable should be destroyed and the new tab's DataTable initialized. To test, apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - The page should load with the "Search fields" tab enabled and the DataTable initialized: Sorting and filtering should work. If you scroll down the page the floating table header should be correct. - Switch to the "Bibliographic records" tab. This table should have filtering enabled, and the floating table header should work when you scroll down the page. - The same should be true for the "Authorities" tab. - Return to the "Search fields" tab to confirm that the DataTable is still working as expected.
Created attachment 154894 [details] [review] Bug 34625: Fix search engine configuration tables header problem This patch corrects the JavaScript which allows DataTables to be created and destroyed based on which tab is clicked on the search engine configuration page. When you click from one tab to the other, the original tab's DataTable should be destroyed and the new tab's DataTable initialized. To test, apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - The page should load with the "Search fields" tab enabled and the DataTable initialized: Sorting and filtering should work. If you scroll down the page the floating table header should be correct. - Switch to the "Bibliographic records" tab. This table should have filtering enabled, and the floating table header should work when you scroll down the page. - The same should be true for the "Authorities" tab. - Return to the "Search fields" tab to confirm that the DataTable is still working as expected. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Created attachment 155206 [details] [review] Bug 34625: Fix search engine configuration tables header problem This patch corrects the JavaScript which allows DataTables to be created and destroyed based on which tab is clicked on the search engine configuration page. When you click from one tab to the other, the original tab's DataTable should be destroyed and the new tab's DataTable initialized. To test, apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - The page should load with the "Search fields" tab enabled and the DataTable initialized: Sorting and filtering should work. If you scroll down the page the floating table header should be correct. - Switch to the "Bibliographic records" tab. This table should have filtering enabled, and the floating table header should work when you scroll down the page. - The same should be true for the "Authorities" tab. - Return to the "Search fields" tab to confirm that the DataTable is still working as expected. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed to master for 23.11. Nice work everyone, thanks!
Noting that this patch also fixes the problem with saving some search mappings changes that was reported in bug 34504 for 23.05. As such, a backport would be greatly appreciated!
*** Bug 34695 has been marked as a duplicate of this bug. ***
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x