Bug 33443 - The "X titles found locally" not displayed
Summary: The "X titles found locally" not displayed
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 32939
Blocks:
  Show dependency tree / graph
 
Reported: 2023-04-07 08:48 UTC by Jonathan Druart
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 33443: Restore "X titles found locally" link from EBSCO title list (1.24 KB, patch)
2023-04-07 09:03 UTC, Jonathan Druart 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-04-07 08:48:38 UTC 
When you are in the EBSCO package or title list view, and you start a new search, there is a link to the local data: "X titles found locally" or "X packages found locally".

However if you are landing into this package with some filters in the URL, the link to local eholdings is not displayed.

/cgi-bin/koha/erm/eholdings/ebsco/titles?publication_title=art

for instance
Comment 1 Jonathan Druart 2023-04-07 08:52:17 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2023-04-07 08:52:33 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2023-04-07 08:58:50 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2023-04-07 09:03:52 UTC 
Created attachment 149255 [details] [review]
Bug 33443: Restore "X titles found locally" link from EBSCO title list

The link is missing, and there was a JS error in the console
Uncaught (in promise) ReferenceError: filters is not defined
Comment 5 Jonathan Druart 2023-04-07 09:06:04 UTC 
and... I think this is fixed by bug 33066.
Comment 6 Pedro Amorim 2023-04-11 11:29:18 UTC 
Can't reproduce the problem before applying patch.
Can't apply patch because already applied from bug 33066.