This patch will modify catalog, basket, and lists templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Created attachment 152128 [details] [review] Bug 33911: Improve translation of title tags: Catalog, basket, and lists This patch updates catalog, basket, and lists templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Advanced search - Search results - Bibliographic details - MARC preview - Image viewer (with local cover images) - MARC details - Labeled MARC details - ISBD details - Items - Checkout history - Rota - Add titles to the cart and view the cart - Send cart - Item search - Lists - View list - New list - Edit list - Send list
Created attachment 155239 [details] [review] Bug 33911: Improve translation of title tags: Catalog, basket, and lists This patch updates catalog, basket, and lists templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Advanced search - Search results - Bibliographic details - MARC preview - Image viewer (with local cover images) - MARC details - Labeled MARC details - ISBD details - Items - Checkout history - Rota - Add titles to the cart and view the cart - Send cart - Item search - Lists - View list - New list - Edit list - Send list Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): - MARC preview: wasn't sure how to test this one - normal view for a record > MARC preview > Show - results in a pop-up window with the title "MARC preview", if you right-click on the 'Show' link and open in a new tab, the title is "MARC View" with a plain text rendition of the MARC record. - Labelled MARC details: set IntranetBiblioDefaultView system preference to 'labelled MARC form', from the search results page this view is displayed. - Rota: enable the StockRotation system preference for the rota tab to display on the record view.
Created attachment 156017 [details] [review] Bug 33911: Improve translation of title tags: Catalog, basket, and lists This patch updates catalog, basket, and lists templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Advanced search - Search results - Bibliographic details - MARC preview - Image viewer (with local cover images) - MARC details - Labeled MARC details - ISBD details - Items - Checkout history - Rota - Add titles to the cart and view the cart - Send cart - Item search - Lists - View list - New list - Edit list - Send list Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 156018 [details] [review] Bug 33911: Move variables into strings This has the advantage that translators can tell the full context and are also able to move the variable if needed for better grammar. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x