Bug 33951 - normalized_oclc not defined in opac-readingrecord.tt
Summary: normalized_oclc not defined in opac-readingrecord.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33949
  Show dependency treegraph
 
Reported: 2023-06-08 09:49 UTC by Jonathan Druart
Modified: 2024-12-23 08:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Circulation function:


Attachments
Bug 33951: Set normalized_oclc in opac/opac-readingrecord.pl (1.22 KB, patch)
2023-06-08 09:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33951: Set normalized_oclc in opac/opac-readingrecord.pl (1.27 KB, patch)
2023-06-08 11:04 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 33951: (QA follow-up) Import GetNormalizedOCLCNumber (735 bytes, patch)
2023-06-08 11:04 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 09:49:15 UTC

    
Comment 1 Jonathan Druart 2023-06-08 09:52:55 UTC
Created attachment 152141 [details] [review]
Bug 33951: Set normalized_oclc in opac/opac-readingrecord.pl

normalized_oclc is used in the template to build the link to syndetics,
but it's not passed from the controller. Is this patch correct? Is
syndetics broken on this page? Should we remove it or keep it?
Is oclc parameter in the URL unecessary and should be removed?
Comment 2 Nick Clemens (kidclamp) 2023-06-08 11:04:18 UTC
Created attachment 152157 [details] [review]
Bug 33951: Set normalized_oclc in opac/opac-readingrecord.pl

normalized_oclc is used in the template to build the link to syndetics,
but it's not passed from the controller. Is this patch correct? Is
syndetics broken on this page? Should we remove it or keep it?
Is oclc parameter in the URL unecessary and should be removed?

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 3 Nick Clemens (kidclamp) 2023-06-08 11:04:20 UTC
Created attachment 152158 [details] [review]
Bug 33951: (QA follow-up) Import GetNormalizedOCLCNumber

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens (kidclamp) 2023-06-08 11:04:42 UTC
Trivial and straightforward, passing QA
Comment 5 Tomás Cohen Arazi (tcohen) 2023-06-08 12:03:02 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-07-12 07:02:00 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 7 Matt Blenkinsop 2023-07-12 09:27:33 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x